Sign upLogin

airbug/bugcore

View on GitHub
Star
libraries/bugcore/js/src/data/Graph.js

Summary

Maintainability
C
1 day
Test Coverage

Similar blocks of code found in 2 locations. Consider refactoring.
Open

                if (!this.containsEdgesTo(edge.getToNode())) {
                    edgeToSet = new Set();
                    this.toNodeToEdgeSetMap.put(edge.getToNode(), edgeToSet);
                } else {
                    edgeToSet = this.getEdgesTo(edge.getToNode());
Severity: Major
Found in libraries/bugcore/js/src/data/Graph.js and 1 other location - About 2 hrs to fix
libraries/bugcore/js/src/data/Graph.js on lines 228..233

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 83.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 2 locations. Consider refactoring.
Open

                if (!this.containsEdgesFrom(edge.getFromNode())) {
                    edgeFromSet = new Set();
                    this.fromNodeToEdgeSetMap.put(edge.getFromNode(), edgeFromSet);
                } else {
                    edgeFromSet = this.getEdgesFrom(edge.getFromNode());
Severity: Major
Found in libraries/bugcore/js/src/data/Graph.js and 1 other location - About 2 hrs to fix
libraries/bugcore/js/src/data/Graph.js on lines 236..241

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 83.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 2 locations. Consider refactoring.
Open

        getEdgesTo: function(toNode) {
            var edgeSet = this.toNodeToEdgeSetMap.get(toNode);
            if (!edgeSet) {
                edgeSet = new Set();
            }
Severity: Minor
Found in libraries/bugcore/js/src/data/Graph.js and 1 other location - About 55 mins to fix
libraries/bugcore/js/src/data/Graph.js on lines 303..309

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 54.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 2 locations. Consider refactoring.
Open

        getEdgesFrom: function(fromNode) {
            var edgeSet = this.fromNodeToEdgeSetMap.get(fromNode);
            if (!edgeSet) {
                edgeSet = new Set();
            }
Severity: Minor
Found in libraries/bugcore/js/src/data/Graph.js and 1 other location - About 55 mins to fix
libraries/bugcore/js/src/data/Graph.js on lines 316..322

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 54.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 5 locations. Consider refactoring.
Open

        removeAllNodes: function(nodes) {
            var _this = this;
            nodes.forEach(function(node) {
                _this.removeNode(node);
            });
Severity: Major
Found in libraries/bugcore/js/src/data/Graph.js and 4 other locations - About 40 mins to fix
libraries/bugcore/js/src/core/Arr.js on lines 138..143
libraries/bugcore/js/src/data/Graph.js on lines 207..212
libraries/bugcore/js/src/data/Graph.js on lines 360..365
libraries/bugcore/js/src/data/ReferenceGraph.js on lines 164..169

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 48.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 5 locations. Consider refactoring.
Open

        removeAllEdges: function(edges) {
            var _this = this;
            edges.forEach(function(edge) {
                _this.removeEdge(edge);
            });
Severity: Major
Found in libraries/bugcore/js/src/data/Graph.js and 4 other locations - About 40 mins to fix
libraries/bugcore/js/src/core/Arr.js on lines 138..143
libraries/bugcore/js/src/data/Graph.js on lines 207..212
libraries/bugcore/js/src/data/Graph.js on lines 394..399
libraries/bugcore/js/src/data/ReferenceGraph.js on lines 164..169

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 48.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 5 locations. Consider refactoring.
Open

        removeNodesForValues: function(values) {
            var _this = this;
            values.forEach(function(value) {
                _this.removeNodeForValue(value);
            });
Severity: Major
Found in libraries/bugcore/js/src/data/Graph.js and 4 other locations - About 40 mins to fix
libraries/bugcore/js/src/core/Arr.js on lines 138..143
libraries/bugcore/js/src/data/Graph.js on lines 360..365
libraries/bugcore/js/src/data/Graph.js on lines 394..399
libraries/bugcore/js/src/data/ReferenceGraph.js on lines 164..169

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 48.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

There are no issues that match your filters.

Category
Status