akissa/clamav-unofficial-updates

View on GitHub

Showing 5 of 5 total issues

Function process has a Cognitive Complexity of 29 (exceeds 5 allowed). Consider refactoring.
Open

def process(queue):
    '''Do the actual work'''
    while True:
        url, directory, gpg_key = queue.get()
        parsed = urlparse(url)
Severity: Minor
Found in clamav_unofficial_updates/__init__.py - About 4 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Function run_updates has a Cognitive Complexity of 9 (exceeds 5 allowed). Consider refactoring.
Open

def run_updates(config):
    '''Run the updates'''
    num_of_threads = config.get('number-threads', 10)
    # startup workers
    log.info('Starting worker %d threads', num_of_threads)
Severity: Minor
Found in clamav_unofficial_updates/__init__.py - About 55 mins to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Function get_readme has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
Open

def get_readme():
    """Generate long description"""
    pandoc = None
    for path in os.environ["PATH"].split(os.pathsep):
        path = path.strip('"')
Severity: Minor
Found in setup.py - About 35 mins to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Function get_addrs has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
Open

def get_addrs(hostname):
    """get addrs"""
    count = 1
    addrs = []
    for passno in range(1, 6):
Severity: Minor
Found in clamav_unofficial_updates/conn.py - About 35 mins to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Function run_cmd has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
Open

def run_cmd(cmd):
    """Run a command"""
    pipe = subprocess.Popen(
        cmd, stdout=subprocess.PIPE, stderr=subprocess.PIPE)
    output = pipe.communicate()[0]
Severity: Minor
Found in clamav_unofficial_updates/utils.py - About 25 mins to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Severity
Category
Status
Source
Language