Sign upLogin

akissa/repoze.who.plugins.saml2

View on GitHub
Star

Showing 4 of 8 total issues

Function get_attributes_from_assertion has a Cognitive Complexity of 30 (exceeds 5 allowed). Consider refactoring.
Open

def get_attributes_from_assertion(assertion):
    attributes = dict()
    if not assertion:
        return attributes
    for _statement in assertion.attributeStatement:
Severity: Minor
Found in repoze/who/plugins/utils.py - About 4 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Function __init__ has 9 arguments (exceeds 4 allowed). Consider refactoring.
Open

    def __init__(
Severity: Major
Found in repoze/who/plugins/saml2.py - About 1 hr to fix

    Function make_saml2_plugin has 9 arguments (exceeds 4 allowed). Consider refactoring.
    Open

    def make_saml2_plugin(
    Severity: Major
    Found in repoze/who/plugins/saml2.py - About 1 hr to fix

      Function get_readme has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
      Open

      def get_readme():
    """Generate long description"""
    pandoc = None
    for path in os.environ["PATH"].split(os.pathsep):
        path = path.strip('"')
      Severity: Minor
      Found in setup.py - About 35 mins to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Severity
      Category
      Status
      Source
      Language