Sign upLogin

alekzonder/maf

View on GitHub
Star
src/Api/Abstract.js

Summary

Maintainability
F
3 days
Test Coverage

File Abstract.js has 256 lines of code (exceeds 250 allowed). Consider refactoring.
Open

var path = require('path');

var _ = require(path.resolve(__dirname, '../vendors/lodash'));
var uuid = require(path.resolve(__dirname, '../vendors/uuid'));
Severity: Minor
Found in src/Api/Abstract.js - About 2 hrs to fix

    Function updateByName has 44 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

        updateByName (name, data) {

        return new Promise((resolve, reject) => {

            var timer = this._createTimer(this.entity + ':updateByName');
    Severity: Minor
    Found in src/Api/Abstract.js - About 1 hr to fix

      Function updateById has 44 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

          updateById (id, data) {

        return new Promise((resolve, reject) => {

            var timer = this._createTimer(this.entity + ':updateById');
      Severity: Minor
      Found in src/Api/Abstract.js - About 1 hr to fix

        Function create has 32 lines of code (exceeds 25 allowed). Consider refactoring.
        Open

            create (data, options) {

        return new Promise((resolve, reject) => {

            var timer = this._createTimer(this.entity + ':create');
        Severity: Minor
        Found in src/Api/Abstract.js - About 1 hr to fix

          Function findOne has 28 lines of code (exceeds 25 allowed). Consider refactoring.
          Open

              findOne (filters, fields) {

        var timer = this._createTimer(this.entity + ':findOne');

        timer.data = {
          Severity: Minor
          Found in src/Api/Abstract.js - About 1 hr to fix

            Function find has 26 lines of code (exceeds 25 allowed). Consider refactoring.
            Open

                find (filters, fields) {

        var timer = this._createTimer(this.entity + ':find');

        timer.data = {filters: filters, fields};
            Severity: Minor
            Found in src/Api/Abstract.js - About 1 hr to fix

              Similar blocks of code found in 2 locations. Consider refactoring.
              Open

                  getByName (name, fields) {

        return new Promise((resolve, reject) => {

            var timer = this._createTimer(this.entity + ':getByName');
              Severity: Major
              Found in src/Api/Abstract.js and 1 other location - About 6 hrs to fix
              src/Api/Abstract.js on lines 230..253

              Duplicated Code

              Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

              Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

              When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

              Tuning

              This issue has a mass of 161.

              We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

              The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

              If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

              See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

              Refactorings

              Further Reading

              Similar blocks of code found in 2 locations. Consider refactoring.
              Open

                  getById (id, fields) {

        return new Promise((resolve, reject) => {

            var timer = this._createTimer(this.entity + ':getById');
              Severity: Major
              Found in src/Api/Abstract.js and 1 other location - About 6 hrs to fix
              src/Api/Abstract.js on lines 199..221

              Duplicated Code

              Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

              Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

              When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

              Tuning

              This issue has a mass of 161.

              We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

              The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

              If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

              See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

              Refactorings

              Further Reading

              Similar blocks of code found in 2 locations. Consider refactoring.
              Open

                          this._validate(data, this._modificationSchema)
            .then((data) => {

                if (this._isEmptyData(data)) {
                    return reject(new this.Error(this.Error.CODES.INVALID_DATA, 'empty data'));
              Severity: Major
              Found in src/Api/Abstract.js and 1 other location - About 3 hrs to fix
              src/Api/Abstract.js on lines 275..309

              Duplicated Code

              Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

              Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

              When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

              Tuning

              This issue has a mass of 100.

              We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

              The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

              If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

              See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

              Refactorings

              Further Reading

              Similar blocks of code found in 2 locations. Consider refactoring.
              Open

                          this._validate(data, this._modificationSchema)
            .then((data) => {

                if (this._isEmptyData(data)) {
                    return reject(new this.Error(this.Error.CODES.INVALID_DATA));
              Severity: Major
              Found in src/Api/Abstract.js and 1 other location - About 3 hrs to fix
              src/Api/Abstract.js on lines 344..378

              Duplicated Code

              Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

              Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

              When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

              Tuning

              This issue has a mass of 100.

              We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

              The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

              If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

              See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

              Refactorings

              Further Reading

              There are no issues that match your filters.

              Category
              Status