Sign upLogin

alekzonder/maf

View on GitHub
Star
src/express/response/helpers/index.js

Summary

Maintainability
C
1 day
Test Coverage

Function exports has 163 lines of code (exceeds 25 allowed). Consider refactoring.
Open

module.exports = function (options) {

    var continueRequestProcessing = false;

    if (options && options.continue) {
Severity: Major
Found in src/express/response/helpers/index.js - About 6 hrs to fix

    Function badRequest has 30 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

            helpers.badRequest = function (error) {

            var message = 'Bad Request';
            var code = null;
            var list = [];
    Severity: Minor
    Found in src/express/response/helpers/index.js - About 1 hr to fix

      Function forbidden has 27 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

              helpers.forbidden = function (message, code, entity) {

            if (message instanceof Error) {
                var error = message;
      Severity: Minor
      Found in src/express/response/helpers/index.js - About 1 hr to fix

        Identical blocks of code found in 2 locations. Consider refactoring.
        Open

                    if (message instanceof Error) {
                var error = message;
                message = error.message;
                code = error.code;
                entity = error.entity;
        Severity: Minor
        Found in src/express/response/helpers/index.js and 1 other location - About 50 mins to fix
        src/express/response/helpers/index.js on lines 148..154

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 51.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        Identical blocks of code found in 2 locations. Consider refactoring.
        Open

                    if (message instanceof Error) {
                var error = message;

                message = error.message;
                code = error.code;
        Severity: Minor
        Found in src/express/response/helpers/index.js and 1 other location - About 50 mins to fix
        src/express/response/helpers/index.js on lines 49..54

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 51.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        There are no issues that match your filters.

        Category
        Status