Showing 13 of 19 total issues
Class Person has 69 methods (exceeds 20 allowed). Consider refactoring. Open
class Person
attr_reader :error
attr_reader :address_book
def initialize(attributes = nil, existing_ab_person = nil, opts = {})Class Person has 47 methods (exceeds 20 allowed). Consider refactoring. Open
class Person
attr_reader :error
attr_reader :address_book
def initialize(target, opts = {})File person.rb has 379 lines of code (exceeds 250 allowed). Consider refactoring. Open
module AddressBook
class Person
attr_reader :error
attr_reader :address_book
Class AddrBook has 22 methods (exceeds 20 allowed). Consider refactoring. Open
class AddrBook
attr_reader :ab
def initialize(&block)
@ab = NullAddrBookClass Group has 21 methods (exceeds 20 allowed). Consider refactoring. Open
class Group
attr_reader :attributes, :error
attr_reader :address_book
def initialize(opts)Method load_ab_person has a Cognitive Complexity of 9 (exceeds 5 allowed). Consider refactoring. Open
def load_ab_person
@attributes ||= {}
SingleValuePropertyMap.each do |ab_property, attr_key|
if attributes[attr_key]- Read upRead up
Cognitive Complexity
Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.
A method's cognitive complexity is based on a few simple rules:
- Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
- Code is considered more complex for each "break in the linear flow of the code"
- Code is considered more complex when "flow breaking structures are nested"
Further reading
Method load_ab_person has a Cognitive Complexity of 9 (exceeds 5 allowed). Consider refactoring. Open
def load_ab_person
@attributes ||= {}
Person.single_value_property_map.each do |ab_property, attr_key|
if attributes[attr_key]- Read upRead up
Cognitive Complexity
Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.
A method's cognitive complexity is based on a few simple rules:
- Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
- Code is considered more complex for each "break in the linear flow of the code"
- Code is considered more complex when "flow breaking structures are nested"
Further reading
Method initialize has a Cognitive Complexity of 9 (exceeds 5 allowed). Consider refactoring. Open
def initialize(&block)
@ab = NullAddrBook
if authorized?
activate!
if block_given?- Read upRead up
Cognitive Complexity
Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.
A method's cognitive complexity is based on a few simple rules:
- Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
- Code is considered more complex for each "break in the linear flow of the code"
- Code is considered more complex when "flow breaking structures are nested"
Further reading
Method import_ab_person has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring. Open
def import_ab_person
@attributes = {}
@modification_date = nil
SingleValuePropertyMap.each do |ab_property, attr_key|- Read upRead up
Cognitive Complexity
Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.
A method's cognitive complexity is based on a few simple rules:
- Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
- Code is considered more complex for each "break in the linear flow of the code"
- Code is considered more complex when "flow breaking structures are nested"
Further reading
Method initialize has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring. Open
def initialize(opts)
unless opts.one?
raise ArgumentError, "MultiValued requires :attributes *or* :ab_multi_value argument"
end
- Read upRead up
Cognitive Complexity
Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.
A method's cognitive complexity is based on a few simple rules:
- Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
- Code is considered more complex for each "break in the linear flow of the code"
- Code is considered more complex when "flow breaking structures are nested"
Further reading
Method initialize has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring. Open
def initialize(opts)
unless opts.one?
raise ArgumentError, "MultiValued requires :attributes *or* :ab_multi_value argument"
end
- Read upRead up
Cognitive Complexity
Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.
A method's cognitive complexity is based on a few simple rules:
- Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
- Code is considered more complex for each "break in the linear flow of the code"
- Code is considered more complex when "flow breaking structures are nested"
Further reading
Method request_authorization has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring. Open
def request_authorization(&block)
synchronous = !block
access_callback = lambda { |granted, error|
# not sure what to do with error ... so we're ignoring it
@address_book_access_granted = granted- Read upRead up
Cognitive Complexity
Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.
A method's cognitive complexity is based on a few simple rules:
- Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
- Code is considered more complex for each "break in the linear flow of the code"
- Code is considered more complex when "flow breaking structures are nested"
Further reading
Method ios6_create has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring. Open
def ios6_create
error = nil
if authorized?
@address_book = ABAddressBookCreateWithOptions(nil, error)
else- Read upRead up
Cognitive Complexity
Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.
A method's cognitive complexity is based on a few simple rules:
- Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
- Code is considered more complex for each "break in the linear flow of the code"
- Code is considered more complex when "flow breaking structures are nested"