alibaba/kt-connect

View on GitHub

Showing 79 of 109 total issues

Avoid deeply nested control flow statements.
Open

        } else if util.IsMacos() {
            dnsPort = opt.Get().Connect.DnsPort
        }
Severity: Major
Found in pkg/kt/command/connect/common.go - About 45 mins to fix

    Function createRouter has 7 return statements (exceeds 4 allowed).
    Open

    func createRouter(routerPodName string, svcName string, ports map[int]int, labels map[string]string, versionMark string) error {
        namespace := opt.Get().Global.Namespace
        routerPod, err := cluster.Ins().GetPod(routerPodName, namespace)
        if err == nil && routerPod.DeletionTimestamp != nil {
            routerPod, err = cluster.Ins().WaitPodTerminate(routerPodName, namespace)
    Severity: Major
    Found in pkg/kt/command/mesh/auto.go - About 45 mins to fix

      Avoid deeply nested control flow statements.
      Open

                  } else if !strings.HasSuffix(l, midDomain) && !strings.HasSuffix(l, fullDomain) {
                      recordsToKeep = append(recordsToKeep, l)
                  }
      Severity: Major
      Found in pkg/kt/service/dns/hosts.go - About 45 mins to fix

        Avoid deeply nested control flow statements.
        Open

                        } else if index == 5 {
                            iface = parts[i]
                        } else if index > 5 {
                            iface = fmt.Sprintf("%s %s", iface, parts[i])
                        }
        Severity: Major
        Found in pkg/kt/service/tun/tun_windows.go - About 45 mins to fix

          Avoid deeply nested control flow statements.
          Open

                          if keepShortDomain {
                              recordsToKeep = append(recordsToKeep, l)
                          }
          Severity: Major
          Found in pkg/kt/service/dns/hosts.go - About 45 mins to fix

            Avoid deeply nested control flow statements.
            Open

                                if _, err = strconv.Atoi(upstreamParts[1]); err == nil {
                                    dnsAddresses = append(dnsAddresses, fmt.Sprintf("udp:%s:%s", upstreamDns, upstreamParts[1]))
                                } else {
                                    dnsAddresses = append(dnsAddresses, fmt.Sprintf("%s:%s:%d", upstreamParts[0], upstreamDns, common.StandardDnsPort))
                                }
            Severity: Major
            Found in pkg/kt/service/dns/dnsserver.go - About 45 mins to fix

              Function SaveProfile has 6 return statements (exceeds 4 allowed).
              Open

              func SaveProfile(args []string) error {
                  if len(args) != 1 {
                      return fmt.Errorf("must specifiy a profile name")
                  }
                  profile := profileFile(args[0])
              Severity: Major
              Found in pkg/kt/command/config/save.go - About 40 mins to fix

                Function GetDeploymentByResourceName has 6 return statements (exceeds 4 allowed).
                Open

                func GetDeploymentByResourceName(resourceName, namespace string) (*appV1.Deployment, error) {
                    resourceType, name, err := ParseResourceName(resourceName)
                    if err != nil {
                        return nil, err
                    }
                Severity: Major
                Found in pkg/kt/command/general/resource.go - About 40 mins to fix

                  Function parsePort has 6 return statements (exceeds 4 allowed).
                  Open

                  func parsePort(args []string) (localPort int, remotePort int, err error) {
                      if len(args) < 2 {
                          // port not specified
                          return -1, -1, nil
                      } else if count := strings.Count(args[1], ":"); count == 0 {
                  Severity: Major
                  Found in pkg/kt/command/forward.go - About 40 mins to fix

                    Function Mesh has 6 return statements (exceeds 4 allowed).
                    Open

                    func Mesh(resourceName string) error {
                        ch, err := general.SetupProcess(util.ComponentMesh)
                        if err != nil {
                            return err
                        }
                    Severity: Major
                    Found in pkg/kt/command/mesh.go - About 40 mins to fix

                      Function NewForwardCommand has 6 return statements (exceeds 4 allowed).
                      Open

                      func NewForwardCommand() *cobra.Command {
                          cmd := &cobra.Command{
                              Use:   "forward",
                              Short: "Redirect local port to a service or any remote address",
                              PreRunE: func(cmd *cobra.Command, args []string) error {
                      Severity: Major
                      Found in pkg/kt/command/forward.go - About 40 mins to fix

                        Function GetServiceByResourceName has 6 return statements (exceeds 4 allowed).
                        Open

                        func GetServiceByResourceName(resourceName, namespace string) (*coreV1.Service, error) {
                            resourceType, name, err := ParseResourceName(resourceName)
                            if err != nil {
                                return nil, err
                            }
                        Severity: Major
                        Found in pkg/kt/command/general/resource.go - About 40 mins to fix

                          Function Show has 6 return statements (exceeds 4 allowed).
                          Open

                          func Show(args []string) error {
                              if len(args) > 0 {
                                  return fmt.Errorf("parameter '%s' is invalid", args[0])
                              }
                              customConfig := loadCustomConfig()
                          Severity: Major
                          Found in pkg/kt/command/config/show.go - About 40 mins to fix

                            Function createRouter has 5 arguments (exceeds 4 allowed). Consider refactoring.
                            Open

                            func createRouter(routerPodName string, svcName string, ports map[int]int, labels map[string]string, versionMark string) error {
                            Severity: Minor
                            Found in pkg/kt/command/mesh/auto.go - About 35 mins to fix

                              Function isNameUsable has 5 return statements (exceeds 4 allowed).
                              Open

                              func isNameUsable(name, meshVersion string, times int) error {
                                  if times > 10 {
                                      return fmt.Errorf("meshing pod for service %s still terminating, please try again later", name)
                                  }
                                  shadowName := name + util.MeshPodInfix + meshVersion
                              Severity: Major
                              Found in pkg/kt/command/mesh/auto.go - About 35 mins to fix

                                Function createStuntmanService has 5 return statements (exceeds 4 allowed).
                                Open

                                func createStuntmanService(svc *coreV1.Service, ports map[int]int) error {
                                    stuntmanSvcName := svc.Name + util.StuntmanServiceSuffix
                                    namespace := opt.Get().Global.Namespace
                                    if stuntmanSvc, err := cluster.Ins().GetService(stuntmanSvcName, namespace); err != nil {
                                        if !k8sErrors.IsNotFound(err) {
                                Severity: Major
                                Found in pkg/kt/command/mesh/auto.go - About 35 mins to fix

                                  Function LoadProfile has 5 return statements (exceeds 4 allowed).
                                  Open

                                  func LoadProfile(args []string) error {
                                      if len(args) != 1 {
                                          return fmt.Errorf("must specifiy a profile name")
                                      }
                                      profile := profileFile(args[0])
                                  Severity: Major
                                  Found in pkg/kt/command/config/load.go - About 35 mins to fix

                                    Function Recover has a Cognitive Complexity of 22 (exceeds 20 allowed). Consider refactoring.
                                    Open

                                    func Recover(serviceName string) error {
                                        svc, err := cluster.Ins().GetService(serviceName, opt.Get().Global.Namespace)
                                        if err != nil {
                                            log.Error().Err(err).Msgf("Failed to fetch service '%s'", serviceName)
                                        }
                                    Severity: Minor
                                    Found in pkg/kt/command/recover.go - About 35 mins to fix

                                    Cognitive Complexity

                                    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                                    A method's cognitive complexity is based on a few simple rules:

                                    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                                    • Code is considered more complex for each "break in the linear flow of the code"
                                    • Code is considered more complex when "flow breaking structures are nested"

                                    Further reading

                                    Function LockService has 5 return statements (exceeds 4 allowed).
                                    Open

                                    func LockService(serviceName, namespace string, times int) (*coreV1.Service, error) {
                                        if times > 10 {
                                            return nil, fmt.Errorf("failed to obtain kt lock of service %s, please try again later", serviceName)
                                        }
                                        svc, err := cluster.Ins().GetService(serviceName, namespace)
                                    Severity: Major
                                    Found in pkg/kt/command/general/lock.go - About 35 mins to fix

                                      Function Unset has 5 return statements (exceeds 4 allowed).
                                      Open

                                      func Unset(args []string) error {
                                          if unsetAll {
                                              return saveConfig(make(map[string]map[string]string))
                                          }
                                          if len(args) < 1 {
                                      Severity: Major
                                      Found in pkg/kt/command/config/reset.go - About 35 mins to fix
                                        Severity
                                        Category
                                        Status
                                        Source
                                        Language