Showing 79 of 109 total issues
Avoid deeply nested control flow statements. Open
Open
} else if util.IsMacos() {
dnsPort = opt.Get().Connect.DnsPort
}
Function createRouter
has 7 return statements (exceeds 4 allowed). Open
Open
func createRouter(routerPodName string, svcName string, ports map[int]int, labels map[string]string, versionMark string) error {
namespace := opt.Get().Global.Namespace
routerPod, err := cluster.Ins().GetPod(routerPodName, namespace)
if err == nil && routerPod.DeletionTimestamp != nil {
routerPod, err = cluster.Ins().WaitPodTerminate(routerPodName, namespace)
Avoid deeply nested control flow statements. Open
Open
} else if !strings.HasSuffix(l, midDomain) && !strings.HasSuffix(l, fullDomain) {
recordsToKeep = append(recordsToKeep, l)
}
Avoid deeply nested control flow statements. Open
Open
} else if index == 5 {
iface = parts[i]
} else if index > 5 {
iface = fmt.Sprintf("%s %s", iface, parts[i])
}
Avoid deeply nested control flow statements. Open
Open
if keepShortDomain {
recordsToKeep = append(recordsToKeep, l)
}
Avoid deeply nested control flow statements. Open
Open
if _, err = strconv.Atoi(upstreamParts[1]); err == nil {
dnsAddresses = append(dnsAddresses, fmt.Sprintf("udp:%s:%s", upstreamDns, upstreamParts[1]))
} else {
dnsAddresses = append(dnsAddresses, fmt.Sprintf("%s:%s:%d", upstreamParts[0], upstreamDns, common.StandardDnsPort))
}
Function SaveProfile
has 6 return statements (exceeds 4 allowed). Open
Open
func SaveProfile(args []string) error {
if len(args) != 1 {
return fmt.Errorf("must specifiy a profile name")
}
profile := profileFile(args[0])
Function GetDeploymentByResourceName
has 6 return statements (exceeds 4 allowed). Open
Open
func GetDeploymentByResourceName(resourceName, namespace string) (*appV1.Deployment, error) {
resourceType, name, err := ParseResourceName(resourceName)
if err != nil {
return nil, err
}
Function parsePort
has 6 return statements (exceeds 4 allowed). Open
Open
func parsePort(args []string) (localPort int, remotePort int, err error) {
if len(args) < 2 {
// port not specified
return -1, -1, nil
} else if count := strings.Count(args[1], ":"); count == 0 {
Function Mesh
has 6 return statements (exceeds 4 allowed). Open
Open
func Mesh(resourceName string) error {
ch, err := general.SetupProcess(util.ComponentMesh)
if err != nil {
return err
}
Function NewForwardCommand
has 6 return statements (exceeds 4 allowed). Open
Open
func NewForwardCommand() *cobra.Command {
cmd := &cobra.Command{
Use: "forward",
Short: "Redirect local port to a service or any remote address",
PreRunE: func(cmd *cobra.Command, args []string) error {
Function GetServiceByResourceName
has 6 return statements (exceeds 4 allowed). Open
Open
func GetServiceByResourceName(resourceName, namespace string) (*coreV1.Service, error) {
resourceType, name, err := ParseResourceName(resourceName)
if err != nil {
return nil, err
}
Function Show
has 6 return statements (exceeds 4 allowed). Open
Open
func Show(args []string) error {
if len(args) > 0 {
return fmt.Errorf("parameter '%s' is invalid", args[0])
}
customConfig := loadCustomConfig()
Function createRouter
has 5 arguments (exceeds 4 allowed). Consider refactoring. Open
Open
func createRouter(routerPodName string, svcName string, ports map[int]int, labels map[string]string, versionMark string) error {
Function isNameUsable
has 5 return statements (exceeds 4 allowed). Open
Open
func isNameUsable(name, meshVersion string, times int) error {
if times > 10 {
return fmt.Errorf("meshing pod for service %s still terminating, please try again later", name)
}
shadowName := name + util.MeshPodInfix + meshVersion
Function createStuntmanService
has 5 return statements (exceeds 4 allowed). Open
Open
func createStuntmanService(svc *coreV1.Service, ports map[int]int) error {
stuntmanSvcName := svc.Name + util.StuntmanServiceSuffix
namespace := opt.Get().Global.Namespace
if stuntmanSvc, err := cluster.Ins().GetService(stuntmanSvcName, namespace); err != nil {
if !k8sErrors.IsNotFound(err) {
Function LoadProfile
has 5 return statements (exceeds 4 allowed). Open
Open
func LoadProfile(args []string) error {
if len(args) != 1 {
return fmt.Errorf("must specifiy a profile name")
}
profile := profileFile(args[0])
Function Recover
has a Cognitive Complexity of 22 (exceeds 20 allowed). Consider refactoring. Open
Open
func Recover(serviceName string) error {
svc, err := cluster.Ins().GetService(serviceName, opt.Get().Global.Namespace)
if err != nil {
log.Error().Err(err).Msgf("Failed to fetch service '%s'", serviceName)
}
- Read upRead up
Cognitive Complexity
Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.
A method's cognitive complexity is based on a few simple rules:
- Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
- Code is considered more complex for each "break in the linear flow of the code"
- Code is considered more complex when "flow breaking structures are nested"
Further reading
Function LockService
has 5 return statements (exceeds 4 allowed). Open
Open
func LockService(serviceName, namespace string, times int) (*coreV1.Service, error) {
if times > 10 {
return nil, fmt.Errorf("failed to obtain kt lock of service %s, please try again later", serviceName)
}
svc, err := cluster.Ins().GetService(serviceName, namespace)
Function Unset
has 5 return statements (exceeds 4 allowed). Open
Open
func Unset(args []string) error {
if unsetAll {
return saveConfig(make(map[string]map[string]string))
}
if len(args) < 1 {