alibaba/transmittable-thread-local

View on GitHub

Showing 86 of 208 total issues

Method getStringOptionValue has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
Open

    @NonNull
    static String getStringOptionValue(
            @Nullable final Map<String, String> kvs, @NonNull String key,
            @NonNull String defaultValue
    ) {
Severity: Minor
Found in ttl-agent/src/main/java/com/alibaba/ttl3/agent/TtlAgentHelper.java - About 35 mins to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method splitCommaColonStringToKV has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
Open

    @NonNull
    static Map<String, String> splitCommaColonStringToKV(@Nullable final String commaColonString) {
        final Map<String, String> ret = new HashMap<>();
        if (commaColonString == null || commaColonString.trim().length() == 0) return ret;

Severity: Minor
Found in ttl-agent/src/main/java/com/alibaba/ttl3/agent/TtlAgentHelper.java - About 35 mins to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method restore has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
Open

        public static void restore(@NonNull Object backup) {
            for (Map.Entry<Transmittee<Object, Object>, Object> entry : ((Snapshot) backup).transmittee2Value.entrySet()) {
                Transmittee<Object, Object> transmittee = entry.getKey();
                try {
                    Object transmitteeBackup = entry.getValue();

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method afterReplay has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
Open

    Object afterReplay(Object data) {
        @SuppressWarnings("unchecked")
        Set<CrrTransmitCallback> callbacks = (Set<CrrTransmitCallback>) data;
        for (CrrTransmitCallback cb : callbacks) {
            try {

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method splitCommaColonStringToKV has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
Open

    @NonNull
    static Map<String, String> splitCommaColonStringToKV(@Nullable final String commaColonString) {
        final Map<String, String> ret = new HashMap<>();
        if (commaColonString == null || commaColonString.trim().length() == 0) return ret;

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method loadExtensionInstances has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
Open

    static <T> Map<ClassLoader, Set<T>> loadExtensionInstances(
            ClassLoader classLoader, LinkedHashSet<String> instanceClassNames, Class<T> superType,
            String foundMsgHead, String failLoadMsgHead
    ) {
        Map<ClassLoader, Set<T>> ret = new HashMap<>();

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method restore has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
Open

    public void restore(@NonNull Backup backup) {
        final Snapshot snapshot = (Snapshot) backup;
        final Object data = callback.beforeRestore(snapshot.data);

        for (Map.Entry<CrrTransmit<Object, Object>, Object> entry : snapshot.crrTransmit2Value.entrySet()) {

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method loadExtensionInstances has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
Open

    static <T> Map<ClassLoader, Set<T>> loadExtensionInstances(
        ClassLoader classLoader, LinkedHashSet<String> instanceClassNames, Class<T> superType,
        String foundMsgHead, String failLoadMsgHead
    ) {
        Map<ClassLoader, Set<T>> ret = new HashMap<>();

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Avoid too many return statements within this method.
Open

        if (!clazz.subclassOf(clazz.getClassPool().get(TIMER_TASK_CLASS_NAME))) return;

    Avoid too many return statements within this method.
    Open

                    return nullSafeHashCode((double[]) obj);
    Severity: Major
    Found in ttl-core/src/main/java/com/alibaba/ttl3/internal/util/ObjectUtils.java - About 30 mins to fix

      Avoid too many return statements within this method.
      Open

              return lineNum + 1;

        Avoid too many return statements within this method.
        Open

                    return Arrays.equals((long[]) o1, (long[]) o2);
        Severity: Major
        Found in ttl-core/src/main/java/com/alibaba/ttl3/internal/util/ObjectUtils.java - About 30 mins to fix

          Avoid too many return statements within this method.
          Open

                          return classInfo.getCtClass().toBytecode();

            Avoid too many return statements within this method.
            Open

                        return Arrays.equals((double[]) o1, (double[]) o2);
            Severity: Major
            Found in ttl-core/src/main/java/com/alibaba/ttl3/internal/util/ObjectUtils.java - About 30 mins to fix

              Avoid too many return statements within this method.
              Open

                          return null;

                Avoid too many return statements within this method.
                Open

                        return false;
                Severity: Major
                Found in ttl-core/src/main/java/com/alibaba/ttl3/internal/util/ObjectUtils.java - About 30 mins to fix

                  Avoid too many return statements within this method.
                  Open

                              return Arrays.equals((float[]) o1, (float[]) o2);
                  Severity: Major
                  Found in ttl-core/src/main/java/com/alibaba/ttl3/internal/util/ObjectUtils.java - About 30 mins to fix

                    Avoid too many return statements within this method.
                    Open

                                    return nullSafeHashCode((int[]) obj);
                    Severity: Major
                    Found in ttl-core/src/main/java/com/alibaba/ttl3/internal/util/ObjectUtils.java - About 30 mins to fix

                      Avoid too many return statements within this method.
                      Open

                              if (!clazz.subclassOf(clazz.getClassPool().get(TIMER_TASK_CLASS_NAME))) return;

                        Avoid too many return statements within this method.
                        Open

                                    return Arrays.equals((int[]) o1, (int[]) o2);
                        Severity: Major
                        Found in ttl-core/src/main/java/com/alibaba/ttl3/internal/util/ObjectUtils.java - About 30 mins to fix
                          Severity
                          Category
                          Status
                          Source
                          Language