Sign upLogin

almende/vis

View on GitHub
Star
lib/network/modules/components/edges/BezierEdgeStatic.js

Summary

Maintainability
D
2 days
Test Coverage

Function _getViaCoordinates has a Cognitive Complexity of 76 (exceeds 5 allowed). Consider refactoring.
Open

  _getViaCoordinates() {
    // Assumption: x/y coordinates in from/to always defined
    let xVia = undefined;
    let yVia = undefined;
    let factor = this.options.smooth.roundness;
Severity: Minor
Found in lib/network/modules/components/edges/BezierEdgeStatic.js - About 1 day to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Function _getViaCoordinates has 101 lines of code (exceeds 25 allowed). Consider refactoring.
Open

  _getViaCoordinates() {
    // Assumption: x/y coordinates in from/to always defined
    let xVia = undefined;
    let yVia = undefined;
    let factor = this.options.smooth.roundness;
Severity: Major
Found in lib/network/modules/components/edges/BezierEdgeStatic.js - About 4 hrs to fix

    Avoid deeply nested control flow statements.
    Open

        else if (type === 'curvedCW') {
      dx = this.to.x - this.from.x;
      dy = this.from.y - this.to.y;
      let radius = Math.sqrt(dx * dx + dy * dy);
      let pi = Math.PI;
    Severity: Major
    Found in lib/network/modules/components/edges/BezierEdgeStatic.js - About 45 mins to fix

      Avoid deeply nested control flow statements.
      Open

            if (this.from.y < this.to.y) stepY = -stepY;
      Severity: Major
      Found in lib/network/modules/components/edges/BezierEdgeStatic.js - About 45 mins to fix

        There are no issues that match your filters.

        Category
        Status