Sign upLogin

almende/vis

View on GitHub
Star
lib/network/modules/components/shared/ComponentUtil.js

Summary

Maintainability
A
2 hrs
Test Coverage

Function pointInRect has 27 lines of code (exceeds 25 allowed). Consider refactoring.
Open

  static pointInRect(rect, point, rotationPoint) {
    if (rect.width <= 0 || rect.height <= 0) {
      return false;  // early out
    }
Severity: Minor
Found in lib/network/modules/components/shared/ComponentUtil.js - About 1 hr to fix

    Function pointInRect has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
    Open

      static pointInRect(rect, point, rotationPoint) {
    if (rect.width <= 0 || rect.height <= 0) {
      return false;  // early out
    }
    Severity: Minor
    Found in lib/network/modules/components/shared/ComponentUtil.js - About 35 mins to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Function choosify has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
    Open

      static choosify(subOption, pile) {
    // allowed values for subOption
    let allowed = [ 'node', 'edge', 'label'];
    let value = true;
    Severity: Minor
    Found in lib/network/modules/components/shared/ComponentUtil.js - About 35 mins to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    TODO found
    Open

       * TODO: examine if 'most' in previous sentence can be replaced with 'all'. In that case, we
    Severity: Minor
    Found in lib/network/modules/components/shared/ComponentUtil.js by fixme

    There are no issues that match your filters.

    Category
    Status