Sign upLogin

alouche/dns-check

View on GitHub
Star

Showing 6 of 6 total issues

Method load_indice has a Cognitive Complexity of 19 (exceeds 5 allowed). Consider refactoring.
Open

    def load_indice indice_file, location_filter=nil
      records = DNSCheck.load indice_file

      unless location_filter.nil?
        location_filter = location_filter.capitalize_all
Severity: Minor
Found in lib/dns-check/core.rb - About 2 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

File util.rb has 260 lines of code (exceeds 250 allowed). Consider refactoring.
Open

require 'zlib'

module DNSCheck

  COUNTRY_CODES = {
Severity: Minor
Found in lib/dns-check/util.rb - About 2 hrs to fix

    Method parse_options has 45 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

        def parse_options
      opts = {}

      parser = OptionParser.new do |o|
        o.separator ''
    Severity: Minor
    Found in lib/dns-check/cli.rb - About 1 hr to fix

      Method update! has 29 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

          def update!
      print "-> downloading... (please wait)"

      http do |conn|
        request = Net::HTTP::Get.new(indice_location.request_uri, {})
      Severity: Minor
      Found in lib/dns-check/update.rb - About 1 hr to fix

        Method update! has a Cognitive Complexity of 10 (exceeds 5 allowed). Consider refactoring.
        Open

            def update!
      print "-> downloading... (please wait)"

      http do |conn|
        request = Net::HTTP::Get.new(indice_location.request_uri, {})
        Severity: Minor
        Found in lib/dns-check/update.rb - About 1 hr to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        Method load_indice has 26 lines of code (exceeds 25 allowed). Consider refactoring.
        Open

            def load_indice indice_file, location_filter=nil
      records = DNSCheck.load indice_file

      unless location_filter.nil?
        location_filter = location_filter.capitalize_all
        Severity: Minor
        Found in lib/dns-check/core.rb - About 1 hr to fix
          Severity
          Category
          Status
          Source
          Language