alxndr/lyrem-ipsum

View on GitHub
lib/assets/javascripts/underscore.js

Summary

Maintainability
F
4 days
Test Coverage

File underscore.js has 1004 lines of code (exceeds 250 allowed). Consider refactoring.
Open

//     Underscore.js 1.7.0
//     http://underscorejs.org
//     (c) 2009-2014 Jeremy Ashkenas, DocumentCloud and Investigative Reporters & Editors
//     Underscore may be freely distributed under the MIT license.

Severity: Major
Found in lib/assets/javascripts/underscore.js - About 2 days to fix

    Function eq has 56 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

      var eq = function(a, b, aStack, bStack) {
        // Identical objects are equal. `0 === -0`, but they aren't identical.
        // See the [Harmony `egal` proposal](http://wiki.ecmascript.org/doku.php?id=harmony:egal).
        if (a === b) return a !== 0 || 1 / a === 1 / b;
        // A strict comparison is necessary because `null == undefined`.
    Severity: Major
    Found in lib/assets/javascripts/underscore.js - About 2 hrs to fix

      Function template has 38 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

        _.template = function(text, settings, oldSettings) {
          if (!settings && oldSettings) settings = oldSettings;
          settings = _.defaults({}, settings, _.templateSettings);
      
          // Combine delimiters into one regular expression via alternation.
      Severity: Minor
      Found in lib/assets/javascripts/underscore.js - About 1 hr to fix

        Function throttle has 27 lines of code (exceeds 25 allowed). Consider refactoring.
        Open

          _.throttle = function(func, wait, options) {
            var context, args, result;
            var timeout = null;
            var previous = 0;
            if (!options) options = {};
        Severity: Minor
        Found in lib/assets/javascripts/underscore.js - About 1 hr to fix

          Consider simplifying this complex logical expression.
          Open

              if (
                aCtor !== bCtor &&
                // Handle Object.create(x) cases
                'constructor' in a && 'constructor' in b &&
                !(_.isFunction(aCtor) && aCtor instanceof aCtor &&
          Severity: Major
          Found in lib/assets/javascripts/underscore.js - About 1 hr to fix

            Avoid too many return statements within this function.
            Open

                if (typeof a != 'object' || typeof b != 'object') return false;
            Severity: Major
            Found in lib/assets/javascripts/underscore.js - About 30 mins to fix

              Avoid too many return statements within this function.
              Open

                    if (aStack[length] === a) return bStack[length] === b;
              Severity: Major
              Found in lib/assets/javascripts/underscore.js - About 30 mins to fix

                Avoid too many return statements within this function.
                Open

                      return false;
                Severity: Major
                Found in lib/assets/javascripts/underscore.js - About 30 mins to fix

                  Avoid too many return statements within this function.
                  Open

                          return +a === 0 ? 1 / +a === 1 / b : +a === +b;
                  Severity: Major
                  Found in lib/assets/javascripts/underscore.js - About 30 mins to fix

                    Avoid too many return statements within this function.
                    Open

                        return result;
                    Severity: Major
                    Found in lib/assets/javascripts/underscore.js - About 30 mins to fix

                      Similar blocks of code found in 2 locations. Consider refactoring.
                      Open

                          if (iteratee == null && obj != null) {
                            obj = obj.length === +obj.length ? obj : _.values(obj);
                            for (var i = 0, length = obj.length; i < length; i++) {
                              value = obj[i];
                              if (value > result) {
                      Severity: Major
                      Found in lib/assets/javascripts/underscore.js and 1 other location - About 3 hrs to fix
                      lib/assets/javascripts/underscore.js on lines 291..308

                      Duplicated Code

                      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                      Tuning

                      This issue has a mass of 100.

                      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                      Refactorings

                      Further Reading

                      Similar blocks of code found in 2 locations. Consider refactoring.
                      Open

                          if (iteratee == null && obj != null) {
                            obj = obj.length === +obj.length ? obj : _.values(obj);
                            for (var i = 0, length = obj.length; i < length; i++) {
                              value = obj[i];
                              if (value < result) {
                      Severity: Major
                      Found in lib/assets/javascripts/underscore.js and 1 other location - About 3 hrs to fix
                      lib/assets/javascripts/underscore.js on lines 266..283

                      Duplicated Code

                      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                      Tuning

                      This issue has a mass of 100.

                      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                      Refactorings

                      Further Reading

                      Similar blocks of code found in 2 locations. Consider refactoring.
                      Open

                          if (arguments.length < 3) {
                            if (!length) throw new TypeError(reduceError);
                            memo = obj[keys ? keys[index++] : index++];
                          }
                      Severity: Minor
                      Found in lib/assets/javascripts/underscore.js and 1 other location - About 55 mins to fix
                      lib/assets/javascripts/underscore.js on lines 157..160

                      Duplicated Code

                      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                      Tuning

                      This issue has a mass of 53.

                      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                      Refactorings

                      Further Reading

                      Similar blocks of code found in 2 locations. Consider refactoring.
                      Open

                          if (arguments.length < 3) {
                            if (!index) throw new TypeError(reduceError);
                            memo = obj[keys ? keys[--index] : --index];
                          }
                      Severity: Minor
                      Found in lib/assets/javascripts/underscore.js and 1 other location - About 55 mins to fix
                      lib/assets/javascripts/underscore.js on lines 139..142

                      Duplicated Code

                      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                      Tuning

                      This issue has a mass of 53.

                      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                      Refactorings

                      Further Reading

                      Similar blocks of code found in 2 locations. Consider refactoring.
                      Open

                          var keys = obj.length !== +obj.length && _.keys(obj),
                              length = (keys || obj).length,
                              index, currentKey;
                      Severity: Minor
                      Found in lib/assets/javascripts/underscore.js and 1 other location - About 50 mins to fix
                      lib/assets/javascripts/underscore.js on lines 203..205

                      Duplicated Code

                      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                      Tuning

                      This issue has a mass of 52.

                      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                      Refactorings

                      Further Reading

                      Similar blocks of code found in 2 locations. Consider refactoring.
                      Open

                          var keys = obj.length !== +obj.length && _.keys(obj),
                              length = (keys || obj).length,
                              index, currentKey;
                      Severity: Minor
                      Found in lib/assets/javascripts/underscore.js and 1 other location - About 50 mins to fix
                      lib/assets/javascripts/underscore.js on lines 218..220

                      Duplicated Code

                      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                      Tuning

                      This issue has a mass of 52.

                      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                      Refactorings

                      Further Reading

                      There are no issues that match your filters.

                      Category
                      Status