Sign upLogin

amalfra/vibe

View on GitHub
Star

Showing 4 of 7 total issues

Method request has a Cognitive Complexity of 28 (exceeds 5 allowed). Consider refactoring.
Open

    def request(method, path, params, cache_override = false)
      if !METHODS.include?(method)
          raise ArgumentError, "unkown http method: #{method}"
      end
Severity: Minor
Found in lib/vibe/request.rb - About 4 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method request has 53 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    def request(method, path, params, cache_override = false)
      if !METHODS.include?(method)
          raise ArgumentError, "unkown http method: #{method}"
      end
Severity: Major
Found in lib/vibe/request.rb - About 2 hrs to fix

    Method get has a Cognitive Complexity of 9 (exceeds 5 allowed). Consider refactoring.
    Open

        def get(key = '')
      if key != '' && ::File.exists?(@cache_dir+key)
        # Is the File older than a day?
        if file_age(@cache_dir+key) > 1
          # Delete and return a cache miss
    Severity: Minor
    Found in lib/vibe/cache-drivers/file.rb - About 55 mins to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Method initialize has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
    Open

        def initialize(options = {}, &block)
      # Merge the config values from the module and those passed
      # to the client.
      merged_options = Vibe.options.merge(options)
    Severity: Minor
    Found in lib/vibe/client.rb - About 35 mins to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Severity
    Category
    Status
    Source
    Language