Sign upLogin

amercier/rectangular-mozaic

View on GitHub
Star

Showing 10 of 10 total issues

Function getData has a Cognitive Complexity of 11 (exceeds 5 allowed). Consider refactoring.
Open

    public function getData(bool $flatten = false, callable $cellToValue = null)
    {
        $copy = array();
        for ($row = 0; $row < $this->rows; $row++) {
            if (!$flatten) {
Severity: Minor
Found in src/Grid.php - About 1 hr to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method fill has 28 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    public static function fill(Grid $grid, Distribution $distribution, int $maxRetries)
    {
        Assert::assertPositiveInteger($maxRetries, 'maxRetries');

        if ($distribution->getCells() !== ($cells = $grid->rows * $grid->columns)) {
Severity: Minor
Found in src/RandomFiller.php - About 1 hr to fix

    Function distribute has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
    Open

        public static function distribute(int $tiles, int $columns, float $tallRateTarget, float $wideRateTarget)
    {
        // 1. Approximate the number of rows where all tiles would fit
        $tallTilesTarget = (int)round($tallRateTarget * $tiles);
        $wideTilesTarget = (int)round($wideRateTarget * $tiles);
    Severity: Minor
    Found in src/Distributor.php - About 35 mins to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Function decrementLargeTiles has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
    Open

        public function decrementLargeTiles()
    {
        if ($this->wide === 0 && $this->tall === 0) {
            throw new Exception('Cannot decrement the number of either wide or tall tiles.');
        }
    Severity: Minor
    Found in src/Distribution.php - About 35 mins to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Function empty has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
    Open

        public function empty()
    {
        if ($this->small > 0 || $this->tall > 0 || $this->wide > 0) {
            for ($i = 0; $i < $this->rows; $i += 1) {
                for ($j = 0; $j < $this->columns; $j += 1) {
    Severity: Minor
    Found in src/Grid.php - About 35 mins to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Function fill has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
    Open

        public static function fill(Grid $grid, Distribution $distribution, int $maxRetries)
    {
        Assert::assertPositiveInteger($maxRetries, 'maxRetries');

        if ($distribution->getCells() !== ($cells = $grid->rows * $grid->columns)) {
    Severity: Minor
    Found in src/RandomFiller.php - About 35 mins to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Avoid too many return statements within this method.
    Open

                    return false;
    Severity: Major
    Found in src/Tile.php - About 30 mins to fix

      Function tryToFill has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
      Open

          public static function tryToFill(Grid $grid, Distribution $distribution)
    {
        $smallTiles = $distribution->small;
        $tallTiles = $distribution->tall;
        $wideTiles = $distribution->wide;
      Severity: Minor
      Found in src/RandomFiller.php - About 25 mins to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Function set has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
      Open

          public static function set(Grid $grid, Tile $tile)
    {
        // Boundaries of the grid within which the tile would fit
        $rows = $grid->rows - $tile->height + 1;
        $columns = $grid->columns - $tile->width + 1;
      Severity: Minor
      Found in src/RandomFiller.php - About 25 mins to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Function isEmptyForTile has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
      Open

          public function isEmptyForTile($row, $column, $tile)
    {
        for ($x = 0; $x < $tile->width; $x += 1) {
            for ($y = 0; $y < $tile->height; $y += 1) {
                if (!$this->isEmpty($row + $y, $column + $x)) {
      Severity: Minor
      Found in src/Grid.php - About 25 mins to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Severity
      Category
      Status
      Source
      Language