Sign upLogin

americanexpress/xcode-result-bundle-processor

View on GitHub
Star

Showing 9 of 27 total issues

Method _format_test has a Cognitive Complexity of 25 (exceeds 5 allowed). Consider refactoring.
Open

      def _format_test(test, mab, destination_dir)
        mab.a name: test.identifier do
          if test.passed?
            mab.h2 test.summary
          else
Severity: Minor
Found in lib/xcoderesultbundleprocessor/test_summaries/html_report.rb - About 3 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method _format_test has 60 lines of code (exceeds 25 allowed). Consider refactoring.
Open

      def _format_test(test, mab, destination_dir)
        mab.a name: test.identifier do
          if test.passed?
            mab.h2 test.summary
          else
Severity: Major
Found in lib/xcoderesultbundleprocessor/test_summaries/html_report.rb - About 2 hrs to fix

Method save has 43 lines of code (exceeds 25 allowed). Consider refactoring.
Open

      def save(destination_dir)
        info "Saving HTML report to #{destination_dir}"

        raise "Destination directory #{destination_dir} already exists" if Dir.exist?(destination_dir)
Severity: Minor
Found in lib/xcoderesultbundleprocessor/test_summaries/html_report.rb - About 1 hr to fix

Method _deserialize_uid has a Cognitive Complexity of 10 (exceeds 5 allowed). Consider refactoring.
Open

    def _deserialize_uid(uid)
      object = @objects[uid.value]

      if object.is_a?(CFPropertyList::CFUid)
        _deserialize_uid(uid)
Severity: Minor
Found in lib/xcoderesultbundleprocessor/element_snapshot.rb - About 1 hr to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method summary has a Cognitive Complexity of 9 (exceeds 5 allowed). Consider refactoring.
Open

    def summary
      summary_components = [
          self.element_class || 'UnknownElement',
          self.frame
      ]
Severity: Minor
Found in lib/xcoderesultbundleprocessor/snapshot_summary.rb - About 55 mins to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method resolve_class_names has a Cognitive Complexity of 9 (exceeds 5 allowed). Consider refactoring.
Open

      def self.resolve_class_names(tokens)
        class_names = []

        Enumerator.new do |enumerator|
          tokens.each do |token|
Severity: Minor
Found in lib/xcoderesultbundleprocessor/slf0/class_name_resolver.rb - About 55 mins to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method _deserialize_object has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
Open

    def _deserialize_object(object)
      if object.is_a?(CFPropertyList::CFUid)
        self._deserialize_object(@objects[object.value])
      elsif object.is_a?(CFPropertyList::CFString) && object.value == '$null'
        nil
Severity: Minor
Found in lib/xcoderesultbundleprocessor/element_snapshot.rb - About 45 mins to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method read_token_stream has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
Open

      def self.read_token_stream(io)
        raise 'Not an SLF0 file' unless self.valid_slf0_io?(io)

        Enumerator.new do |enumerator|
          until io.eof?
Severity: Minor
Found in lib/xcoderesultbundleprocessor/slf0/tokenizer.rb - About 35 mins to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method _deserialize_dictionary has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
Open

    def _deserialize_dictionary(cfdictionary)
      if cfdictionary.value.key?('NS.rectval')
        return self._deserialize_object(cfdictionary.value['NS.rectval'])
      end
Severity: Minor
Found in lib/xcoderesultbundleprocessor/element_snapshot.rb - About 25 mins to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Severity
Category
Status
Source
Language