amilcarlucas/MethodicConfigurator

View on GitHub

Showing 36 of 36 total issues

LocalFilesystem has 29 functions (exceeds 20 allowed). Consider refactoring.
Open

class LocalFilesystem(VehicleComponents, ConfigurationSteps, ProgramSettings):  # pylint: disable=too-many-public-methods
    """
    A class to manage local filesystem operations for the ArduPilot methodic configurator.

    This class provides methods for initializing and re-initializing the filesystem context,
Severity: Minor
Found in MethodicConfigurator/backend_filesystem.py - About 3 hrs to fix

    ParameterEditorTable has 24 functions (exceeds 20 allowed). Consider refactoring.
    Open

    class ParameterEditorTable(ScrollFrame):  # pylint: disable=too-many-ancestors
        """
        A class to manage and display the parameter editor table within the GUI.
    
        This class inherits from ScrollFrame and is responsible for creating,
    Severity: Minor
    Found in MethodicConfigurator/frontend_tkinter_parameter_editor_table.py - About 2 hrs to fix

      Function __init__ has 9 arguments (exceeds 4 allowed). Consider refactoring.
      Open

          def __init__(self, parent, parent_frame, initialdir: str, label_text: str,  # pylint: disable=too-many-arguments
      Severity: Major
      Found in MethodicConfigurator/frontend_tkinter_directory_selection.py - About 1 hr to fix

        Function IMUfit has 9 arguments (exceeds 4 allowed). Consider refactoring.
        Open

        def IMUfit(logfile, outfile,     # pylint: disable=too-many-locals, too-many-branches, too-many-statements, too-many-arguments
        Severity: Major
        Found in MethodicConfigurator/tempcal_imu.py - About 1 hr to fix

          Function __init__ has 9 arguments (exceeds 4 allowed). Consider refactoring.
          Open

              def __init__(self, seq, session, opcode, size,  # pylint: disable=too-many-arguments
          Severity: Major
          Found in MethodicConfigurator/backend_mavftp.py - About 1 hr to fix

            Function update_parameter_documentation_file has 7 arguments (exceeds 4 allowed). Consider refactoring.
            Open

            def update_parameter_documentation_file(doc, sort_type, param_default_dict, param_file, lines,  # pylint: disable=too-many-locals, too-many-arguments
            Severity: Major
            Found in MethodicConfigurator/annotate_params.py - About 50 mins to fix

              Function validate_entry_limits has 7 arguments (exceeds 4 allowed). Consider refactoring.
              Open

                  def validate_entry_limits(self, event, entry, data_type, limits, name, path):  # pylint: disable=too-many-arguments
              Severity: Major
              Found in MethodicConfigurator/frontend_tkinter_component_editor.py - About 50 mins to fix

                Function validate_parameter has 6 arguments (exceeds 4 allowed). Consider refactoring.
                Open

                    def validate_parameter(param_file, parameter_dict, i, original_line, comment, parameter, value):  # pylint: disable=too-many-arguments
                Severity: Minor
                Found in MethodicConfigurator/annotate_params.py - About 45 mins to fix

                  Function __init__ has 6 arguments (exceeds 4 allowed). Consider refactoring.
                  Open

                      def __init__(self, parent, parent_frame, flight_controller: FlightController,  # pylint: disable=too-many-arguments
                  Severity: Minor
                  Found in MethodicConfigurator/frontend_tkinter_connection_selection.py - About 45 mins to fix

                    Function generate_tempcal_accel_figures has 6 arguments (exceeds 4 allowed). Consider refactoring.
                    Open

                    def generate_tempcal_accel_figures(log_parm, figpath, data, c, clog, num_imus):  # pylint: disable=too-many-arguments
                    Severity: Minor
                    Found in MethodicConfigurator/tempcal_imu.py - About 45 mins to fix

                      Avoid deeply nested control flow statements.
                      Open

                                              if self.intermediate_parameter_file_exists(old_filename) and old_filename != new_filename:
                                                  new_filename_path = os_path.join(self.vehicle_dir, new_filename)
                                                  old_filename_path = os_path.join(self.vehicle_dir, old_filename)
                                                  os_rename(old_filename_path, new_filename_path)
                                                  logging_info("Renamed %s to %s", old_filename, new_filename)
                      Severity: Major
                      Found in MethodicConfigurator/backend_filesystem.py - About 45 mins to fix

                        Avoid deeply nested control flow statements.
                        Open

                                            if imu in clog.atcal:
                                                ofs = data.accel_at_temp(imu, axis, clog.atcal[imu])
                                            else:
                                                ofs = np.mean(data.accel[imu][axis])
                                            c.set_accel_poly(imu, axis, np.polyfit(trel, data.accel[imu][axis] - ofs, POLY_ORDER))
                        Severity: Major
                        Found in MethodicConfigurator/tempcal_imu.py - About 45 mins to fix

                          Function __init__ has 6 arguments (exceeds 4 allowed). Consider refactoring.
                          Open

                              def __init__(self, parent: ttk, parent_frame: ttk.Frame,  # pylint: disable=too-many-arguments
                          Severity: Minor
                          Found in MethodicConfigurator/frontend_tkinter_directory_selection.py - About 45 mins to fix

                            Function __init__ has 6 arguments (exceeds 4 allowed). Consider refactoring.
                            Open

                                def __init__(self, container, list_pair_tuple, selected_element, cb_name, *args, **kwargs):
                            Severity: Minor
                            Found in MethodicConfigurator/frontend_tkinter_connection_selection.py - About 45 mins to fix

                              Function __init__ has 6 arguments (exceeds 4 allowed). Consider refactoring.
                              Open

                                  def __init__(self, container, values, selected_element, tooltip, *args, **kwargs):
                              Severity: Minor
                              Found in MethodicConfigurator/frontend_tkinter_base.py - About 45 mins to fix

                                Avoid deeply nested control flow statements.
                                Open

                                                            if bitmasks:
                                                                result = 2**next(key for key, bitmask in bitmasks.items() if bitmask == result)
                                
                                
                                Severity: Major
                                Found in MethodicConfigurator/backend_filesystem_configuration_steps.py - About 45 mins to fix

                                  Function __create_new_value_entry has 6 arguments (exceeds 4 allowed). Consider refactoring.
                                  Open

                                      def __create_new_value_entry(self, param_name, param,  # pylint: disable=too-many-arguments
                                  Severity: Minor
                                  Found in MethodicConfigurator/frontend_tkinter_parameter_editor_table.py - About 45 mins to fix

                                    Function generate_tempcal_gyro_figures has 6 arguments (exceeds 4 allowed). Consider refactoring.
                                    Open

                                    def generate_tempcal_gyro_figures(log_parm, figpath, data, c, clog, num_imus):  # pylint: disable=too-many-arguments
                                    Severity: Minor
                                    Found in MethodicConfigurator/tempcal_imu.py - About 45 mins to fix

                                      Function correction has 5 arguments (exceeds 4 allowed). Consider refactoring.
                                      Open

                                          def correction(self, coeff, imu, temperature, axis, cal_temp):  # pylint: disable=too-many-arguments
                                      Severity: Minor
                                      Found in MethodicConfigurator/tempcal_imu.py - About 35 mins to fix

                                        Function update_parameter_documentation has 5 arguments (exceeds 4 allowed). Consider refactoring.
                                        Open

                                        def update_parameter_documentation(doc: Dict[str, Any], target: str = '.',
                                        Severity: Minor
                                        Found in MethodicConfigurator/annotate_params.py - About 35 mins to fix
                                          Severity
                                          Category
                                          Status
                                          Source
                                          Language