ampache/ampache

View on GitHub

Showing 1,927 of 25,595 total issues

Function 11 has a Cognitive Complexity of 991 (exceeds 5 allowed). Consider refactoring.
Open

},{"./frame":4,"./header":5,"./tables":14,"./utils":15}],11:[function(require,module,exports){
(function (global){
var AV = (typeof window !== "undefined" ? window['AV'] : typeof global !== "undefined" ? global['AV'] : null);
var tables = require('./tables');
var MP3FrameHeader = require('./header');
Severity: Minor
Found in public/lib/modules/aurora.js/mp3.js - About 2 wks to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

File aac.js has 3970 lines of code (exceeds 500 allowed). Consider refactoring.
Open

(function e(t,n,r){function s(o,u){if(!n[o]){if(!t[o]){var a=typeof require=="function"&&require;if(!u&&a)return a(o,!0);if(i)return i(o,!0);throw new Error("Cannot find module '"+o+"'")}var f=n[o]={exports:{}};t[o][0].call(f.exports,function(e){var n=t[o][1][e];return s(n?n:e)},f,f.exports,e,t,n,r)}return n[o].exports}var i=typeof require=="function"&&require;for(var o=0;o<r.length;o++)s(r[o]);return s})({1:[function(require,module,exports){
(function (global){
var AV = (typeof window !== "undefined" ? window['AV'] : typeof global !== "undefined" ? global['AV'] : null);
var tables = require('./tables');

Severity: Major
Found in public/lib/modules/aurora.js/aac.js - About 1 wk to fix

    File mp3.js has 3607 lines of code (exceeds 500 allowed). Consider refactoring.
    Open

    (function e(t,n,r){function s(o,u){if(!n[o]){if(!t[o]){var a=typeof require=="function"&&require;if(!u&&a)return a(o,!0);if(i)return i(o,!0);throw new Error("Cannot find module '"+o+"'")}var f=n[o]={exports:{}};t[o][0].call(f.exports,function(e){var n=t[o][1][e];return s(n?n:e)},f,f.exports,e,t,n,r)}return n[o].exports}var i=typeof require=="function"&&require;for(var o=0;o<r.length;o++)s(r[o]);return s})({1:[function(require,module,exports){
    exports.MP3Demuxer = require('./src/demuxer');
    exports.MP3Decoder = require('./src/decoder');
    
    },{"./src/decoder":2,"./src/demuxer":3}],2:[function(require,module,exports){
    Severity: Major
    Found in public/lib/modules/aurora.js/mp3.js - About 1 wk to fix

      File aurora.js has 3404 lines of code (exceeds 500 allowed). Consider refactoring.
      Open

      (function(f){if(typeof exports==="object"&&typeof module!=="undefined"){module.exports=f()}else if(typeof define==="function"&&define.amd){define([],f)}else{var g;if(typeof window!=="undefined"){g=window}else if(typeof global!=="undefined"){g=global}else if(typeof self!=="undefined"){g=self}else{g=this}g.AV = f()}})(function(){var define,module,exports;return (function(){function r(e,n,t){function o(i,f){if(!n[i]){if(!e[i]){var c="function"==typeof require&&require;if(!f&&c)return c(i,!0);if(u)return u(i,!0);var a=new Error("Cannot find module '"+i+"'");throw a.code="MODULE_NOT_FOUND",a}var p=n[i]={exports:{}};e[i][0].call(p.exports,function(r){var n=e[i][1][r];return o(n||r)},p,p.exports,r,e,n,t)}return n[i].exports}for(var u="function"==typeof require&&require,i=0;i<t.length;i++)o(t[i]);return o}return r})()({1:[function(require,module,exports){
      // Generated by CoffeeScript 1.12.7
      (function() {
        var Asset, BufferSource, Decoder, Demuxer, EventEmitter, FileSource, HTTPSource,
          bind = function(fn, me){ return function(){ return fn.apply(me, arguments); }; },
      Severity: Major
      Found in public/lib/modules/aurora.js/aurora.js - About 1 wk to fix

        File jquery.jplayer.js has 3043 lines of code (exceeds 500 allowed). Consider refactoring.
        Open

        /**
         * FORKED BY AMPACHE 2022-02-01
         * USING LAST UPDATED GIT VERSION (https://github.com/jplayer/jPlayer)
         * https://github.com/jplayer/jPlayer/blob/master/dist/jplayer/jquery.jplayer.js
         */
        Severity: Major
        Found in public/lib/modules/jplayer/jquery.jplayer.js - About 1 wk to fix

          File Catalog.php has 2953 lines of code (exceeds 500 allowed). Consider refactoring.
          Open

          <?php
          
          declare(strict_types=0);
          
          /**
          Severity: Major
          Found in src/Repository/Model/Catalog.php - About 1 wk to fix

            Function 4 has a Cognitive Complexity of 331 (exceeds 5 allowed). Consider refactoring.
            Open

            },{"./ics":8}],4:[function(require,module,exports){
            (function (global){
            /*
             * AAC.js - Advanced Audio Coding decoder in JavaScript
             * Created by Devon Govett
            Severity: Minor
            Found in public/lib/modules/aurora.js/aac.js - About 6 days to fix

            Cognitive Complexity

            Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

            A method's cognitive complexity is based on a few simple rules:

            • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
            • Code is considered more complex for each "break in the linear flow of the code"
            • Code is considered more complex when "flow breaking structures are nested"

            Further reading

            Function 7 has 1444 lines of code (exceeds 200 allowed). Consider refactoring.
            Open

            },{"./ics":8,"./mdct":9}],7:[function(require,module,exports){
            /*
             * AAC.js - Advanced Audio Coding decoder in JavaScript
             * Created by Devon Govett
             * Copyright (c) 2012, Official.fm Labs
            Severity: Major
            Found in public/lib/modules/aurora.js/aac.js - About 6 days to fix

              Function run has a Cognitive Complexity of 298 (exceeds 5 allowed). Consider refactoring.
              Open

                  public function run(ServerRequestInterface $request, GuiGatekeeperInterface $gatekeeper): ?ResponseInterface
                  {
                      //$this->logger->debug(print_r(apache_request_headers(), true), [LegacyLogger::CONTEXT_TYPE => __CLASS__]);
                      ob_end_clean();
              
              
              Severity: Minor
              Found in src/Module/Application/Playback/PlayAction.php - About 6 days to fix

              Cognitive Complexity

              Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

              A method's cognitive complexity is based on a few simple rules:

              • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
              • Code is considered more complex for each "break in the linear flow of the code"
              • Code is considered more complex when "flow breaking structures are nested"

              Further reading

              Function run has a Cognitive Complexity of 295 (exceeds 5 allowed). Consider refactoring.
              Open

                  public function run(ServerRequestInterface $request, GuiGatekeeperInterface $gatekeeper): ?ResponseInterface
                  {
                      //$this->logger->debug(print_r(apache_request_headers(), true), [LegacyLogger::CONTEXT_TYPE => __CLASS__]);
                      ob_end_clean();
              
              
              Severity: Minor
              Found in src/Module/Application/Playback/Play2Action.php - About 6 days to fix

              Cognitive Complexity

              Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

              A method's cognitive complexity is based on a few simple rules:

              • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
              • Code is considered more complex for each "break in the linear flow of the code"
              • Code is considered more complex when "flow breaking structures are nested"

              Further reading

              Function 2 has a Cognitive Complexity of 284 (exceeds 5 allowed). Consider refactoring.
              Open

              },{"./src/decoder":2,"./src/demuxer":3,"./src/ogg":4}],2:[function(require,module,exports){
              /*
               * FLAC.js - Free Lossless Audio Codec decoder in JavaScript
               * Original C version from FFmpeg (c) 2003 Alex Beregszaszi
               * JavaScript port by Devon Govett and Jens Nockert of Official.fm Labs
              Severity: Minor
              Found in public/lib/modules/aurora.js/flac.js - About 5 days to fix

              Cognitive Complexity

              Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

              A method's cognitive complexity is based on a few simple rules:

              • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
              • Code is considered more complex for each "break in the linear flow of the code"
              • Code is considered more complex when "flow breaking structures are nested"

              Further reading

              File Query.php has 2279 lines of code (exceeds 500 allowed). Consider refactoring.
              Open

              <?php
              
              declare(strict_types=0);
              
              /**
              Severity: Major
              Found in src/Repository/Model/Query.php - About 5 days to fix

                File Subsonic_Api.php has 2266 lines of code (exceeds 500 allowed). Consider refactoring.
                Open

                <?php
                
                declare(strict_types=0);
                
                /**
                Severity: Major
                Found in src/Module/Api/Subsonic_Api.php - About 5 days to fix

                  Function getSql has a Cognitive Complexity of 248 (exceeds 5 allowed). Consider refactoring.
                  Open

                      public function getSql(
                          Search $search
                      ): array {
                          $search_user_id     = $search->search_user->id ?? -1;
                          $sql_logic_operator = $search->logic_operator;
                  Severity: Minor
                  Found in src/Module/Playlist/Search/SongSearch.php - About 5 days to fix

                  Cognitive Complexity

                  Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                  A method's cognitive complexity is based on a few simple rules:

                  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                  • Code is considered more complex for each "break in the linear flow of the code"
                  • Code is considered more complex when "flow breaking structures are nested"

                  Further reading

                  Function sql_filter has a Cognitive Complexity of 234 (exceeds 5 allowed). Consider refactoring.
                  Open

                      private function sql_filter($filter, $value): string
                      {
                          $filter_sql = '';
                          switch ($this->get_type()) {
                              case 'song':
                  Severity: Minor
                  Found in src/Repository/Model/Query.php - About 4 days to fix

                  Cognitive Complexity

                  Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                  A method's cognitive complexity is based on a few simple rules:

                  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                  • Code is considered more complex for each "break in the linear flow of the code"
                  • Code is considered more complex when "flow breaking structures are nested"

                  Further reading

                  Function 10 has 1124 lines of code (exceeds 200 allowed). Consider refactoring.
                  Open

                  },{"./fft":5,"./mdct_tables":10}],10:[function(require,module,exports){
                  /*
                   * AAC.js - Advanced Audio Coding decoder in JavaScript
                   * Created by Devon Govett
                   * Copyright (c) 2012, Official.fm Labs
                  Severity: Major
                  Found in public/lib/modules/aurora.js/aac.js - About 4 days to fix

                    Function getSql has a Cognitive Complexity of 182 (exceeds 5 allowed). Consider refactoring.
                    Open

                        public function getSql(
                            Search $search
                        ): array {
                            $search_user_id     = $search->search_user->id ?? -1;
                            $sql_logic_operator = $search->logic_operator;
                    Severity: Minor
                    Found in src/Module/Playlist/Search/AlbumSearch.php - About 3 days to fix

                    Cognitive Complexity

                    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                    A method's cognitive complexity is based on a few simple rules:

                    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                    • Code is considered more complex for each "break in the linear flow of the code"
                    • Code is considered more complex when "flow breaking structures are nested"

                    Further reading

                    Function getSql has a Cognitive Complexity of 181 (exceeds 5 allowed). Consider refactoring.
                    Open

                        public function getSql(
                            Search $search
                        ): array {
                            $search_user_id     = $search->search_user->id ?? -1;
                            $sql_logic_operator = $search->logic_operator;
                    Severity: Minor
                    Found in src/Module/Playlist/Search/ArtistSearch.php - About 3 days to fix

                    Cognitive Complexity

                    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                    A method's cognitive complexity is based on a few simple rules:

                    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                    • Code is considered more complex for each "break in the linear flow of the code"
                    • Code is considered more complex when "flow breaking structures are nested"

                    Further reading

                    Function 11 has 909 lines of code (exceeds 200 allowed). Consider refactoring.
                    Open

                    },{"./frame":4,"./header":5,"./tables":14,"./utils":15}],11:[function(require,module,exports){
                    (function (global){
                    var AV = (typeof window !== "undefined" ? window['AV'] : typeof global !== "undefined" ? global['AV'] : null);
                    var tables = require('./tables');
                    var MP3FrameHeader = require('./header');
                    Severity: Major
                    Found in public/lib/modules/aurora.js/mp3.js - About 3 days to fix

                      File VaInfo.php has 1623 lines of code (exceeds 500 allowed). Consider refactoring.
                      Open

                      <?php
                      
                      declare(strict_types=0);
                      
                      /**
                      Severity: Major
                      Found in src/Module/Util/VaInfo.php - About 3 days to fix
                        Severity
                        Category
                        Status
                        Source
                        Language