ampache/ampache

View on GitHub

Showing 1,929 of 25,614 total issues

Function 8 has a Cognitive Complexity of 176 (exceeds 5 allowed). Consider refactoring.
Open

},{}],8:[function(require,module,exports){
/*
 * AAC.js - Advanced Audio Coding decoder in JavaScript
 * Created by Devon Govett
 * Copyright (c) 2012, Official.fm Labs
Severity: Minor
Found in public/lib/modules/aurora.js/aac.js - About 3 days to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Function getSql has a Cognitive Complexity of 175 (exceeds 5 allowed). Consider refactoring.
Open

    public function getSql(
        Search $search
    ): array {
        $search_user_id     = $search->search_user->id ?? -1;
        $sql_logic_operator = $search->logic_operator;
Severity: Minor
Found in src/Module/Playlist/Search/AlbumDiskSearch.php - About 3 days to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Function 13 has 860 lines of code (exceeds 200 allowed). Consider refactoring.
Open

},{"./header":5}],13:[function(require,module,exports){
var utils = require('./utils');

function MP3Synth() {
    this.filter = utils.makeArray([2, 2, 2, 16, 8]); // polyphase filterbank outputs
Severity: Major
Found in public/lib/modules/aurora.js/mp3.js - About 3 days to fix

    Method run has 853 lines of code (exceeds 200 allowed). Consider refactoring.
    Open

        public function run(ServerRequestInterface $request, GuiGatekeeperInterface $gatekeeper): ?ResponseInterface
        {
            //$this->logger->debug(print_r(apache_request_headers(), true), [LegacyLogger::CONTEXT_TYPE => __CLASS__]);
            ob_end_clean();
    
    
    Severity: Major
    Found in src/Module/Application/Playback/PlayAction.php - About 3 days to fix

      Function 5 has a Cognitive Complexity of 166 (exceeds 5 allowed). Consider refactoring.
      Open

      },{"./header":5,"./utils":15}],5:[function(require,module,exports){
      (function (global){
      var AV = (typeof window !== "undefined" ? window['AV'] : typeof global !== "undefined" ? global['AV'] : null);
      
      function MP3FrameHeader() {
      Severity: Minor
      Found in public/lib/modules/aurora.js/mp3.js - About 3 days to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      File Song.php has 1543 lines of code (exceeds 500 allowed). Consider refactoring.
      Open

      <?php
      
      declare(strict_types=0);
      
      /**
      Severity: Major
      Found in src/Repository/Model/Song.php - About 3 days to fix

        Method run has 848 lines of code (exceeds 200 allowed). Consider refactoring.
        Open

            public function run(ServerRequestInterface $request, GuiGatekeeperInterface $gatekeeper): ?ResponseInterface
            {
                //$this->logger->debug(print_r(apache_request_headers(), true), [LegacyLogger::CONTEXT_TYPE => __CLASS__]);
                ob_end_clean();
        
        
        Severity: Major
        Found in src/Module/Application/Playback/Play2Action.php - About 3 days to fix

          File Upnp_Api.php has 1534 lines of code (exceeds 500 allowed). Consider refactoring.
          Open

          <?php
          
          declare(strict_types=0);
          
          /**
          Severity: Major
          Found in src/Module/Api/Upnp_Api.php - About 3 days to fix

            Function update_song_from_tags has a Cognitive Complexity of 152 (exceeds 5 allowed). Consider refactoring.
            Open

                public static function update_song_from_tags($results, Song $song): array
                {
                    //debug_event(__CLASS__, "update_song_from_tags results: " . print_r($results, true), 4);
                    // info for the song table. This is all the primary file data that is song related
                    $new_song       = new Song();
            Severity: Minor
            Found in src/Repository/Model/Catalog.php - About 3 days to fix

            Cognitive Complexity

            Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

            A method's cognitive complexity is based on a few simple rules:

            • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
            • Code is considered more complex for each "break in the linear flow of the code"
            • Code is considered more complex when "flow breaking structures are nested"

            Further reading

            Function match has a Cognitive Complexity of 151 (exceeds 5 allowed). Consider refactoring.
            Open

                public function match($userAgent = null, $accept = null): void
                {
                    // Set our agent string.
                    if ($userAgent == null) {
                        if (isset($_SERVER['HTTP_USER_AGENT'])) {
            Severity: Minor
            Found in src/Module/Util/Horde_Browser.php - About 3 days to fix

            Cognitive Complexity

            Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

            A method's cognitive complexity is based on a few simple rules:

            • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
            • Code is considered more complex for each "break in the linear flow of the code"
            • Code is considered more complex when "flow breaking structures are nested"

            Further reading

            Function 10 has a Cognitive Complexity of 148 (exceeds 5 allowed). Consider refactoring.
            Open

            },{"./frame":4,"./header":5,"./tables":14,"./utils":15}],10:[function(require,module,exports){
            var tables = require('./tables');
            var MP3FrameHeader = require('./header');
            var MP3Frame = require('./frame');
            var utils = require('./utils');
            Severity: Minor
            Found in public/lib/modules/aurora.js/mp3.js - About 3 days to fix

            Cognitive Complexity

            Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

            A method's cognitive complexity is based on a few simple rules:

            • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
            • Code is considered more complex for each "break in the linear flow of the code"
            • Code is considered more complex when "flow breaking structures are nested"

            Further reading

            File Search.php has 1414 lines of code (exceeds 500 allowed). Consider refactoring.
            Open

            <?php
            
            declare(strict_types=0);
            
            /**
            Severity: Major
            Found in src/Repository/Model/Search.php - About 2 days to fix

              Catalog has 151 functions (exceeds 20 allowed). Consider refactoring.
              Open

              abstract class Catalog extends database_object
              {
                  protected const DB_TABLENAME = 'catalog';
              
                  /**
              Severity: Major
              Found in src/Repository/Model/Catalog.php - About 2 days to fix

                File Json_Data.php has 1371 lines of code (exceeds 500 allowed). Consider refactoring.
                Open

                <?php
                
                declare(strict_types=0);
                
                /**
                Severity: Major
                Found in src/Module/Api/Json_Data.php - About 2 days to fix

                  Function 3 has a Cognitive Complexity of 139 (exceeds 5 allowed). Consider refactoring.
                  Open

                  },{"./frame":4,"./header":5,"./layer1":9,"./layer2":10,"./layer3":11,"./stream":12,"./synth":13}],3:[function(require,module,exports){
                  (function (global){
                  var AV = (typeof window !== "undefined" ? window['AV'] : typeof global !== "undefined" ? global['AV'] : null);
                  var ID3v23Stream = require('./id3').ID3v23Stream;
                  var ID3v22Stream = require('./id3').ID3v22Stream;
                  Severity: Minor
                  Found in public/lib/modules/aurora.js/mp3.js - About 2 days to fix

                  Cognitive Complexity

                  Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                  A method's cognitive complexity is based on a few simple rules:

                  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                  • Code is considered more complex for each "break in the linear flow of the code"
                  • Code is considered more complex when "flow breaking structures are nested"

                  Further reading

                  Function process_action has a Cognitive Complexity of 132 (exceeds 5 allowed). Consider refactoring.
                  Open

                      public static function process_action($action, $catalogs, $options = null): void
                      {
                          if (empty($options)) {
                              $options = array(
                                  'gather_art' => false,
                  Severity: Minor
                  Found in src/Repository/Model/Catalog.php - About 2 days to fix

                  Cognitive Complexity

                  Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                  A method's cognitive complexity is based on a few simple rules:

                  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                  • Code is considered more complex for each "break in the linear flow of the code"
                  • Code is considered more complex when "flow breaking structures are nested"

                  Further reading

                  Function write has a Cognitive Complexity of 125 (exceeds 5 allowed). Consider refactoring.
                  Open

                      public function write(
                          Song $song
                      ): void {
                          if ($this->configContainer->isFeatureEnabled(ConfigurationKeyEnum::WRITE_TAGS) === false) {
                              return;
                  Severity: Minor
                  Found in src/Module/Song/Tag/SongTagWriter.php - About 2 days to fix

                  Cognitive Complexity

                  Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                  A method's cognitive complexity is based on a few simple rules:

                  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                  • Code is considered more complex for each "break in the linear flow of the code"
                  • Code is considered more complex when "flow breaking structures are nested"

                  Further reading

                  Method sql_filter has 662 lines of code (exceeds 200 allowed). Consider refactoring.
                  Open

                      private function sql_filter($filter, $value): string
                      {
                          $filter_sql = '';
                          switch ($this->get_type()) {
                              case 'song':
                  Severity: Major
                  Found in src/Repository/Model/Query.php - About 2 days to fix

                    Function sql_sort has a Cognitive Complexity of 120 (exceeds 5 allowed). Consider refactoring.
                    Open

                        private function sql_sort($field, $order): string
                        {
                            if ($order != 'DESC') {
                                $order = 'ASC';
                            }
                    Severity: Minor
                    Found in src/Repository/Model/Query.php - About 2 days to fix

                    Cognitive Complexity

                    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                    A method's cognitive complexity is based on a few simple rules:

                    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                    • Code is considered more complex for each "break in the linear flow of the code"
                    • Code is considered more complex when "flow breaking structures are nested"

                    Further reading

                    Function prettyPhoto has 649 lines of code (exceeds 200 allowed). Consider refactoring.
                    Open

                        $.fn.prettyPhoto = function(pp_settings) {
                            pp_settings = $.extend({
                                hook: 'rel', /* the attribute tag to use for prettyPhoto hooks. default: 'rel'. For HTML5, use "data-rel" or similar. */
                                animation_speed: 'fast', /* fast/slow/normal */
                                ajaxcallback: function() {},
                    Severity: Major
                    Found in public/lib/modules/prettyphoto/js/jquery.prettyPhoto.js - About 2 days to fix
                      Severity
                      Category
                      Status
                      Source
                      Language