Sign upLogin

ampache/ampache

View on GitHub
Star
public/lib/javascript/tools.js

Summary

Maintainability
F
3 days
Test Coverage

Function showEditDialog has 6 arguments (exceeds 4 allowed). Consider refactoring.
Open

function showEditDialog(edit_type, edit_id, edit_form_id, edit_title, refresh_row_prefix, argument_string) {
Severity: Minor
Found in public/lib/javascript/tools.js - About 45 mins to fix

    Function submitNewItemsOrder has 5 arguments (exceeds 4 allowed). Consider refactoring.
    Open

    function submitNewItemsOrder(itemId, tableid, rowPrefix, updateUrl, refreshAction) {
    Severity: Minor
    Found in public/lib/javascript/tools.js - About 35 mins to fix

      Similar blocks of code found in 3 locations. Consider refactoring.
      Open

          $(parent.editDialogId).dialog({
        modal: false,
        dialogClass: "playlistdialogstyle",
        resizable: false,
        draggable: false,
      Severity: Major
      Found in public/lib/javascript/tools.js and 2 other locations - About 1 day to fix
      public/lib/javascript/tools.js on lines 121..148
      public/lib/javascript/tools.js on lines 177..204

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 209.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Similar blocks of code found in 3 locations. Consider refactoring.
      Open

          $(parent.editDialogId).dialog({
        modal: false,
        dialogClass: "sharedialogstyle",
        resizable: false,
        draggable: false,
      Severity: Major
      Found in public/lib/javascript/tools.js and 2 other locations - About 1 day to fix
      public/lib/javascript/tools.js on lines 55..82
      public/lib/javascript/tools.js on lines 121..148

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 209.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Similar blocks of code found in 3 locations. Consider refactoring.
      Open

          $(parent.editDialogId).dialog({
        modal: false,
        dialogClass: "broadcastsdialogstyle",
        resizable: false,
        draggable: false,
      Severity: Major
      Found in public/lib/javascript/tools.js and 2 other locations - About 1 day to fix
      public/lib/javascript/tools.js on lines 55..82
      public/lib/javascript/tools.js on lines 177..204

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 209.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Similar blocks of code found in 2 locations. Consider refactoring.
      Open

                          if ($("#edit_labels").length > 0) {
                        $("#edit_labels").tagit({
                            allowSpaces: true,
                            singleField: true,
                            singleFieldDelimiter: ",",
      Severity: Major
      Found in public/lib/javascript/tools.js and 1 other location - About 1 hr to fix
      public/lib/javascript/tools.js on lines 301..308

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 59.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Similar blocks of code found in 2 locations. Consider refactoring.
      Open

                          if ($("#edit_tags").length > 0) {
                        $("#edit_tags").tagit({
                            allowSpaces: true,
                            singleField: true,
                            singleFieldDelimiter: ",",
      Severity: Major
      Found in public/lib/javascript/tools.js and 1 other location - About 1 hr to fix
      public/lib/javascript/tools.js on lines 309..316

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 59.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      There are no issues that match your filters.

      Category
      Status