amtgard/ORK3

View on GitHub

Showing 621 of 2,354 total issues

Similar blocks of code found in 12 locations. Consider refactoring.
Open

$server->wsdl->addComplexType(
        'RemoveAwardRequest',
        'complexType',
        'struct',
        'all',
Severity: Major
Found in orkservice/Award/AwardService.definitions.php and 11 other locations - About 30 mins to fix
orkservice/Attendance/AttendanceService.definitions.php on lines 112..124
orkservice/Authorization/AuthorizationService.definitions.php on lines 25..37
orkservice/Common.SOAP.php on lines 45..57
orkservice/Kingdom/KingdomService.definitions.php on lines 35..47
orkservice/Kingdom/KingdomService.definitions.php on lines 103..115
orkservice/Kingdom/KingdomService.definitions.php on lines 128..140
orkservice/Park/ParkService.definitions.php on lines 68..80
orkservice/Player/PlayerService.definitions.php on lines 12..24
orkservice/Player/PlayerService.definitions.php on lines 349..361
orkservice/Player/PlayerService.definitions.php on lines 413..425
orkservice/Report/ReportService.definitions.php on lines 135..147

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 91.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 12 locations. Consider refactoring.
Open

    $server->wsdl->addComplexType(
            'ConfigurationEditItemType',
            'complexType',
            'struct',
            'all',
Severity: Major
Found in orkservice/Common.SOAP.php and 11 other locations - About 30 mins to fix
orkservice/Attendance/AttendanceService.definitions.php on lines 112..124
orkservice/Authorization/AuthorizationService.definitions.php on lines 25..37
orkservice/Award/AwardService.definitions.php on lines 110..122
orkservice/Kingdom/KingdomService.definitions.php on lines 35..47
orkservice/Kingdom/KingdomService.definitions.php on lines 103..115
orkservice/Kingdom/KingdomService.definitions.php on lines 128..140
orkservice/Park/ParkService.definitions.php on lines 68..80
orkservice/Player/PlayerService.definitions.php on lines 12..24
orkservice/Player/PlayerService.definitions.php on lines 349..361
orkservice/Player/PlayerService.definitions.php on lines 413..425
orkservice/Report/ReportService.definitions.php on lines 135..147

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 91.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 12 locations. Consider refactoring.
Open

$server->wsdl->addComplexType(
        'SetPlayerReconciledCreditsRequest',
        'complexType',
        'struct',
        'all',
Severity: Major
Found in orkservice/Player/PlayerService.definitions.php and 11 other locations - About 30 mins to fix
orkservice/Attendance/AttendanceService.definitions.php on lines 112..124
orkservice/Authorization/AuthorizationService.definitions.php on lines 25..37
orkservice/Award/AwardService.definitions.php on lines 110..122
orkservice/Common.SOAP.php on lines 45..57
orkservice/Kingdom/KingdomService.definitions.php on lines 35..47
orkservice/Kingdom/KingdomService.definitions.php on lines 103..115
orkservice/Kingdom/KingdomService.definitions.php on lines 128..140
orkservice/Park/ParkService.definitions.php on lines 68..80
orkservice/Player/PlayerService.definitions.php on lines 349..361
orkservice/Player/PlayerService.definitions.php on lines 413..425
orkservice/Report/ReportService.definitions.php on lines 135..147

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 91.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 12 locations. Consider refactoring.
Open

$server->wsdl->addComplexType(
        'ParkAuthorizationInfoType',
        'complextType',
        'struct',
        'all',
Severity: Major
Found in orkservice/Park/ParkService.definitions.php and 11 other locations - About 30 mins to fix
orkservice/Attendance/AttendanceService.definitions.php on lines 112..124
orkservice/Authorization/AuthorizationService.definitions.php on lines 25..37
orkservice/Award/AwardService.definitions.php on lines 110..122
orkservice/Common.SOAP.php on lines 45..57
orkservice/Kingdom/KingdomService.definitions.php on lines 35..47
orkservice/Kingdom/KingdomService.definitions.php on lines 103..115
orkservice/Kingdom/KingdomService.definitions.php on lines 128..140
orkservice/Player/PlayerService.definitions.php on lines 12..24
orkservice/Player/PlayerService.definitions.php on lines 349..361
orkservice/Player/PlayerService.definitions.php on lines 413..425
orkservice/Report/ReportService.definitions.php on lines 135..147

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 91.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 12 locations. Consider refactoring.
Open

$server->wsdl->addComplexType(
        'KingdomAuthorizationInfoType',
        'complextType',
        'struct',
        'all',
Severity: Major
Found in orkservice/Kingdom/KingdomService.definitions.php and 11 other locations - About 30 mins to fix
orkservice/Attendance/AttendanceService.definitions.php on lines 112..124
orkservice/Authorization/AuthorizationService.definitions.php on lines 25..37
orkservice/Award/AwardService.definitions.php on lines 110..122
orkservice/Common.SOAP.php on lines 45..57
orkservice/Kingdom/KingdomService.definitions.php on lines 35..47
orkservice/Kingdom/KingdomService.definitions.php on lines 103..115
orkservice/Park/ParkService.definitions.php on lines 68..80
orkservice/Player/PlayerService.definitions.php on lines 12..24
orkservice/Player/PlayerService.definitions.php on lines 349..361
orkservice/Player/PlayerService.definitions.php on lines 413..425
orkservice/Report/ReportService.definitions.php on lines 135..147

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 91.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 12 locations. Consider refactoring.
Open

$server->wsdl->addComplexType(
        'SetClassRequest',
        'complexType',
        'struct',
        'all',
Severity: Major
Found in orkservice/Attendance/AttendanceService.definitions.php and 11 other locations - About 30 mins to fix
orkservice/Authorization/AuthorizationService.definitions.php on lines 25..37
orkservice/Award/AwardService.definitions.php on lines 110..122
orkservice/Common.SOAP.php on lines 45..57
orkservice/Kingdom/KingdomService.definitions.php on lines 35..47
orkservice/Kingdom/KingdomService.definitions.php on lines 103..115
orkservice/Kingdom/KingdomService.definitions.php on lines 128..140
orkservice/Park/ParkService.definitions.php on lines 68..80
orkservice/Player/PlayerService.definitions.php on lines 12..24
orkservice/Player/PlayerService.definitions.php on lines 349..361
orkservice/Player/PlayerService.definitions.php on lines 413..425
orkservice/Report/ReportService.definitions.php on lines 135..147

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 91.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 12 locations. Consider refactoring.
Open

$server->wsdl->addComplexType(
        'AuthorizeResponse',
        'complexType',
        'struct',
        'all',
Severity: Major
Found in orkservice/Authorization/AuthorizationService.definitions.php and 11 other locations - About 30 mins to fix
orkservice/Attendance/AttendanceService.definitions.php on lines 112..124
orkservice/Award/AwardService.definitions.php on lines 110..122
orkservice/Common.SOAP.php on lines 45..57
orkservice/Kingdom/KingdomService.definitions.php on lines 35..47
orkservice/Kingdom/KingdomService.definitions.php on lines 103..115
orkservice/Kingdom/KingdomService.definitions.php on lines 128..140
orkservice/Park/ParkService.definitions.php on lines 68..80
orkservice/Player/PlayerService.definitions.php on lines 12..24
orkservice/Player/PlayerService.definitions.php on lines 349..361
orkservice/Player/PlayerService.definitions.php on lines 413..425
orkservice/Report/ReportService.definitions.php on lines 135..147

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 91.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 12 locations. Consider refactoring.
Open

$server->wsdl->addComplexType(
        'GetKingdomDetailsResponse',
        'complextType',
        'struct',
        'all',
Severity: Major
Found in orkservice/Kingdom/KingdomService.definitions.php and 11 other locations - About 30 mins to fix
orkservice/Attendance/AttendanceService.definitions.php on lines 112..124
orkservice/Authorization/AuthorizationService.definitions.php on lines 25..37
orkservice/Award/AwardService.definitions.php on lines 110..122
orkservice/Common.SOAP.php on lines 45..57
orkservice/Kingdom/KingdomService.definitions.php on lines 35..47
orkservice/Kingdom/KingdomService.definitions.php on lines 128..140
orkservice/Park/ParkService.definitions.php on lines 68..80
orkservice/Player/PlayerService.definitions.php on lines 12..24
orkservice/Player/PlayerService.definitions.php on lines 349..361
orkservice/Player/PlayerService.definitions.php on lines 413..425
orkservice/Report/ReportService.definitions.php on lines 135..147

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 91.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 2 locations. Consider refactoring.
Open

    function __construct(& $database, $table, $left_field, $right_field, $tree_field = null) {
        parent::__construct($database, $table);
        $this->__LEFT_FIELD = $left_field;
        $this->__RIGHT_FIELD = $right_field;
        $this->__NEXT_MODE = YapoTree::NEXT_DEFAULT;
system/lib/Yapo2/class.YapoNestedSetTree.php on lines 17..24

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 91.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 2 locations. Consider refactoring.
Open

                do {
                    $response['ApplicationRequests'][] = array(
                            'ApplicationAuthorizationId' => $r->application_auth_id,
                            'ApplicationId' => $r->application_id,
                            'MundaneId' => $r->mundane_id,
Severity: Minor
Found in system/lib/ork3/class.Authorization.php and 1 other location - About 30 mins to fix
system/lib/ork3/class.Report.php on lines 410..423

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 91.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 12 locations. Consider refactoring.
Open

$server->wsdl->addComplexType(
        'KingdomShortInfoType',
        'complextType',
        'struct',
        'all',
Severity: Major
Found in orkservice/Kingdom/KingdomService.definitions.php and 11 other locations - About 30 mins to fix
orkservice/Attendance/AttendanceService.definitions.php on lines 112..124
orkservice/Authorization/AuthorizationService.definitions.php on lines 25..37
orkservice/Award/AwardService.definitions.php on lines 110..122
orkservice/Common.SOAP.php on lines 45..57
orkservice/Kingdom/KingdomService.definitions.php on lines 103..115
orkservice/Kingdom/KingdomService.definitions.php on lines 128..140
orkservice/Park/ParkService.definitions.php on lines 68..80
orkservice/Player/PlayerService.definitions.php on lines 12..24
orkservice/Player/PlayerService.definitions.php on lines 349..361
orkservice/Player/PlayerService.definitions.php on lines 413..425
orkservice/Report/ReportService.definitions.php on lines 135..147

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 91.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 12 locations. Consider refactoring.
Open

$server->wsdl->addComplexType(
        'GetKingdomParkAveragesRequest',
        'complextType',
        'struct',
        'all',
Severity: Major
Found in orkservice/Report/ReportService.definitions.php and 11 other locations - About 30 mins to fix
orkservice/Attendance/AttendanceService.definitions.php on lines 112..124
orkservice/Authorization/AuthorizationService.definitions.php on lines 25..37
orkservice/Award/AwardService.definitions.php on lines 110..122
orkservice/Common.SOAP.php on lines 45..57
orkservice/Kingdom/KingdomService.definitions.php on lines 35..47
orkservice/Kingdom/KingdomService.definitions.php on lines 103..115
orkservice/Kingdom/KingdomService.definitions.php on lines 128..140
orkservice/Park/ParkService.definitions.php on lines 68..80
orkservice/Player/PlayerService.definitions.php on lines 12..24
orkservice/Player/PlayerService.definitions.php on lines 349..361
orkservice/Player/PlayerService.definitions.php on lines 413..425

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 91.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 2 locations. Consider refactoring.
Open

            do {
                $response['Guilds'][] = array(
                        'MundaneId' => $r->mundane_id,
                        'Persona' => $r->persona,
                        'ClassId' => $r->class_id,
Severity: Minor
Found in system/lib/ork3/class.Report.php and 1 other location - About 30 mins to fix
system/lib/ork3/class.Authorization.php on lines 75..88

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 91.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 2 locations. Consider refactoring.
Open

    function __construct(& $database, $table, $left_field, $right_field, $tree_field = null) {
        parent::__construct($database, $table);
        $this->__LEFT_FIELD = $left_field;
        $this->__RIGHT_FIELD = $right_field;
        $this->__NEXT_MODE = YapoTree::NEXT_DEFAULT;
Severity: Minor
Found in system/lib/Yapo2/class.YapoNestedSetTree.php and 1 other location - About 30 mins to fix
system/lib/Yapo2/Driver/structure.Interface.YapoNestedSetTree.php on lines 13..20

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 91.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 12 locations. Consider refactoring.
Open

$server->wsdl->addComplexType(
        'MovePlayerRequest',
        'complexType',
        'struct',
        'all',
Severity: Major
Found in orkservice/Player/PlayerService.definitions.php and 11 other locations - About 30 mins to fix
orkservice/Attendance/AttendanceService.definitions.php on lines 112..124
orkservice/Authorization/AuthorizationService.definitions.php on lines 25..37
orkservice/Award/AwardService.definitions.php on lines 110..122
orkservice/Common.SOAP.php on lines 45..57
orkservice/Kingdom/KingdomService.definitions.php on lines 35..47
orkservice/Kingdom/KingdomService.definitions.php on lines 103..115
orkservice/Kingdom/KingdomService.definitions.php on lines 128..140
orkservice/Park/ParkService.definitions.php on lines 68..80
orkservice/Player/PlayerService.definitions.php on lines 12..24
orkservice/Player/PlayerService.definitions.php on lines 413..425
orkservice/Report/ReportService.definitions.php on lines 135..147

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 91.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Identical blocks of code found in 2 locations. Consider refactoring.
Open

                $row = rows.row ? rows.row[rowIndex] : rows.normalized[rowIndex][c.columns].$row;
orkui/template/default/script/js/jquery-tablesorter/widgets/widget-alignChar.js on lines 103..103

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 45.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 2 locations. Consider refactoring.
Open

            case 'USER':
                if (count($searchtokens) > 0)
                    $s = implode(' or ', array_map(function($t) { return "`username` like '%" . mysql_real_escape_string($t) . "%'"; }, $searchtokens));
                    $order = "order by username,surname,given_name";
                    $opt[] = "length(`username`) > 0";
Severity: Minor
Found in system/lib/ork3/class.SearchService.php and 1 other location - About 30 mins to fix
system/lib/ork3/class.SearchService.php on lines 274..279

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 90.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Identical blocks of code found in 2 locations. Consider refactoring.
Open

<?php
die();

$DONOTWEBSERVICE = true;

Severity: Minor
Found in orkservice/Player/PlayerService.test.php and 1 other location - About 30 mins to fix
orkservice/Event/EventService.test.php on lines 1..21

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 90.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Identical blocks of code found in 2 locations. Consider refactoring.
Open

<?php
die();

$DONOTWEBSERVICE = true;

Severity: Minor
Found in orkservice/Event/EventService.test.php and 1 other location - About 30 mins to fix
orkservice/Player/PlayerService.test.php on lines 1..21

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 90.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 2 locations. Consider refactoring.
Open

            case 'PERSONA': 
                if (count($searchtokens) > 0)
                    $s = implode(' or ', array_map(function($t) { return "`persona` like '%" . mysql_real_escape_string($t) . "%'"; }, $searchtokens));
                    $order = "order by persona,surname,given_name";
                    $opt[] = "length(`persona`) > 0";
Severity: Minor
Found in system/lib/ork3/class.SearchService.php and 1 other location - About 30 mins to fix
system/lib/ork3/class.SearchService.php on lines 286..291

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 90.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Severity
Category
Status
Source
Language