Sign upLogin

anakinj/imagesorter

View on GitHub
Star

Showing 3 of 3 total issues

Method parse has 57 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    def self.parse(argv) # rubocop:disable  Metrics/MethodLength, Metrics/AbcSize
      options = OpenStruct.new(DEFAULT_OPTIONS)

      # rubocop:disable Metrics/BlockLength
      parser = ::OptionParser.new do |opts|
Severity: Major
Found in lib/imagesorter/option_parser.rb - About 2 hrs to fix

    Method collect_file_from_dir has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
    Open

        def collect_file_from_dir(dir, file)
      return if file =~ /^\.\.?$/

      full_path = File.join(dir, file)
    Severity: Minor
    Found in lib/imagesorter/file_batch_processor.rb - About 25 mins to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Method process has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
    Open

        def process(file)
      source = file.file.path

      dest = handle_duplicate(source, format_destination(file, full_name: File.basename(source),
                                                               name: File.basename(source, '.*'),
    Severity: Minor
    Found in lib/imagesorter/file_system_processor.rb - About 25 mins to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Severity
    Category
    Status
    Source
    Language