Sign upLogin

andela/codepirates-ah-backend

View on GitHub
Star
src/controllers/user.controller.js

Summary

Maintainability
D
3 days
Test Coverage

File user.controller.js has 367 lines of code (exceeds 250 allowed). Consider refactoring.
Open

import UserService from '../services/user.service';
import Helper from '../helpers/helper';
import EmailHelper from '../helpers/verification-email';
import sendPasswordResetEmailHelper from '../services/resetpassword.service';
import errorMiddleware from '../middlewares/error.middleware';
Severity: Minor
Found in src/controllers/user.controller.js - About 4 hrs to fix

    Function createAdmin has 65 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

      static async createAdmin(req, res) {
    try {
      const theUser = await UserService.findOne(req.body.email, '');
      const theUserName = await UserService.findOne('', req.body.username);
      if (theUser) {
    Severity: Major
    Found in src/controllers/user.controller.js - About 2 hrs to fix

      Function signup has 49 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

        static async signup(req, res) {
    const newUser = req.body;
    newUser.email = req.body.email.toLowerCase();
    try {
      const theUser = await UserService.findOne(req.body.email, '');
      Severity: Minor
      Found in src/controllers/user.controller.js - About 1 hr to fix

        Function login has 45 lines of code (exceeds 25 allowed). Consider refactoring.
        Open

          static async login(req, res) {
    try {
      let theUser;

      if (req.body.email) {
        Severity: Minor
        Found in src/controllers/user.controller.js - About 1 hr to fix

          Function handlePasswordReset has 43 lines of code (exceeds 25 allowed). Consider refactoring.
          Open

            static async handlePasswordReset(req, res) {
    // verify token and if its not expired
    const { token } = req.params;
    const tokenDecoded = Helper.verifyToken(token);
    if (tokenDecoded === 'invalid token') {
          Severity: Minor
          Found in src/controllers/user.controller.js - About 1 hr to fix

            Function requestPasswordReset has 33 lines of code (exceeds 25 allowed). Consider refactoring.
            Open

              static async requestPasswordReset(req, res) {
    // check if email provided exists in db
    const { email } = req.body;
    if (!email) {
      return res.status(400).send({
            Severity: Minor
            Found in src/controllers/user.controller.js - About 1 hr to fix

              Function updateUser has 27 lines of code (exceeds 25 allowed). Consider refactoring.
              Open

                static async updateUser(req, res) {
    const alteredUser = req.body;
    const { email } = req.params;
    if (!email) {
      return res.status(400).send({
              Severity: Minor
              Found in src/controllers/user.controller.js - About 1 hr to fix

                Avoid too many return statements within this function.
                Open

                      return res.status(404).send({
        status: 404,
        message: errors[0].message
      });
                Severity: Major
                Found in src/controllers/user.controller.js - About 30 mins to fix

                  Avoid too many return statements within this function.
                  Open

                        return res.status(404).send({
        status: 404,
        message: error
      });
                  Severity: Major
                  Found in src/controllers/user.controller.js - About 30 mins to fix

                    Avoid too many return statements within this function.
                    Open

                          return res.status(404).send({
        status: 404,
        message: error.message
      });
                    Severity: Major
                    Found in src/controllers/user.controller.js - About 30 mins to fix

                      Avoid too many return statements within this function.
                      Open

                            return res.status(200).send({
        status: 200,
        message: 'Password reset successfully'
      });
                      Severity: Major
                      Found in src/controllers/user.controller.js - About 30 mins to fix

                        Avoid too many return statements within this function.
                        Open

                              return res.status(500).send({
        status: 500,
        message: error.message
      });
                        Severity: Major
                        Found in src/controllers/user.controller.js - About 30 mins to fix

                          Avoid too many return statements within this function.
                          Open

                                return res.status(400).send({
        status: 400,
        message: 'Failed to fetch user'
      });
                          Severity: Major
                          Found in src/controllers/user.controller.js - About 30 mins to fix

                            Function login has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
                            Open

                              static async login(req, res) {
    try {
      let theUser;

      if (req.body.email) {
                            Severity: Minor
                            Found in src/controllers/user.controller.js - About 25 mins to fix

                            Cognitive Complexity

                            Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                            A method's cognitive complexity is based on a few simple rules:

                            • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                            • Code is considered more complex for each "break in the linear flow of the code"
                            • Code is considered more complex when "flow breaking structures are nested"

                            Further reading

                            Similar blocks of code found in 2 locations. Consider refactoring.
                            Open

                                  if (theUser) {
        return res.status(409).send({
          status: 409,
          message: `Cannot register admin with an email ${req.body.email} which is already in use.`
        });
                            Severity: Minor
                            Found in src/controllers/user.controller.js and 1 other location - About 55 mins to fix
                            src/controllers/user.controller.js on lines 92..99

                            Duplicated Code

                            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                            Tuning

                            This issue has a mass of 54.

                            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                            Refactorings

                            Further Reading

                            Similar blocks of code found in 2 locations. Consider refactoring.
                            Open

                                  if (theUserName) {
        return res.status(409).send({
          status: 409,
          message: `Cannot register admin with the username ${
            req.body.username
                            Severity: Minor
                            Found in src/controllers/user.controller.js and 1 other location - About 55 mins to fix
                            src/controllers/user.controller.js on lines 86..91

                            Duplicated Code

                            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                            Tuning

                            This issue has a mass of 54.

                            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                            Refactorings

                            Further Reading

                            Similar blocks of code found in 2 locations. Consider refactoring.
                            Open

                                if (!user) {
      return res.status(400).send({
        status: 400,
        message: `User with email ${email} is not not found `
      });
                            Severity: Minor
                            Found in src/controllers/user.controller.js and 1 other location - About 45 mins to fix
                            src/controllers/user.controller.js on lines 401..406

                            Duplicated Code

                            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                            Tuning

                            This issue has a mass of 50.

                            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                            Refactorings

                            Further Reading

                            Similar blocks of code found in 2 locations. Consider refactoring.
                            Open

                                  if (!user) {
        return res.status(400).send({
          status: 400,
          message: `User with email ${email} is not not found `
        });
                            Severity: Minor
                            Found in src/controllers/user.controller.js and 1 other location - About 45 mins to fix
                            src/controllers/user.controller.js on lines 456..461

                            Duplicated Code

                            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                            Tuning

                            This issue has a mass of 50.

                            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                            Refactorings

                            Further Reading

                            Similar blocks of code found in 2 locations. Consider refactoring.
                            Open

                                  if (!theUser) {
        return res.status(404).send({
          status: 404,
          message: `Can not find the user with id ${id}`
        });
                            Severity: Minor
                            Found in src/controllers/user.controller.js and 1 other location - About 40 mins to fix
                            src/controllers/user.controller.js on lines 338..343

                            Duplicated Code

                            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                            Tuning

                            This issue has a mass of 48.

                            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                            Refactorings

                            Further Reading

                            Similar blocks of code found in 2 locations. Consider refactoring.
                            Open

                                  if (!updateUser) {
        return res.status(404).send({
          status: 404,
          message: `User with email ${email} is not not found `
        });
                            Severity: Minor
                            Found in src/controllers/user.controller.js and 1 other location - About 40 mins to fix
                            src/controllers/user.controller.js on lines 262..267

                            Duplicated Code

                            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                            Tuning

                            This issue has a mass of 48.

                            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                            Refactorings

                            Further Reading

                            Similar blocks of code found in 2 locations. Consider refactoring.
                            Open

                                  const payload = {
        id: theUser.id,
        email: theUser.email,
        username: theUser.username,
        role: theUser.role,
                            Severity: Minor
                            Found in src/controllers/user.controller.js and 1 other location - About 35 mins to fix
                            src/models/appnotification.js on lines 3..9

                            Duplicated Code

                            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                            Tuning

                            This issue has a mass of 47.

                            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                            Refactorings

                            Further Reading

                            There are no issues that match your filters.

                            Category
                            Status