andela/team-odd-bn-backend

Function getUserTrips has 73 lines of code (exceeds 25 allowed). Consider refactoring.

Open

  static async getUserTrips(req) {
    const { Op } = Sequelize;
    const { from, to, user } = req.query;
    const { id, roleId } = req.user;
    let userTripsObject, requests;

File TripService.js has 256 lines of code (exceeds 250 allowed). Consider refactoring.

Open

import Sequelize, { Promise } from 'sequelize';
import {
  tripRequests, trips, userProfile, users, accommodations, cities, tripTypes, status
} from '../database/models';
import TripHelper from '../helpers/TripHelper';

Function availtripRequestsToManager has 45 lines of code (exceeds 25 allowed). Consider refactoring.

Open

  static async availtripRequestsToManager(id) {
    const userObj = {
      where: { managerId: id },
      attributes: ['userId'],
      raw: true

Function editTripRequestToUser has 35 lines of code (exceeds 25 allowed). Consider refactoring.

Open

  static async editTripRequestToUser(req) {
    const itinerary = req.body.itinerary ? req.body.itinerary : [req.body];

    const findAllObjQuery = {
      attributes: ['id'],

Function getSingleTrip has 34 lines of code (exceeds 25 allowed). Consider refactoring.

Open

  static async getSingleTrip(tripRequestId) {
    const singleTripObject = {
      where: { id: tripRequestId },
      include: [
        {

Function managerRequests has 34 lines of code (exceeds 25 allowed). Consider refactoring.

Open

    let managerRequests = managerUsers.map(async user => {
      const managerRequestsObj = {
        where: { userId: user.userId, statusId: 1 },
        attributes: ['id', 'updatedAt', 'createdAt'],
        order: [

Function getUserRequests has 30 lines of code (exceeds 25 allowed). Consider refactoring.

Open

  static async getUserRequests(req) {
    const requestsUsersObject = {
      where: { userId: req.user.id },
      order: [
        ['updatedAt', 'DESC'],

Identical blocks of code found in 2 locations. Consider refactoring.

Open

    const tripsWithCityName = requests.map((tripss) => tripss.trips.map(async (trip) => {
      const { originId, destinationId } = trip;
      const { origin, destination } = await TripHelper.getCityName({ originId, destinationId });
      trip.originId = origin.city;
      trip.destinationId = destination.city;

• Read up
  Read up

Identical blocks of code found in 2 locations. Consider refactoring.

Open

      const tripsWithCityName = await requests.map(async (trip) => {
        const { originId, destinationId } = trip;
        const { origin, destination } = await TripHelper.getCityName({ originId, destinationId });
        trip.originId = origin.city;
        trip.destinationId = destination.city;

• Read up
  Read up

Similar blocks of code found in 2 locations. Consider refactoring.

Open

      trip.dataValues
        .user.dataValues
        .tripRequests[0].dataValues
        .trips[0].dataValues
        .originId = origin.city;

• Read up
  Read up

Similar blocks of code found in 2 locations. Consider refactoring.

Open

      trip.dataValues
        .user.dataValues
        .tripRequests[0].dataValues
        .trips[0].dataValues
        .destinationId = destination.city;

• Read up
  Read up

Similar blocks of code found in 2 locations. Consider refactoring.

Open

        {
          originId: item.originId,
          destinationId: item.destinationId,
          reason: item.reason,
          startDate: item.startDate,

• Read up
  Read up