Sign upLogin

andremleblanc/druiddb-ruby

View on GitHub
Star

Showing 4 of 9 total issues

Method start_of_interval has 26 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    def start_of_interval(time)
      case granularity
      when 'second'
        time.change(usec: 0)
      when 'minute'
Severity: Minor
Found in lib/druiddb/query.rb - About 1 hr to fix

    Method query has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
    Open

          def query(query_object)
        begin
          response = connection.post(QUERY_PATH, query_object)
        rescue DruidDB::ConnectionError
          # TODO: Log
    Severity: Minor
    Found in lib/druiddb/node/broker.rb - About 35 mins to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Method bounded_wait_for_disable has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
    Open

          def bounded_wait_for_disable(datasource_name)
        condition = datasource_enabled?(datasource_name)
        attempts = 0
        max = 10
    Severity: Minor
    Found in lib/druiddb/node/coordinator.rb - About 25 mins to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Method bounded_wait_for_shutdown has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
    Open

          def bounded_wait_for_shutdown(task)
        condition = !(running_tasks.include? task)
        attempts = 0
        max = 10
    Severity: Minor
    Found in lib/druiddb/node/overlord.rb - About 25 mins to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Severity
    Category
    Status
    Source
    Language