Sign upLogin

andrewcsmith/mm

View on GitHub
Star

Showing 2 of 2 total issues

Class Ratio has 23 methods (exceeds 20 allowed). Consider refactoring.
Open

class MM::Ratio
  include Comparable
  include Enumerable

  def initialize n, d
Severity: Minor
Found in lib/mm/ratio.rb - About 2 hrs to fix

    Method find_from_point has a Cognitive Complexity of 10 (exceeds 5 allowed). Consider refactoring.
    Open

      def find_from_point point
    @iterations += 1
    # The adjacent points are all sorted
    # raise StopIteration if cost_function(point) > current_cost
    add_to_path point
    Severity: Minor
    Found in lib/mm/search.rb - About 1 hr to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Severity
    Category
    Status
    Source
    Language