Sign upLogin

andrewshawcare/thoughtworks-email-signature-generator

View on GitHub
Star
public/jsx/email_signature_generator.js

Summary

Maintainability
C
1 day
Test Coverage

Function render has 135 lines of code (exceeds 25 allowed). Consider refactoring.
Open

        render: function () {
            var properties = this.props.properties[this.state.language],
                theme = this.props.themes[this.state.theme];

            // FIXME: Figure out an elegant solution to updating out-of-scope DOM
Severity: Major
Found in public/jsx/email_signature_generator.js - About 5 hrs to fix

    FIXME found
    Open

                // FIXME: Figure out an elegant solution to updating out-of-scope DOM
    Severity: Minor
    Found in public/jsx/email_signature_generator.js by fixme

    Similar blocks of code found in 4 locations. Consider refactoring.
    Open

                            <Input
                            id="telephone"
                            type="tel"
                            label={properties.telephoneLabel}
                            value={this.state.telephone}
    Severity: Major
    Found in public/jsx/email_signature_generator.js and 3 other locations - About 55 mins to fix
    public/jsx/email_signature_generator.js on lines 102..108
    public/jsx/email_signature_generator.js on lines 109..115
    public/jsx/email_signature_generator.js on lines 116..122

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 54.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Similar blocks of code found in 4 locations. Consider refactoring.
    Open

                            <Input
                            id="name"
                            type="text"
                            label={properties.nameLabel}
                            value={this.state.name}
    Severity: Major
    Found in public/jsx/email_signature_generator.js and 3 other locations - About 55 mins to fix
    public/jsx/email_signature_generator.js on lines 109..115
    public/jsx/email_signature_generator.js on lines 116..122
    public/jsx/email_signature_generator.js on lines 123..129

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 54.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Similar blocks of code found in 4 locations. Consider refactoring.
    Open

                            <Input
                            id="title"
                            type="text"
                            label={properties.titleLabel}
                            value={this.state.title}
    Severity: Major
    Found in public/jsx/email_signature_generator.js and 3 other locations - About 55 mins to fix
    public/jsx/email_signature_generator.js on lines 102..108
    public/jsx/email_signature_generator.js on lines 116..122
    public/jsx/email_signature_generator.js on lines 123..129

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 54.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Similar blocks of code found in 4 locations. Consider refactoring.
    Open

                            <Input
                            id="email"
                            type="email"
                            label={properties.emailLabel}
                            value={this.state.email}
    Severity: Major
    Found in public/jsx/email_signature_generator.js and 3 other locations - About 55 mins to fix
    public/jsx/email_signature_generator.js on lines 102..108
    public/jsx/email_signature_generator.js on lines 109..115
    public/jsx/email_signature_generator.js on lines 123..129

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 54.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Similar blocks of code found in 2 locations. Consider refactoring.
    Open

                                options={this.props.languages.map(function (language) {
                                return {
                                    "label": properties[language],
                                    "value": language,
                                    "selected": this.state.language === language
    Severity: Minor
    Found in public/jsx/email_signature_generator.js and 1 other location - About 50 mins to fix
    public/jsx/email_signature_generator.js on lines 139..145

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 51.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Similar blocks of code found in 2 locations. Consider refactoring.
    Open

                                options={Object.keys(this.props.themes).map(function (theme) {
                                return {
                                    "label": properties[theme],
                                    "value": theme,
                                    "selected": this.state.theme === theme
    Severity: Minor
    Found in public/jsx/email_signature_generator.js and 1 other location - About 50 mins to fix
    public/jsx/email_signature_generator.js on lines 77..83

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 51.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    There are no issues that match your filters.

    Category
    Status