andywenk/page_performance

View on GitHub

Showing 4 of 10 total issues

Method parse has 69 lines of code (exceeds 25 allowed). Consider refactoring.
Open

      def parse
        @options[:ignore_ssl_errors] = 'no'

        option_parser = OptionParser.new do |opts|
          opts.banner = "PagePerformance v. #{@version}\n\nThis program is intended to test the performance of a website. It uses phantomjs which is a headless,\nwebkit based cli browser. "
Severity: Major
Found in lib/page_performance/utils/argv_parser.rb - About 2 hrs to fix

    Function generateTOC has 57 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

    function generateTOC() {
      if ($('#filecontents').length === 0) return;
      var _toc = $('<ol class="top"></ol>');
      var show = false;
      var toc = _toc;
    Severity: Major
    Found in doc/js/app.js - About 2 hrs to fix

      Function searchItem has a Cognitive Complexity of 17 (exceeds 5 allowed). Consider refactoring.
      Open

      function searchItem() {
        for (var i = 0; i < searchCache.length / 50; i++) {
          var item = searchCache[searchIndex];
          var searchName = (searchString.indexOf('::') != -1 ? item.fullName : item.name);
          var matchString = regexSearchString;
      Severity: Minor
      Found in doc/js/full_list.js - About 2 hrs to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Function fullListSearch has 45 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

      function fullListSearch() {
        // generate cache
        searchCache = [];
        $('#full_list li').each(function() {
          var link = $(this).find('.object_link a');
      Severity: Minor
      Found in doc/js/full_list.js - About 1 hr to fix
        Severity
        Category
        Status
        Source
        Language