Sign upLogin

anephenix/hub

View on GitHub
Star
__tests__/index.test.js

Summary

Maintainability
B
5 hrs
Test Coverage

File index.test.js has 363 lines of code (exceeds 250 allowed). Consider refactoring.
Open

const assert = require('assert');
const http = require('http');
const https = require('https');
const { Hub, HubClient } = require('../index');
const httpShutdown = require('http-shutdown');
Severity: Minor
Found in __tests__/index.test.js - About 4 hrs to fix

    Identical blocks of code found in 9 locations. Consider refactoring.
    Open

                hubClient.sarus.on('message', (event) => {
                const message = JSON.parse(event.data);
                messages.push(message);
            });
    Severity: Major
    Found in __tests__/index.test.js and 8 other locations - About 50 mins to fix
    __tests__/lib/pubsub.test.js on lines 157..160
    __tests__/lib/pubsub.test.js on lines 196..199
    __tests__/lib/pubsub.test.js on lines 236..239
    __tests__/lib/pubsub.test.js on lines 299..302
    __tests__/lib/pubsub.test.js on lines 330..333
    __tests__/lib/pubsub.test.js on lines 361..364
    __tests__/lib/pubsub.test.js on lines 498..501
    __tests__/lib/pubsub.test.js on lines 575..578

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 52.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    There are no issues that match your filters.

    Category
    Status