Sign upLogin

angular/angular.js

View on GitHub
Star
src/ng/filter/filter.js

Summary

Maintainability
D
1 day
Test Coverage

Function deepCompare has a Cognitive Complexity of 39 (exceeds 5 allowed). Consider refactoring.
Open

function deepCompare(actual, expected, comparator, anyPropertyKey, matchAgainstAnyProp, dontMatchWholeObject) {
  var actualType = getTypeForFilter(actual);
  var expectedType = getTypeForFilter(expected);

  if ((expectedType === 'string') && (expected.charAt(0) === '!')) {
Severity: Minor
Found in src/ng/filter/filter.js - About 5 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Function deepCompare has 41 lines of code (exceeds 25 allowed). Consider refactoring.
Open

function deepCompare(actual, expected, comparator, anyPropertyKey, matchAgainstAnyProp, dontMatchWholeObject) {
  var actualType = getTypeForFilter(actual);
  var expectedType = getTypeForFilter(expected);

  if ((expectedType === 'string') && (expected.charAt(0) === '!')) {
Severity: Minor
Found in src/ng/filter/filter.js - About 1 hr to fix

    Function filterFilter has 29 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

    function filterFilter() {
  return function(array, expression, comparator, anyPropertyKey) {
    if (!isArrayLike(array)) {
      if (array == null) {
        return array;
    Severity: Minor
    Found in src/ng/filter/filter.js - About 1 hr to fix

      Function createPredicateFn has 27 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

      function createPredicateFn(expression, comparator, anyPropertyKey, matchAgainstAnyProp) {
  var shouldMatchPrimitives = isObject(expression) && (anyPropertyKey in expression);
  var predicateFn;

  if (comparator === true) {
      Severity: Minor
      Found in src/ng/filter/filter.js - About 1 hr to fix

        Avoid deeply nested control flow statements.
        Open

                  if (isFunction(expectedVal) || isUndefined(expectedVal)) {
            continue;
          }
        Severity: Major
        Found in src/ng/filter/filter.js - About 45 mins to fix

          Avoid deeply nested control flow statements.
          Open

                    if (!deepCompare(actualVal, expectedVal, comparator, anyPropertyKey, matchAnyProperty, matchAnyProperty)) {
            return false;
          }
          Severity: Major
          Found in src/ng/filter/filter.js - About 45 mins to fix

            Function deepCompare has 6 arguments (exceeds 4 allowed). Consider refactoring.
            Open

            function deepCompare(actual, expected, comparator, anyPropertyKey, matchAgainstAnyProp, dontMatchWholeObject) {
            Severity: Minor
            Found in src/ng/filter/filter.js - About 45 mins to fix

              Avoid too many return statements within this function.
              Open

                      return true;
              Severity: Major
              Found in src/ng/filter/filter.js - About 30 mins to fix

                Avoid too many return statements within this function.
                Open

                            return false;
                Severity: Major
                Found in src/ng/filter/filter.js - About 30 mins to fix

                  Avoid too many return statements within this function.
                  Open

                          return comparator(actual, expected);
                  Severity: Major
                  Found in src/ng/filter/filter.js - About 30 mins to fix

                    There are no issues that match your filters.

                    Category
                    Status