Sign upLogin

angular/angular.js

View on GitHub
Star
src/ng/http.js

Summary

Maintainability
F
1 wk
Test Coverage

Function $HttpProvider has a Cognitive Complexity of 150 (exceeds 5 allowed). Consider refactoring.
Open

function $HttpProvider() {
  /**
   * @ngdoc property
   * @name $httpProvider#defaults
   * @description
Severity: Minor
Found in src/ng/http.js - About 3 days to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Function $HttpProvider has 308 lines of code (exceeds 25 allowed). Consider refactoring.
Open

function $HttpProvider() {
  /**
   * @ngdoc property
   * @name $httpProvider#defaults
   * @description
Severity: Major
Found in src/ng/http.js - About 1 day to fix

    Function $get has 270 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

          function($browser, $httpBackend, $$cookieReader, $cacheFactory, $rootScope, $q, $injector, $sce) {

    var defaultCache = $cacheFactory('$http');

    /**
    Severity: Major
    Found in src/ng/http.js - About 1 day to fix

      File http.js has 445 lines of code (exceeds 250 allowed). Consider refactoring.
      Open

      'use strict';

var APPLICATION_JSON = 'application/json';
var CONTENT_TYPE_APPLICATION_JSON = {'Content-Type': APPLICATION_JSON + ';charset=utf-8'};
var JSON_START = /^\[|^\{(?!\{)/;
      Severity: Minor
      Found in src/ng/http.js - About 6 hrs to fix

        Function sendReq has 108 lines of code (exceeds 25 allowed). Consider refactoring.
        Open

            function sendReq(config, reqData) {
      var deferred = $q.defer(),
          promise = deferred.promise,
          cache,
          cachedResp,
        Severity: Major
        Found in src/ng/http.js - About 4 hrs to fix

          Function $http has 100 lines of code (exceeds 25 allowed). Consider refactoring.
          Open

              function $http(requestConfig) {

      if (!isObject(requestConfig)) {
        throw minErr('$http')('badreq', 'Http request configuration must be an object.  Received: {0}', requestConfig);
      }
          Severity: Major
          Found in src/ng/http.js - About 4 hrs to fix

            Function $HttpParamSerializerJQLikeProvider has a Cognitive Complexity of 20 (exceeds 5 allowed). Consider refactoring.
            Open

            function $HttpParamSerializerJQLikeProvider() {
  /**
   * @ngdoc service
   * @name $httpParamSerializerJQLike
   *
            Severity: Minor
            Found in src/ng/http.js - About 2 hrs to fix

            Cognitive Complexity

            Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

            A method's cognitive complexity is based on a few simple rules:

            • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
            • Code is considered more complex for each "break in the linear flow of the code"
            • Code is considered more complex when "flow breaking structures are nested"

            Further reading

            Function defaultHttpResponseTransform has a Cognitive Complexity of 17 (exceeds 5 allowed). Consider refactoring.
            Open

            function defaultHttpResponseTransform(data, headers) {
  if (isString(data)) {
    // Strip json vulnerability protection prefix and trim whitespace
    var tempData = data.replace(JSON_PROTECTION_PREFIX, '').trim();
            Severity: Minor
            Found in src/ng/http.js - About 2 hrs to fix

            Cognitive Complexity

            Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

            A method's cognitive complexity is based on a few simple rules:

            • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
            • Code is considered more complex for each "break in the linear flow of the code"
            • Code is considered more complex when "flow breaking structures are nested"

            Further reading

            Function $HttpParamSerializerJQLikeProvider has 28 lines of code (exceeds 25 allowed). Consider refactoring.
            Open

            function $HttpParamSerializerJQLikeProvider() {
  /**
   * @ngdoc service
   * @name $httpParamSerializerJQLike
   *
            Severity: Minor
            Found in src/ng/http.js - About 1 hr to fix

              Function $get has 26 lines of code (exceeds 25 allowed). Consider refactoring.
              Open

                this.$get = function() {
    return function jQueryLikeParamSerializer(params) {
      if (!params) return '';
      var parts = [];
      serialize(params, '', true);
              Severity: Minor
              Found in src/ng/http.js - About 1 hr to fix

                Function $get has 8 arguments (exceeds 4 allowed). Consider refactoring.
                Open

                      function($browser, $httpBackend, $$cookieReader, $cacheFactory, $rootScope, $q, $injector, $sce) {
                Severity: Major
                Found in src/ng/http.js - About 1 hr to fix

                  Function done has 5 arguments (exceeds 4 allowed). Consider refactoring.
                  Open

                        function done(status, response, headersString, statusText, xhrStatus) {
                  Severity: Minor
                  Found in src/ng/http.js - About 35 mins to fix

                    Function resolvePromise has 5 arguments (exceeds 4 allowed). Consider refactoring.
                    Open

                          function resolvePromise(response, status, headers, statusText, xhrStatus) {
                    Severity: Minor
                    Found in src/ng/http.js - About 35 mins to fix

                      Function parseHeaders has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
                      Open

                      function parseHeaders(headers) {
  var parsed = createMap(), i;

  function fillInParsed(key, val) {
    if (key) {
                      Severity: Minor
                      Found in src/ng/http.js - About 35 mins to fix

                      Cognitive Complexity

                      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                      A method's cognitive complexity is based on a few simple rules:

                      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                      • Code is considered more complex for each "break in the linear flow of the code"
                      • Code is considered more complex when "flow breaking structures are nested"

                      Further reading

                      Similar blocks of code found in 2 locations. Consider refactoring.
                      Open

                        Object.defineProperty(this, 'xsrfWhitelistedOrigins', {
    get: function() {
      return this.xsrfTrustedOrigins;
    },
    set: function(origins) {
                      Severity: Major
                      Found in src/ng/http.js and 1 other location - About 1 hr to fix
                      src/ng/sce.js on lines 282..289

                      Duplicated Code

                      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                      Tuning

                      This issue has a mass of 55.

                      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                      Refactorings

                      Further Reading

                      There are no issues that match your filters.

                      Category
                      Status