Sign upLogin

angular/angular.js

View on GitHub
Star
src/ng/location.js

Summary

Maintainability
F
5 days
Test Coverage

File location.js has 442 lines of code (exceeds 250 allowed). Consider refactoring.
Open

'use strict';
/* global stripHash: true */

var PATH_MATCH = /^([^?#]*)(\?([^#]*))?(#(.*))?$/,
    DEFAULT_PORTS = {'http': 80, 'https': 443, 'ftp': 21};
Severity: Minor
Found in src/ng/location.js - About 6 hrs to fix

    Function $LocationProvider has 160 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

    function $LocationProvider() {
  var hashPrefix = '!',
      html5Mode = {
        enabled: false,
        requireBase: true,
    Severity: Major
    Found in src/ng/location.js - About 6 hrs to fix

      Function $LocationProvider has a Cognitive Complexity of 41 (exceeds 5 allowed). Consider refactoring.
      Open

      function $LocationProvider() {
  var hashPrefix = '!',
      html5Mode = {
        enabled: false,
        requireBase: true,
      Severity: Minor
      Found in src/ng/location.js - About 6 hrs to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Function $get has 124 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

            function($rootScope, $browser, $sniffer, $rootElement, $window) {
    var $location,
        LocationMode,
        baseHref = $browser.baseHref(), // if base[href] is undefined, it defaults to ''
        initialUrl = $browser.url(),
      Severity: Major
      Found in src/ng/location.js - About 4 hrs to fix

        Function LocationHashbangUrl has a Cognitive Complexity of 28 (exceeds 5 allowed). Consider refactoring.
        Open

        function LocationHashbangUrl(appBase, appBaseNoFile, hashPrefix) {

  parseAbsoluteUrl(appBase, this);
        Severity: Minor
        Found in src/ng/location.js - About 4 hrs to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        Function LocationHtml5Url has a Cognitive Complexity of 19 (exceeds 5 allowed). Consider refactoring.
        Open

        function LocationHtml5Url(appBase, appBaseNoFile, basePrefix) {
  this.$$html5 = true;
  basePrefix = basePrefix || '';
  parseAbsoluteUrl(appBase, this);
        Severity: Minor
        Found in src/ng/location.js - About 2 hrs to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        Function LocationHashbangUrl has 45 lines of code (exceeds 25 allowed). Consider refactoring.
        Open

        function LocationHashbangUrl(appBase, appBaseNoFile, hashPrefix) {

  parseAbsoluteUrl(appBase, this);
        Severity: Minor
        Found in src/ng/location.js - About 1 hr to fix

          Function LocationHtml5Url has 42 lines of code (exceeds 25 allowed). Consider refactoring.
          Open

          function LocationHtml5Url(appBase, appBaseNoFile, basePrefix) {
  this.$$html5 = true;
  basePrefix = basePrefix || '';
  parseAbsoluteUrl(appBase, this);
          Severity: Minor
          Found in src/ng/location.js - About 1 hr to fix

            Function $$parse has 32 lines of code (exceeds 25 allowed). Consider refactoring.
            Open

              this.$$parse = function(url) {
    var withoutBaseUrl = stripBaseUrl(appBase, url) || stripBaseUrl(appBaseNoFile, url);
    var withoutHashUrl;

    if (!isUndefined(withoutBaseUrl) && withoutBaseUrl.charAt(0) === '#') {
            Severity: Minor
            Found in src/ng/location.js - About 1 hr to fix

              Function $locationWatch has 29 lines of code (exceeds 25 allowed). Consider refactoring.
              Open

                  $rootScope.$watch(function $locationWatch() {
      if (initializing || $location.$$urlUpdatedByLocation) {
        $location.$$urlUpdatedByLocation = false;

        var oldUrl = $browser.url();
              Severity: Minor
              Found in src/ng/location.js - About 1 hr to fix

                Function search has 27 lines of code (exceeds 25 allowed). Consider refactoring.
                Open

                  search: function(search, paramValue) {
    switch (arguments.length) {
      case 0:
        return this.$$search;
      case 1:
                Severity: Minor
                Found in src/ng/location.js - About 1 hr to fix

                  Function LocationHashbangInHtml5Url has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
                  Open

                  function LocationHashbangInHtml5Url(appBase, appBaseNoFile, hashPrefix) {
  this.$$html5 = true;
  LocationHashbangUrl.apply(this, arguments);

  this.$$parseLinkUrl = function(url, relHref) {
                  Severity: Minor
                  Found in src/ng/location.js - About 45 mins to fix

                  Cognitive Complexity

                  Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                  A method's cognitive complexity is based on a few simple rules:

                  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                  • Code is considered more complex for each "break in the linear flow of the code"
                  • Code is considered more complex when "flow breaking structures are nested"

                  Further reading

                  Function search has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
                  Open

                    search: function(search, paramValue) {
    switch (arguments.length) {
      case 0:
        return this.$$search;
      case 1:
                  Severity: Minor
                  Found in src/ng/location.js - About 45 mins to fix

                  Cognitive Complexity

                  Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                  A method's cognitive complexity is based on a few simple rules:

                  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                  • Code is considered more complex for each "break in the linear flow of the code"
                  • Code is considered more complex when "flow breaking structures are nested"

                  Further reading

                  Consider simplifying this complex logical expression.
                  Open

                        if (!rewriteLinks || event.ctrlKey || event.metaKey || event.shiftKey || event.which === 2 || event.button === 2) return;
                  Severity: Major
                  Found in src/ng/location.js - About 40 mins to fix

                    Function $get has 5 arguments (exceeds 4 allowed). Consider refactoring.
                    Open

                          function($rootScope, $browser, $sniffer, $rootElement, $window) {
                    Severity: Minor
                    Found in src/ng/location.js - About 35 mins to fix

                      Similar blocks of code found in 2 locations. Consider refactoring.
                      Open

                        this.hashPrefix = function(prefix) {
    if (isDefined(prefix)) {
      hashPrefix = prefix;
      return this;
    } else {
                      Severity: Minor
                      Found in src/ng/location.js and 1 other location - About 40 mins to fix
                      src/ngSanitize/sanitize.js on lines 196..203

                      Duplicated Code

                      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                      Tuning

                      This issue has a mass of 49.

                      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                      Refactorings

                      Further Reading

                      There are no issues that match your filters.

                      Category
                      Status