Sign upLogin

angular/angular.js

View on GitHub
Star
src/ngAnimate/animateCss.js

Summary

Maintainability
F
2 wks
Test Coverage

Function $AnimateCssProvider has a Cognitive Complexity of 331 (exceeds 5 allowed). Consider refactoring.
Open

var $AnimateCssProvider = ['$animateProvider', /** @this */ function($animateProvider) {

  this.$get = ['$window', '$$jqLite', '$$AnimateRunner', '$timeout', '$$animateCache',
               '$$forceReflow', '$sniffer', '$$rAFScheduler', '$$animateQueue',
       function($window,   $$jqLite,   $$AnimateRunner,   $timeout,   $$animateCache,
Severity: Minor
Found in src/ngAnimate/animateCss.js - About 6 days to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Function $AnimateCssProvider has 470 lines of code (exceeds 25 allowed). Consider refactoring.
Open

var $AnimateCssProvider = ['$animateProvider', /** @this */ function($animateProvider) {

  this.$get = ['$window', '$$jqLite', '$$AnimateRunner', '$timeout', '$$animateCache',
               '$$forceReflow', '$sniffer', '$$rAFScheduler', '$$animateQueue',
       function($window,   $$jqLite,   $$AnimateRunner,   $timeout,   $$animateCache,
Severity: Major
Found in src/ngAnimate/animateCss.js - About 2 days to fix

    Function $get has 465 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

           function($window,   $$jqLite,   $$AnimateRunner,   $timeout,   $$animateCache,
                $$forceReflow,   $sniffer,   $$rAFScheduler, $$animateQueue) {

    var applyAnimationClasses = applyAnimationClassesFactory($$jqLite);
    Severity: Major
    Found in src/ngAnimate/animateCss.js - About 2 days to fix

      Function init has 409 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

          return function init(element, initialOptions) {
      // all of the animation functions should create
      // a copy of the options data, however, if a
      // parent service has already created a copy then
      // we should stick to using that
      Severity: Major
      Found in src/ngAnimate/animateCss.js - About 2 days to fix

        File animateCss.js has 546 lines of code (exceeds 250 allowed). Consider refactoring.
        Open

        'use strict';

/* exported $AnimateCssProvider */

var ANIMATE_TIMER_KEY = '$$animateCss';
        Severity: Major
        Found in src/ngAnimate/animateCss.js - About 1 day to fix

          Function start has 135 lines of code (exceeds 25 allowed). Consider refactoring.
          Open

                function start() {
        if (animationClosed) return;
        if (!node.parentNode) {
          close();
          return;
          Severity: Major
          Found in src/ngAnimate/animateCss.js - About 5 hrs to fix

            Function triggerAnimationStart has 86 lines of code (exceeds 25 allowed). Consider refactoring.
            Open

                    function triggerAnimationStart() {
          // just incase a stagger animation kicks in when the animation
          // itself was cancelled entirely
          if (animationClosed) return;
            Severity: Major
            Found in src/ngAnimate/animateCss.js - About 3 hrs to fix

              Function close has 39 lines of code (exceeds 25 allowed). Consider refactoring.
              Open

                    function close(rejected) {
        // if the promise has been called already then we shouldn't close
        // the animation again
        if (animationClosed || (animationCompleted && animationPaused)) return;
        animationClosed = true;
              Severity: Minor
              Found in src/ngAnimate/animateCss.js - About 1 hr to fix

                Function $get has 9 arguments (exceeds 4 allowed). Consider refactoring.
                Open

                       function($window,   $$jqLite,   $$AnimateRunner,   $timeout,   $$animateCache,
                $$forceReflow,   $sniffer,   $$rAFScheduler, $$animateQueue) {
                Severity: Major
                Found in src/ngAnimate/animateCss.js - About 1 hr to fix

                  Function computeCachedCssStyles has 5 arguments (exceeds 4 allowed). Consider refactoring.
                  Open

                      function computeCachedCssStyles(node, className, cacheKey, allowNoDuration, properties) {
                  Severity: Minor
                  Found in src/ngAnimate/animateCss.js - About 35 mins to fix

                    Avoid too many return statements within this function.
                    Open

                          return {
        $$willAnimate: true,
        end: endFn,
        start: function() {
          if (animationClosed) return;
                    Severity: Major
                    Found in src/ngAnimate/animateCss.js - About 30 mins to fix

                      Avoid too many return statements within this function.
                      Open

                              return closeAndReturnNoopAnimator();
                      Severity: Major
                      Found in src/ngAnimate/animateCss.js - About 30 mins to fix

                        Similar blocks of code found in 2 locations. Consider refactoring.
                        Open

                                  if (options.to) {
            if (options.cleanupStyles) {
              registerRestorableStyles(restoreStyles, node, Object.keys(options.to));
            }
            applyAnimationToStyles(element, options);
                        Severity: Minor
                        Found in src/ngAnimate/animateCss.js and 1 other location - About 50 mins to fix
                        src/ngAnimate/animateCss.js on lines 639..644

                        Duplicated Code

                        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                        Tuning

                        This issue has a mass of 51.

                        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                        Refactorings

                        Further Reading

                        Similar blocks of code found in 2 locations. Consider refactoring.
                        Open

                                    if (flags.hasAnimations) {
              easeProp = ANIMATION_PROP + TIMING_KEY;
              temporaryStyles.push([easeProp, easeVal]);
              node.style[easeProp] = easeVal;
            }
                        Severity: Minor
                        Found in src/ngAnimate/animateCss.js and 1 other location - About 50 mins to fix
                        src/ngAnimate/animateCss.js on lines 916..920

                        Duplicated Code

                        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                        Tuning

                        This issue has a mass of 51.

                        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                        Refactorings

                        Further Reading

                        Similar blocks of code found in 2 locations. Consider refactoring.
                        Open

                                    if (flags.hasTransitions) {
              easeProp = TRANSITION_PROP + TIMING_KEY;
              temporaryStyles.push([easeProp, easeVal]);
              node.style[easeProp] = easeVal;
            }
                        Severity: Minor
                        Found in src/ngAnimate/animateCss.js and 1 other location - About 50 mins to fix
                        src/ngAnimate/animateCss.js on lines 921..925

                        Duplicated Code

                        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                        Tuning

                        This issue has a mass of 51.

                        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                        Refactorings

                        Further Reading

                        Similar blocks of code found in 2 locations. Consider refactoring.
                        Open

                              if (options.from) {
        if (options.cleanupStyles) {
          registerRestorableStyles(restoreStyles, node, Object.keys(options.from));
        }
        applyAnimationFromStyles(element, options);
                        Severity: Minor
                        Found in src/ngAnimate/animateCss.js and 1 other location - About 50 mins to fix
                        src/ngAnimate/animateCss.js on lines 966..971

                        Duplicated Code

                        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                        Tuning

                        This issue has a mass of 51.

                        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                        Refactorings

                        Further Reading

                        There are no issues that match your filters.

                        Category
                        Status