Sign upLogin

angular/angular.js

View on GitHub
Star
src/ngSanitize/sanitize.js

Summary

Maintainability
F
5 days
Test Coverage

Function $SanitizeProvider has a Cognitive Complexity of 120 (exceeds 5 allowed). Consider refactoring.
Open

function $SanitizeProvider() {
  var hasBeenInstantiated = false;
  var svgEnabled = false;

  this.$get = ['$$sanitizeUri', function($$sanitizeUri) {
Severity: Minor
Found in src/ngSanitize/sanitize.js - About 2 days to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Function $SanitizeProvider has 294 lines of code (exceeds 25 allowed). Consider refactoring.
Open

function $SanitizeProvider() {
  var hasBeenInstantiated = false;
  var svgEnabled = false;

  this.$get = ['$$sanitizeUri', function($$sanitizeUri) {
Severity: Major
Found in src/ngSanitize/sanitize.js - About 1 day to fix

    File sanitize.js has 317 lines of code (exceeds 250 allowed). Consider refactoring.
    Open

    'use strict';

/* * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * *
 *     Any commits to this file should be reviewed with security in mind.  *
 *   Changes to this file can potentially create security vulnerabilities. *
    Severity: Minor
    Found in src/ngSanitize/sanitize.js - About 3 hrs to fix

      Function htmlParserImpl has 48 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

        function htmlParserImpl(html, handler) {
    if (html === null || html === undefined) {
      html = '';
    } else if (typeof html !== 'string') {
      html = '' + html;
      Severity: Minor
      Found in src/ngSanitize/sanitize.js - About 1 hr to fix

        Function htmlSanitizeWriterImpl has 43 lines of code (exceeds 25 allowed). Consider refactoring.
        Open

          function htmlSanitizeWriterImpl(buf, uriValidator) {
    var ignoreCurrentElement = false;
    var out = bind(buf, buf.push);
    return {
      start: function(tag, attrs) {
        Severity: Minor
        Found in src/ngSanitize/sanitize.js - About 1 hr to fix

          Function getInertBodyElement has 33 lines of code (exceeds 25 allowed). Consider refactoring.
          Open

            var getInertBodyElement /* function(html: string): HTMLBodyElement */ = (function(window, document) {
    if (isDOMParserAvailable()) {
      return getInertBodyElement_DOMParser;
    }
          Severity: Minor
          Found in src/ngSanitize/sanitize.js - About 1 hr to fix

            Avoid deeply nested control flow statements.
            Open

                        if (node.nodeType === 1) {
              handler.end(node.nodeName.toLowerCase());
            }
            Severity: Major
            Found in src/ngSanitize/sanitize.js - About 45 mins to fix

              Avoid deeply nested control flow statements.
              Open

                          if (node === inertBodyElement) break;
              Severity: Major
              Found in src/ngSanitize/sanitize.js - About 45 mins to fix

                Similar blocks of code found in 2 locations. Consider refactoring.
                Open

                  this.enableSvg = function(enableSvg) {
    if (isDefined(enableSvg)) {
      svgEnabled = enableSvg;
      return this;
    } else {
                Severity: Minor
                Found in src/ngSanitize/sanitize.js and 1 other location - About 40 mins to fix
                src/ng/location.js on lines 745..752

                Duplicated Code

                Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                Tuning

                This issue has a mass of 49.

                We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                Refactorings

                Further Reading

                Similar blocks of code found in 2 locations. Consider refactoring.
                Open

                  nodeContains = window.Node.prototype.contains || /** @this */ function(arg) {
    // eslint-disable-next-line no-bitwise
    return !!(this.compareDocumentPosition(arg) & 16);
  };
                Severity: Minor
                Found in src/ngSanitize/sanitize.js and 1 other location - About 35 mins to fix
                src/jqLite.js on lines 312..315

                Duplicated Code

                Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                Tuning

                This issue has a mass of 46.

                We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                Refactorings

                Further Reading

                There are no issues that match your filters.

                Category
                Status