Sign upLogin

antaresproject/two_factor_auth

View on GitHub
Star

Showing 14 of 16 total issues

Method index has 39 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    public function index(User $user, Collection $areaProvidersCollection)
    {
        $items = [];

        foreach ($areaProvidersCollection as $areaProviders) {
Severity: Minor
Found in src/Http/Presenters/UserConfigurationPresenter.php - About 1 hr to fix

    Method form has 33 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

        public function form(Provider $provider)
    {
        /* @var $form FormGrid */

        $providerGateway = $this->twoFactorProvidersService->getProviderGatewayByName($provider->getName());
    Severity: Minor
    Found in src/Http/Presenters/ConfigurationPresenter.php - About 1 hr to fix

      Method setupAreaFieldset has 31 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

          protected function setupAreaFieldset(FormGrid $form, AreaProviders $areaProviders)
    {
        $selected    = 0;
        $enabled     = $areaProviders->getEnabledModel();
        $area        = $areaProviders->getArea();
      Severity: Minor
      Found in src/Http/Presenters/ConfigurationPresenter.php - About 1 hr to fix

        Method boot has 30 lines of code (exceeds 25 allowed). Consider refactoring.
        Open

            public function boot()
    {

        parent::boot();
        $router               = $this->app->make(Router::class);
        Severity: Minor
        Found in src/TwoFactorAuthServiceProvider.php - About 1 hr to fix

          Method up has 27 lines of code (exceeds 25 allowed). Consider refactoring.
          Open

              public function up()
    {
        try {
            $this->down();
          Severity: Minor
          Found in resources/database/migrations/2016_04_04_1_create_two_factor_auth_tables.php - About 1 hr to fix

            Method verify has 27 lines of code (exceeds 25 allowed). Consider refactoring.
            Open

                public function verify(UserConfig $user, AreaContract $area, Provider $provider, $secretKey = null)
    {
        return $this->formFactory->of('antares.two_factor_auth.provider.auth.verify', function (FormGrid $form) use ($user, $area, $provider, $secretKey) {
                    $form->simple(handles('two_factor_auth.post.verify', compact('area')));
                    $form->name('Two-Factor Authentication User Verification Form');
            Severity: Minor
            Found in src/Http/Presenters/AuthPresenter.php - About 1 hr to fix

              Function index has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
              Open

                  public function index(User $user, Collection $areaProvidersCollection)
    {
        $items = [];

        foreach ($areaProvidersCollection as $areaProviders) {
              Severity: Minor
              Found in src/Http/Presenters/UserConfigurationPresenter.php - About 45 mins to fix

              Cognitive Complexity

              Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

              A method's cognitive complexity is based on a few simple rules:

              • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
              • Code is considered more complex for each "break in the linear flow of the code"
              • Code is considered more complex when "flow breaking structures are nested"

              Further reading

              Method __construct has 5 arguments (exceeds 4 allowed). Consider refactoring.
              Open

                  public function __construct(Dispatcher $dispatcher, UserConfigurationPresenter $presenter, TwoFactorProvidersService $twoFactorProvidersService, UserProviderConfigService $userConfigService, UserConfigRepositoryContract $userConfigRepository)
              Severity: Minor
              Found in src/Processor/UserConfigurationProcessor.php - About 35 mins to fix

                Method __construct has 5 arguments (exceeds 4 allowed). Consider refactoring.
                Open

                    public function __construct(AreaManagerContract $areaManager, TwoFactorProvidersService $service, UserConfigRepositoryContract $userConfigRepository, UserProviderConfigService $userProviderConfigService, UrlGenerator $urlGenerator)
                Severity: Minor
                Found in src/Services/VerificationService.php - About 35 mins to fix

                  Function getAreaProvidersCollection has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
                  Open

                      public function getAreaProvidersCollection()
    {
        $collection = new Collection;

        foreach ($this->providers as $model) {
                  Severity: Minor
                  Found in src/Services/TwoFactorProvidersService.php - About 35 mins to fix

                  Cognitive Complexity

                  Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                  A method's cognitive complexity is based on a few simple rules:

                  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                  • Code is considered more complex for each "break in the linear flow of the code"
                  • Code is considered more complex when "flow breaking structures are nested"

                  Further reading

                  Avoid too many return statements within this method.
                  Open

                              return true;
                  Severity: Major
                  Found in src/Services/VerificationService.php - About 30 mins to fix

                    Avoid too many return statements within this method.
                    Open

                            return false;
                    Severity: Major
                    Found in src/Services/VerificationService.php - About 30 mins to fix

                      Function mustBeVerified has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
                      Open

                          public function mustBeVerified(Route $route, Guard $guard)
    {
        if ($guard->guest()) {
            $this->service->getAuthStore()->unverify();
                      Severity: Minor
                      Found in src/Services/VerificationService.php - About 25 mins to fix

                      Cognitive Complexity

                      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                      A method's cognitive complexity is based on a few simple rules:

                      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                      • Code is considered more complex for each "break in the linear flow of the code"
                      • Code is considered more complex when "flow breaking structures are nested"

                      Further reading

                      Function getSupportedAreas has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
                      Open

                          public function getSupportedAreas()
    {
        if ($this->user === null) {
            throw new Exception('No user has been provided to the service.');
        }
                      Severity: Minor
                      Found in src/Services/UserProviderConfigService.php - About 25 mins to fix

                      Cognitive Complexity

                      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                      A method's cognitive complexity is based on a few simple rules:

                      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                      • Code is considered more complex for each "break in the linear flow of the code"
                      • Code is considered more complex when "flow breaking structures are nested"

                      Further reading

                      Severity
                      Category
                      Status
                      Source
                      Language