File ssm2.py has 477 lines of code (exceeds 250 allowed). Consider refactoring.

Open

"""
   Copyright (C) 2012 STFC

   Licensed under the Apache License, Version 2.0 (the "License");
   you may not use this file except in compliance with the License.

Function __init__ has a Cognitive Complexity of 28 (exceeds 5 allowed). Consider refactoring.

Open

    def __init__(self, hosts_and_ports, qpath, cert, key, dest=None, listen=None,
                 capath=None, check_crls=False, use_ssl=True, enc_cert=None,
                 verify_enc_cert=True, pidfile=None, path_type='dirq',
                 protocol=STOMP_MESSAGING, project=None, token=''):
        """Create an SSM2 object.

• Read up
  Read up

Ssm2 has 25 functions (exceeds 20 allowed). Consider refactoring.

Open

class Ssm2(stomp.ConnectionListener):
    """Minimal SSM implementation."""

    # Schema for the dirq message queue.
    QSCHEMA = {'body': 'string', 'signer': 'string', 'empaid': 'string?'}

File agents.py has 266 lines of code (exceeds 250 allowed). Consider refactoring.

Open

#!/usr/bin/env python

# Copyright 2021 UK Research and Innovation
#
# Licensed under the Apache License, Version 2.0 (the "License");

Function send_all has a Cognitive Complexity of 17 (exceeds 5 allowed). Consider refactoring.

Open

    def send_all(self):
        """
        Send all the messages in the outgoing queue.

        Either via STOMP or HTTPS (to an Argo Message Broker).

• Read up
  Read up

Function __init__ has 16 arguments (exceeds 4 allowed). Consider refactoring.

Open

    def __init__(self, hosts_and_ports, qpath, cert, key, dest=None, listen=None,

Function run_receiver has a Cognitive Complexity of 15 (exceeds 5 allowed). Consider refactoring.

Open

def run_receiver(protocol, brokers, project, token, cp, log, dn_file):
    """Run Ssm2 as a receiver daemon."""
    if DaemonContext is None:
        log.error("Receiving SSMs must use python-daemon, but the "
                  "python-daemon module wasn't found.")

• Read up
  Read up

Function run_sender has a Cognitive Complexity of 13 (exceeds 5 allowed). Consider refactoring.

Open

def run_sender(protocol, brokers, project, token, cp, log):
    """Run Ssm2 as a sender."""
    try:
        server_cert = None
        verify_server_cert = True

• Read up
  Read up

Function get_ssm_args has a Cognitive Complexity of 11 (exceeds 5 allowed). Consider refactoring.

Open

def get_ssm_args(protocol, cp, log):
    """Return brokers, project, and token from config based on protocol."""
    if protocol == Ssm2.STOMP_MESSAGING:
        # Set defaults for AMS variables that Ssm2 constructor requires below.
        project = None

• Read up
  Read up

Function handle_connect has a Cognitive Complexity of 11 (exceeds 5 allowed). Consider refactoring.

Open

    def handle_connect(self):
        """Connect to broker.

        Assuming that the SSM has retrieved the details of the broker or
        brokers it wants to connect to, connect to one.

• Read up
  Read up

Function verify has a Cognitive Complexity of 9 (exceeds 5 allowed). Consider refactoring.

Open

def verify(signed_text, capath, check_crl):
    """Verify the signed message has been signed by the certificate.

    Verify the signed message has been signed by the certificate (attached to
    the supplied SMIME message) it claims to have, by one of the accepted CAs

• Read up
  Read up

Function run_receiver has 7 arguments (exceeds 4 allowed). Consider refactoring.

Open

def run_receiver(protocol, brokers, project, token, cp, log, dn_file):

Function _handle_msg has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.

Open

    def _handle_msg(self, text):
        """Deal with the raw message contents appropriately.

        Namely:
        - decrypt if necessary

• Read up
  Read up

Function get_dns has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.

Open

def get_dns(dn_file, log):
    """Retrieve a list of DNs from a file."""
    dns = []
    f = None
    try:

• Read up
  Read up

Function run_sender has 6 arguments (exceeds 4 allowed). Consider refactoring.

Open

def run_sender(protocol, brokers, project, token, cp, log):

Function _save_msg_to_queue has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.

Open

    def _save_msg_to_queue(self, body, empaid):
        """Extract message contents and add to the accept or reject queue."""
        if isinstance(body, bytes):
            body = body.decode('ascii')

• Read up
  Read up

Function verify_cert has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.

Open

def verify_cert(certstring, capath, check_crls=True):
    """Verify that the certificate is signed by a CA with a cert in capath.

    Note that I've had to compare strings in the output of openssl to check
    for verification, which may make this brittle.

• Read up
  Read up

Function start_connection has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.

Open

    def start_connection(self):
        """Start existing connection and subscribe to the relevant topics.

        If the timeout is reached without receiving confirmation of
        connection, raise an exception.

• Read up
  Read up

Avoid too many return statements within this function.

Open

        return message, signer, None

Avoid too many return statements within this function.

Open

    return certificate_public_key.strip() == private_public_key.strip()