Sign upLogin

apertureless/vue-chartjs

View on GitHub
Star
src/mixins/index.js

Summary

Maintainability
A
0 mins
Test Coverage

Function dataHandler has a Cognitive Complexity of 20 (exceeds 5 allowed). Consider refactoring.
Wontfix

function dataHandler(newData, oldData) {
  if (oldData) {
    let chart = this.$data._chart

    // Get new and old DataSet Labels
Severity: Minor
Found in src/mixins/index.js - About 2 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Function dataHandler has 59 lines of code (exceeds 25 allowed). Consider refactoring.
Wontfix

function dataHandler(newData, oldData) {
  if (oldData) {
    let chart = this.$data._chart

    // Get new and old DataSet Labels
Severity: Major
Found in src/mixins/index.js - About 2 hrs to fix

    Similar blocks of code found in 3 locations. Consider refactoring.
    Invalid

          if (newData.hasOwnProperty('xLabels')) {
        chart.data.xLabels = newData.xLabels
        this.$emit('xlabels:update')
      }
    Severity: Minor
    Found in src/mixins/index.js and 2 other locations - About 30 mins to fix
    src/mixins/index.js on lines 46..49
    src/mixins/index.js on lines 54..57

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 45.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Similar blocks of code found in 3 locations. Consider refactoring.
    Invalid

          if (newData.hasOwnProperty('yLabels')) {
        chart.data.yLabels = newData.yLabels
        this.$emit('ylabels:update')
      }
    Severity: Minor
    Found in src/mixins/index.js and 2 other locations - About 30 mins to fix
    src/mixins/index.js on lines 46..49
    src/mixins/index.js on lines 50..53

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 45.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Similar blocks of code found in 3 locations. Consider refactoring.
    Invalid

          if (newData.hasOwnProperty('labels')) {
        chart.data.labels = newData.labels
        this.$emit('labels:update')
      }
    Severity: Minor
    Found in src/mixins/index.js and 2 other locations - About 30 mins to fix
    src/mixins/index.js on lines 50..53
    src/mixins/index.js on lines 54..57

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 45.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Insert ;
    Open

            chart.data.xLabels = newData.xLabels
    Severity: Minor
    Found in src/mixins/index.js by eslint

    For more information visit Source: http://eslint.org/docs/rules/

    Replace 'chart:render') with "chart:render");
    Open

          this.$emit('chart:render')
    Severity: Minor
    Found in src/mixins/index.js by eslint

    For more information visit Source: http://eslint.org/docs/rules/

    Insert ;
    Open

          return dataset.label
    Severity: Minor
    Found in src/mixins/index.js by eslint

    For more information visit Source: http://eslint.org/docs/rules/

    Insert ;
    Open

        })
    Severity: Minor
    Found in src/mixins/index.js by eslint

    For more information visit Source: http://eslint.org/docs/rules/

    Insert ;
    Open

        const newLabels = JSON.stringify(newDatasetLabels)
    Severity: Minor
    Found in src/mixins/index.js by eslint

    For more information visit Source: http://eslint.org/docs/rules/

    Insert ;
    Open

    }
    Severity: Minor
    Found in src/mixins/index.js by eslint

    For more information visit Source: http://eslint.org/docs/rules/

    Replace 'xLabels' with "xLabels"
    Open

          if (newData.hasOwnProperty('xLabels')) {
    Severity: Minor
    Found in src/mixins/index.js by eslint

    For more information visit Source: http://eslint.org/docs/rules/

    Insert ;
    Open

        this.renderChart(this.chartData, this.options)
    Severity: Minor
    Found in src/mixins/index.js by eslint

    For more information visit Source: http://eslint.org/docs/rules/

    Insert ;
    Open

    }
    Severity: Minor
    Found in src/mixins/index.js by eslint

    For more information visit Source: http://eslint.org/docs/rules/

    Insert ;
    Open

        let chart = this.$data._chart
    Severity: Minor
    Found in src/mixins/index.js by eslint

    For more information visit Source: http://eslint.org/docs/rules/

    Replace '_meta'·&&·newDatasetKeys.indexOf(key)·===·-1 with "_meta"·&&·newDatasetKeys.indexOf(key)·===·-1;
    Open

              return key !== '_meta' && newDatasetKeys.indexOf(key) === -1
    Severity: Minor
    Found in src/mixins/index.js by eslint

    For more information visit Source: http://eslint.org/docs/rules/

    Insert ;
    Open

          chart.update()
    Severity: Minor
    Found in src/mixins/index.js by eslint

    For more information visit Source: http://eslint.org/docs/rules/

    Replace 'chart:destroy') with "chart:destroy");
    Open

            this.$emit('chart:destroy')
    Severity: Minor
    Found in src/mixins/index.js by eslint

    For more information visit Source: http://eslint.org/docs/rules/

    Replace 'chart:render') with "chart:render");
    Open

        this.$emit('chart:render')
    Severity: Minor
    Found in src/mixins/index.js by eslint

    For more information visit Source: http://eslint.org/docs/rules/

    Insert ;
    Open

            const newDatasetKeys = Object.keys(dataset)
    Severity: Minor
    Found in src/mixins/index.js by eslint

    For more information visit Source: http://eslint.org/docs/rules/

    Insert ;
    Open

        })
    Severity: Minor
    Found in src/mixins/index.js by eslint

    For more information visit Source: http://eslint.org/docs/rules/

    Insert ;
    Open

            })
    Severity: Minor
    Found in src/mixins/index.js by eslint

    For more information visit Source: http://eslint.org/docs/rules/

    Replace 'labels' with "labels"
    Open

          if (newData.hasOwnProperty('labels')) {
    Severity: Minor
    Found in src/mixins/index.js by eslint

    For more information visit Source: http://eslint.org/docs/rules/

    Replace 'yLabels' with "yLabels"
    Open

          if (newData.hasOwnProperty('yLabels')) {
    Severity: Minor
    Found in src/mixins/index.js by eslint

    For more information visit Source: http://eslint.org/docs/rules/

    Insert ;
    Open

          })
    Severity: Minor
    Found in src/mixins/index.js by eslint

    For more information visit Source: http://eslint.org/docs/rules/

    Insert ;
    Open

            chart.destroy()
    Severity: Minor
    Found in src/mixins/index.js by eslint

    For more information visit Source: http://eslint.org/docs/rules/

    Insert ;
    Open

          return dataset.label
    Severity: Minor
    Found in src/mixins/index.js by eslint

    For more information visit Source: http://eslint.org/docs/rules/

    Insert ;
    Open

        const oldLabels = JSON.stringify(oldDatasetLabels)
    Severity: Minor
    Found in src/mixins/index.js by eslint

    For more information visit Source: http://eslint.org/docs/rules/

    Replace 'xlabels:update') with "xlabels:update");
    Open

            this.$emit('xlabels:update')
    Severity: Minor
    Found in src/mixins/index.js by eslint

    For more information visit Source: http://eslint.org/docs/rules/

    Insert ;
    Open

        }
    Severity: Minor
    Found in src/mixins/index.js by eslint

    For more information visit Source: http://eslint.org/docs/rules/

    Insert ;
    Open

    }
    Severity: Minor
    Found in src/mixins/index.js by eslint

    For more information visit Source: http://eslint.org/docs/rules/

    Replace 'ylabels:update') with "ylabels:update");
    Open

            this.$emit('ylabels:update')
    Severity: Minor
    Found in src/mixins/index.js by eslint

    For more information visit Source: http://eslint.org/docs/rules/

    Insert ;
    Open

            })
    Severity: Minor
    Found in src/mixins/index.js by eslint

    For more information visit Source: http://eslint.org/docs/rules/

    Replace 'chart:destroy') with "chart:destroy");
    Open

          this.$emit('chart:destroy')
    Severity: Minor
    Found in src/mixins/index.js by eslint

    For more information visit Source: http://eslint.org/docs/rules/

    Insert ;
    Open

            const oldDatasetKeys = Object.keys(oldData.datasets[i])
    Severity: Minor
    Found in src/mixins/index.js by eslint

    For more information visit Source: http://eslint.org/docs/rules/

    Insert ;
    Open

          this.$data._chart.destroy()
    Severity: Minor
    Found in src/mixins/index.js by eslint

    For more information visit Source: http://eslint.org/docs/rules/

    Insert ;
    Open

            chart.data.yLabels = newData.yLabels
    Severity: Minor
    Found in src/mixins/index.js by eslint

    For more information visit Source: http://eslint.org/docs/rules/

    Insert ;
    Open

                chart.data.datasets[i][attribute] = dataset[attribute]
    Severity: Minor
    Found in src/mixins/index.js by eslint

    For more information visit Source: http://eslint.org/docs/rules/

    Replace 'chart:update') with "chart:update");
    Open

          this.$emit('chart:update')
    Severity: Minor
    Found in src/mixins/index.js by eslint

    For more information visit Source: http://eslint.org/docs/rules/

    Insert ;
    Open

            chart.data.labels = newData.labels
    Severity: Minor
    Found in src/mixins/index.js by eslint

    For more information visit Source: http://eslint.org/docs/rules/

    Replace 'labels:update') with "labels:update");
    Open

            this.$emit('labels:update')
    Severity: Minor
    Found in src/mixins/index.js by eslint

    For more information visit Source: http://eslint.org/docs/rules/

    Insert ;
    Open

              delete chart.data.datasets[i][deletionKey]
    Severity: Minor
    Found in src/mixins/index.js by eslint

    For more information visit Source: http://eslint.org/docs/rules/

    Insert ;
    Open

          this.renderChart(this.chartData, this.options)
    Severity: Minor
    Found in src/mixins/index.js by eslint

    For more information visit Source: http://eslint.org/docs/rules/

    There are no issues that match your filters.

    Category
    Status