Showing 59 of 92 total issues
Function New
has 6 return statements (exceeds 4 allowed). Open
Open
func New(c *up.Config, h http.Handler) (http.Handler, error) {
h = poweredby.New("up", h)
h = robots.New(c, h)
h = static.NewDynamic(c, h)
Function Build
has 6 return statements (exceeds 4 allowed). Open
Open
func Build(dir string) (io.ReadCloser, *archive.Stats, error) {
upignore, err := read(".upignore")
if err != nil {
return nil, nil, errors.Wrap(err, "reading .upignore")
}
Method Stack.Create
has 6 return statements (exceeds 4 allowed). Open
Open
func (s *Stack) Create(versions resources.Versions) error {
c := s.config
tmpl := s.template(versions)
name := c.Name
Method Stack.showNameservers
has 6 return statements (exceeds 4 allowed). Open
Open
func (s *Stack) showNameservers(stage *config.Stage) error {
if stage.Domain == "" {
return nil
}
Method Platform.Build
has 6 return statements (exceeds 4 allowed). Open
Open
func (p *Platform) Build() error {
start := time.Now()
p.zip = new(bytes.Buffer)
if err := p.injectProxy(); err != nil {
Method Platform.DeleteStack
has 6 return statements (exceeds 4 allowed). Open
Open
func (p *Platform) DeleteStack(region string, wait bool) error {
versions := resources.Versions{}
for _, s := range p.config.Stages {
versions[s.Name] = "1"
Function New
has 6 return statements (exceeds 4 allowed). Open
Open
func New(c *up.Config, next http.Handler) (http.Handler, error) {
if len(c.Redirects) == 0 {
return next, nil
}
Method Platform.createFunction
has 5 arguments (exceeds 4 allowed). Consider refactoring. Open
Open
func (p *Platform) createFunction(c *lambda.Lambda, a *apigateway.APIGateway, up *s3manager.Uploader, region string, d up.Deploy) (version string, err error) {
Method Platform.updateFunction
has 5 arguments (exceeds 4 allowed). Consider refactoring. Open
Open
func (p *Platform) updateFunction(c *lambda.Lambda, a *apigateway.APIGateway, up *s3manager.Uploader, region string, d up.Deploy) (version string, err error) {
Method Stack.report
has 5 return statements (exceeds 4 allowed). Open
Open
func (s *Stack) report(states map[string]Status) error {
defer s.events.Time("platform.stack.report", event.Fields{
"total": len(states),
"complete": 0,
})()
Function Create
has 5 return statements (exceeds 4 allowed). Open
Open
func Create() error {
var in struct {
Name string `json:"name"`
Profile string `json:"profile"`
Region string `json:"region"`
Function delete
has 5 return statements (exceeds 4 allowed). Open
Open
func delete(cmd *kingpin.Cmd) {
c := cmd.Command("delete", "Delete configured resources.")
c.Example(`up stack delete`, "Delete stack with confirmation prompt.")
c.Example(`up stack delete --force`, "Delete stack without confirmation prompt.")
c.Example(`up stack delete --async`, "Don't wait for deletion to complete.")
Method Stack.Show
has 5 return statements (exceeds 4 allowed). Open
Open
func (s *Stack) Show() error {
defer s.events.Time("platform.stack.show", nil)()
// show stack status
stack, err := s.getStack()
Method Platform.createFunction
has 5 return statements (exceeds 4 allowed). Open
Open
func (p *Platform) createFunction(c *lambda.Lambda, a *apigateway.APIGateway, up *s3manager.Uploader, region string, d up.Deploy) (version string, err error) {
// ensure bucket exists
if err := p.createBucket(region); err != nil && !util.IsBucketExists(err) {
return "", errors.Wrap(err, "creating s3 bucket")
}
Method Platform.createCerts
has 5 return statements (exceeds 4 allowed). Open
Open
func (p *Platform) createCerts() error {
s := session.New(aws.NewConfig().WithRegion("us-east-1"))
a := acm.New(s)
var domains []string
Function changeCard
has 5 return statements (exceeds 4 allowed). Open
Open
func changeCard(cmd *kingpin.Cmd) {
c := cmd.Command("change", "Change the default card.")
c.Action(func(_ *kingpin.ParseContext) error {
t, err := userconfig.Require()
Function getCert
has 5 return statements (exceeds 4 allowed). Open
Open
func getCert(certs []*acm.CertificateDetail, domain string) string {
// exact domain
for _, c := range certs {
if *c.DomainName == domain {
return *c.CertificateArn
Method Stack.Apply
has 5 return statements (exceeds 4 allowed). Open
Open
func (s *Stack) Apply() error {
c := s.config
name := c.Name
res, err := s.client.DescribeChangeSet(&cloudformation.DescribeChangeSetInput{
Function handleLine
has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring. Open
Open
function handleLine(line) {
if (debug) {
console.log('[shim] parsing: `%s`', line);
}
- Read upRead up
Cognitive Complexity
Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.
A method's cognitive complexity is based on a few simple rules:
- Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
- Code is considered more complex for each "break in the linear flow of the code"
- Code is considered more complex when "flow breaking structures are nested"