Sign upLogin

appbaseio/dejaVu

View on GitHub
Star
packages/browser/src/components/ConnectApp/ConnectApp.js

Summary

Maintainability
F
5 days
Test Coverage

File ConnectApp.js has 711 lines of code (exceeds 250 allowed). Consider refactoring.
Open

// @flow

import React, { Component } from 'react';
import { connect } from 'react-redux';
import { Form, Button, Alert, AutoComplete, Input, Modal } from 'antd';
Severity: Major
Found in packages/browser/src/components/ConnectApp/ConnectApp.js - About 1 day to fix

    Function render has 311 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

        render() {
        const {
            appname,
            url,
            pastApps,
    Severity: Major
    Found in packages/browser/src/components/ConnectApp/ConnectApp.js - About 1 day to fix

      Function componentDidMount has a Cognitive Complexity of 28 (exceeds 5 allowed). Consider refactoring.
      Open

          componentDidMount() {
        // sync state from url
        let appname = '';
        let url = '';
        const { mode, isConnected, isHidden, forceReconnect } = this.props;
      Severity: Minor
      Found in packages/browser/src/components/ConnectApp/ConnectApp.js - About 4 hrs to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Function componentDidMount has 80 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

          componentDidMount() {
        // sync state from url
        let appname = '';
        let url = '';
        const { mode, isConnected, isHidden, forceReconnect } = this.props;
      Severity: Major
      Found in packages/browser/src/components/ConnectApp/ConnectApp.js - About 3 hrs to fix

        Similar blocks of code found in 2 locations. Consider refactoring.
        Open

                                                    <div
                                                css={{
                                                    flex: 1,
                                                    marginLeft: 10,
                                                }}
        Severity: Major
        Found in packages/browser/src/components/ConnectApp/ConnectApp.js and 1 other location - About 1 hr to fix
        packages/browser/src/components/ConnectApp/ConnectApp.js on lines 591..607

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 70.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        Similar blocks of code found in 2 locations. Consider refactoring.
        Open

                                                    <div
                                                css={{
                                                    flex: 1,
                                                    marginLeft: 5,
                                                }}
        Severity: Major
        Found in packages/browser/src/components/ConnectApp/ConnectApp.js and 1 other location - About 1 hr to fix
        packages/browser/src/components/ConnectApp/ConnectApp.js on lines 608..624

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 70.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        Similar blocks of code found in 2 locations. Consider refactoring.
        Open

                this.setState({
            customHeaders: [
                ...customHeaders.slice(0, index),
                {
                    ...customHeaders[index],
        Severity: Major
        Found in packages/browser/src/components/ConnectApp/ConnectApp.js and 1 other location - About 1 hr to fix
        packages/browser/src/components/DataBrowser/MultipleUpdate.js on lines 187..196

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 59.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        Identical blocks of code found in 2 locations. Consider refactoring.
        Open

                            newApps.push({
                        appname,
                        url,
                        headers: customHeaders.filter(
                            item => item.key.trim() && item.value.trim(),
        Severity: Major
        Found in packages/browser/src/components/ConnectApp/ConnectApp.js and 1 other location - About 1 hr to fix
        packages/browser/src/components/ConnectApp/ConnectApp.js on lines 327..333

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 55.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        Identical blocks of code found in 2 locations. Consider refactoring.
        Open

                            newApps[appIndex] = {
                        appname,
                        url,
                        headers: customHeaders.filter(
                            item => item.key.trim() && item.value.trim(),
        Severity: Major
        Found in packages/browser/src/components/ConnectApp/ConnectApp.js and 1 other location - About 1 hr to fix
        packages/browser/src/components/ConnectApp/ConnectApp.js on lines 315..321

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 55.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        Similar blocks of code found in 7 locations. Consider refactoring.
        Open

                const {
            appname,
            url,
            pastApps,
            isShowingAppSwitcher,
        Severity: Major
        Found in packages/browser/src/components/ConnectApp/ConnectApp.js and 6 other locations - About 35 mins to fix
        packages/browser/src/components/DataBrowser/AddFieldModal.js on lines 125..133
        packages/browser/src/components/DataBrowser/AddRowModal.js on lines 134..142
        packages/browser/src/components/DataBrowser/DataBrowser.js on lines 75..83
        packages/browser/src/components/DataBrowser/UpdateRow.js on lines 81..89
        packages/browser/src/components/DataTable/DataGrid.js on lines 120..128
        packages/browser/src/components/DataTable/DataGrid.js on lines 170..178

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 47.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        Similar blocks of code found in 2 locations. Consider refactoring.
        Open

                const filteredHeaders = customHeaders.filter(
            item => item.key.trim() && item.value.trim(),
        );
        Severity: Minor
        Found in packages/browser/src/components/ConnectApp/ConnectApp.js and 1 other location - About 30 mins to fix
        packages/browser/src/components/DataBrowser/DataBrowser.js on lines 96..98

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 45.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        Similar blocks of code found in 2 locations. Consider refactoring.
        Open

                this.setState({
            customHeaders: [
                ...customHeaders.slice(0, index),
                ...customHeaders.slice(index + 1),
            ],
        Severity: Minor
        Found in packages/browser/src/components/ConnectApp/ConnectApp.js and 1 other location - About 30 mins to fix
        packages/browser/src/components/DataBrowser/MultipleUpdate.js on lines 169..171

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 45.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        There are no issues that match your filters.

        Category
        Status