appbaseio/dejaVu

View on GitHub
packages/browser/src/components/DataBrowser/MultipleUpdate.js

Summary

Maintainability
D
1 day
Test Coverage

Function render has 172 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    render() {
        const { data, isShowingModal, isSavingData } = this.state;
        const {
            columns,
            mappings,
Severity: Major
Found in packages/browser/src/components/DataBrowser/MultipleUpdate.js - About 6 hrs to fix

    File MultipleUpdate.js has 383 lines of code (exceeds 250 allowed). Consider refactoring.
    Open

    // @flow
    
    import React, { Component, Fragment } from 'react';
    import { Modal, Select, Button } from 'antd';
    import { CloseOutlined, PlusOutlined, EditOutlined } from '@ant-design/icons';
    Severity: Minor
    Found in packages/browser/src/components/DataBrowser/MultipleUpdate.js - About 5 hrs to fix

      Similar blocks of code found in 2 locations. Consider refactoring.
      Open

              this.setState({
                  data: [
                      ...data.slice(0, index),
                      {
                          ...data[index],
      packages/browser/src/components/ConnectApp/ConnectApp.js on lines 381..390

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 59.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Similar blocks of code found in 2 locations. Consider refactoring.
      Open

                      <Button
                          icon={<EditOutlined />}
                          type="primary"
                          css={{
                              margin: '0 3px',
      Severity: Minor
      Found in packages/browser/src/components/DataBrowser/MultipleUpdate.js and 1 other location - About 55 mins to fix
      packages/browser/src/components/DataBrowser/UpdateRow.js on lines 116..125

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 54.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Similar blocks of code found in 2 locations. Consider refactoring.
      Open

                  this.setState({
                      data: [...data.slice(0, index), ...data.slice(index + 1)],
                  });
      Severity: Minor
      Found in packages/browser/src/components/DataBrowser/MultipleUpdate.js and 1 other location - About 30 mins to fix
      packages/browser/src/components/ConnectApp/ConnectApp.js on lines 438..443

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 45.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      There are no issues that match your filters.

      Category
      Status