appbaseio/dejaVu

View on GitHub
packages/browser/src/utils/mappings.js

Summary

Maintainability
C
1 day
Test Coverage

File mappings.js has 315 lines of code (exceeds 250 allowed). Consider refactoring.
Open

import get from 'lodash/get';
import cloneDeep from 'lodash/cloneDeep';

import { dateFormatMap } from './date';

Severity: Minor
Found in packages/browser/src/utils/mappings.js - About 3 hrs to fix

    Function getTermsAggregationColumns has 60 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

    const getTermsAggregationColumns = properties => {
        const columns = [];
    
        if (properties) {
            Object.keys(properties).forEach(item => {
    Severity: Major
    Found in packages/browser/src/utils/mappings.js - About 2 hrs to fix

      Function getSortableColumns has 32 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

      const getSortableColumns = properties => {
          const columns = [];
          const sortableTypes = getSortableTypes();
      
          if (properties) {
      Severity: Minor
      Found in packages/browser/src/utils/mappings.js - About 1 hr to fix

        Function getNestedArrayField has 26 lines of code (exceeds 25 allowed). Consider refactoring.
        Open

        const getNestedArrayField = (data, mappings) => {
            const fieldsToBeDeleted = {};
            const parentFields = {};
            const indexTypeMap = {};
            data.forEach(dataItem => {
        Severity: Minor
        Found in packages/browser/src/utils/mappings.js - About 1 hr to fix

          Similar blocks of code found in 4 locations. Consider refactoring.
          Open

                          if (
                              properties[item].fields &&
                              properties[item].fields.keyword
                          ) {
                              columns.push(`${item}.keyword`);
          Severity: Major
          Found in packages/browser/src/utils/mappings.js and 3 other locations - About 50 mins to fix
          packages/browser/src/utils/mappings.js on lines 134..136
          packages/browser/src/utils/mappings.js on lines 138..143
          packages/browser/src/utils/mappings.js on lines 145..150

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 51.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          Similar blocks of code found in 4 locations. Consider refactoring.
          Open

                          if (
                              properties[item].originalFields &&
                              properties[item].originalFields.keyword
                          ) {
                              columns.push(`${item}.keyword`);
          Severity: Major
          Found in packages/browser/src/utils/mappings.js and 3 other locations - About 50 mins to fix
          packages/browser/src/utils/mappings.js on lines 127..132
          packages/browser/src/utils/mappings.js on lines 134..136
          packages/browser/src/utils/mappings.js on lines 145..150

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 51.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          Similar blocks of code found in 4 locations. Consider refactoring.
          Open

                          if (properties[item].fields && properties[item].fields.raw) {
                              columns.push(`${item}.raw`);
                          }
          Severity: Major
          Found in packages/browser/src/utils/mappings.js and 3 other locations - About 50 mins to fix
          packages/browser/src/utils/mappings.js on lines 127..132
          packages/browser/src/utils/mappings.js on lines 138..143
          packages/browser/src/utils/mappings.js on lines 145..150

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 51.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          Similar blocks of code found in 4 locations. Consider refactoring.
          Open

                          if (
                              properties[item].originalFields &&
                              properties[item].originalFields.raw
                          ) {
                              columns.push(`${item}.raw`);
          Severity: Major
          Found in packages/browser/src/utils/mappings.js and 3 other locations - About 50 mins to fix
          packages/browser/src/utils/mappings.js on lines 127..132
          packages/browser/src/utils/mappings.js on lines 134..136
          packages/browser/src/utils/mappings.js on lines 138..143

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 51.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          There are no issues that match your filters.

          Category
          Status