appbaseio/reactivesearch

View on GitHub
packages/web/src/components/basic/TagCloud.js

Summary

Maintainability
F
3 days
Test Coverage

File TagCloud.js has 318 lines of code (exceeds 250 allowed). Consider refactoring.
Open

import React, { Component } from 'react';

import {
    addComponent,
    removeComponent,
Severity: Minor
Found in packages/web/src/components/basic/TagCloud.js - About 3 hrs to fix

    Function render has 45 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

        render() {
            const min = 0.8;
            const max = 3;
    
            if (this.props.isLoading && this.props.loader) {
    Severity: Minor
    Found in packages/web/src/components/basic/TagCloud.js - About 1 hr to fix

      Similar blocks of code found in 4 locations. Consider refactoring.
      Open

          componentWillMount() {
              this.props.addComponent(this.internalComponent);
              this.props.addComponent(this.props.componentId);
              this.updateQueryOptions(this.props);
      
      
      Severity: Major
      Found in packages/web/src/components/basic/TagCloud.js and 3 other locations - About 5 hrs to fix
      packages/native/src/components/list/MultiDropdownList.js on lines 45..57
      packages/web/src/components/list/MultiDropdownList.js on lines 45..57
      packages/web/src/components/list/MultiList.js on lines 51..63

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 151.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Similar blocks of code found in 3 locations. Consider refactoring.
      Open

      const mapDispatchtoProps = dispatch => ({
          addComponent: component => dispatch(addComponent(component)),
          removeComponent: component => dispatch(removeComponent(component)),
          setQueryOptions: (component, props) => dispatch(setQueryOptions(component, props)),
          setQueryListener: (component, onQueryChange, beforeQueryChange) =>
      Severity: Major
      Found in packages/web/src/components/basic/TagCloud.js and 2 other locations - About 4 hrs to fix
      packages/web/src/components/list/MultiDropdownList.js on lines 457..465
      packages/web/src/components/list/SingleDropdownList.js on lines 360..368

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 122.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Similar blocks of code found in 11 locations. Consider refactoring.
      Open

          updateQuery = (value, props) => {
              const query = props.customQuery || TagCloud.defaultQuery;
      
              props.updateQuery({
                  componentId: props.componentId,
      Severity: Major
      Found in packages/web/src/components/basic/TagCloud.js and 10 other locations - About 3 hrs to fix
      packages/web/src/components/date/DatePicker.js on lines 152..164
      packages/web/src/components/list/MultiDropdownList.js on lines 284..296
      packages/web/src/components/list/MultiList.js on lines 292..304
      packages/web/src/components/list/SingleDropdownList.js on lines 189..201
      packages/web/src/components/list/SingleList.js on lines 199..211
      packages/web/src/components/range/MultiDropdownRange.js on lines 170..182
      packages/web/src/components/range/MultiRange.js on lines 173..185
      packages/web/src/components/range/RatingsFilter.js on lines 138..150
      packages/web/src/components/range/SingleDropdownRange.js on lines 131..143
      packages/web/src/components/range/SingleRange.js on lines 127..139

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 99.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Identical blocks of code found in 15 locations. Consider refactoring.
      Open

          setReact = (props) => {
              const { react } = props;
              if (react) {
                  const newReact = pushToAndClause(react, this.internalComponent);
                  props.watchComponent(props.componentId, newReact);
      Severity: Major
      Found in packages/web/src/components/basic/TagCloud.js and 14 other locations - About 2 hrs to fix
      packages/maps-native/src/components/maps/ReactiveMap.js on lines 215..223
      packages/maps/src/components/result/ReactiveMap.js on lines 350..358
      packages/native/src/components/list/MultiDropdownList.js on lines 99..107
      packages/native/src/components/list/SingleDropdownList.js on lines 83..91
      packages/native/src/components/range/RangeSlider.js on lines 110..118
      packages/native/src/components/result/ReactiveList.js on lines 241..249
      packages/native/src/components/search/DataSearch.js on lines 108..116
      packages/web/src/components/list/MultiDropdownList.js on lines 123..133
      packages/web/src/components/list/MultiList.js on lines 117..127
      packages/web/src/components/list/SingleDropdownList.js on lines 112..122
      packages/web/src/components/list/SingleList.js on lines 108..118
      packages/web/src/components/range/RangeSlider.js on lines 115..125
      packages/web/src/components/search/CategorySearch.js on lines 144..154
      packages/web/src/components/search/DataSearch.js on lines 121..131

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 93.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Identical blocks of code found in 3 locations. Consider refactoring.
      Open

              checkPropChange(this.props.options, nextProps.options, () => {
                  this.setState({
                      options: nextProps.options[nextProps.dataField]
                          ? nextProps.options[nextProps.dataField].buckets
                          : [],
      Severity: Major
      Found in packages/web/src/components/basic/TagCloud.js and 2 other locations - About 2 hrs to fix
      packages/native/src/components/list/MultiDropdownList.js on lines 61..67
      packages/native/src/components/list/SingleDropdownList.js on lines 55..61

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 78.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Similar blocks of code found in 23 locations. Consider refactoring.
      Open

                      {this.props.title && (
                          <Title className={getClassName(this.props.innerClass, 'title') || null}>
                              {this.props.title}
                          </Title>
                      )}
      Severity: Major
      Found in packages/web/src/components/basic/TagCloud.js and 22 other locations - About 1 hr to fix
      packages/maps/src/components/basic/GeoDistanceDropdown.js on lines 447..451
      packages/maps/src/components/basic/GeoDistanceSlider.js on lines 455..459
      packages/web/src/components/basic/NumberBox.js on lines 170..174
      packages/web/src/components/basic/TextField.js on lines 175..179
      packages/web/src/components/basic/ToggleButton.js on lines 191..195
      packages/web/src/components/date/DatePicker.js on lines 173..177
      packages/web/src/components/date/DateRange.js on lines 305..309
      packages/web/src/components/list/MultiDataList.js on lines 341..345
      packages/web/src/components/list/MultiDropdownList.js on lines 346..350
      packages/web/src/components/list/MultiList.js on lines 384..388
      packages/web/src/components/list/SingleDataList.js on lines 259..263
      packages/web/src/components/list/SingleDropdownList.js on lines 252..256
      packages/web/src/components/list/SingleList.js on lines 291..295
      packages/web/src/components/range/DynamicRangeSlider.js on lines 404..408
      packages/web/src/components/range/MultiDropdownRange.js on lines 187..191
      packages/web/src/components/range/MultiRange.js on lines 194..198
      packages/web/src/components/range/RangeSlider.js on lines 289..293
      packages/web/src/components/range/RatingsFilter.js on lines 155..159
      packages/web/src/components/range/SingleDropdownRange.js on lines 148..152
      packages/web/src/components/range/SingleRange.js on lines 148..152
      packages/web/src/components/search/CategorySearch.js on lines 568..572
      packages/web/src/components/search/DataSearch.js on lines 482..486

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 62.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Identical blocks of code found in 2 locations. Consider refactoring.
      Open

              checkSomePropChange(this.props, nextProps, ['dataField', 'nestedField'], () => {
                  this.updateQueryOptions(nextProps);
                  this.updateQuery(Object.keys(this.state.currentValue), nextProps);
              });
      Severity: Major
      Found in packages/web/src/components/basic/TagCloud.js and 1 other location - About 1 hr to fix
      packages/web/src/components/list/MultiList.js on lines 91..94

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 61.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Identical blocks of code found in 16 locations. Consider refactoring.
      Open

          componentWillUnmount() {
              this.props.removeComponent(this.props.componentId);
              this.props.removeComponent(this.internalComponent);
          }
      Severity: Major
      Found in packages/web/src/components/basic/TagCloud.js and 15 other locations - About 45 mins to fix
      packages/maps-native/src/components/maps/ReactiveMap.js on lines 210..213
      packages/maps/src/components/result/ReactiveMap.js on lines 345..348
      packages/native/src/components/list/MultiDropdownList.js on lines 94..97
      packages/native/src/components/list/SingleDropdownList.js on lines 78..81
      packages/native/src/components/range/RangeSlider.js on lines 105..108
      packages/native/src/components/search/DataSearch.js on lines 103..106
      packages/web/src/components/list/MultiDataList.js on lines 100..103
      packages/web/src/components/list/MultiDropdownList.js on lines 118..121
      packages/web/src/components/list/MultiList.js on lines 112..115
      packages/web/src/components/list/SingleDataList.js on lines 88..91
      packages/web/src/components/list/SingleDropdownList.js on lines 107..110
      packages/web/src/components/list/SingleList.js on lines 103..106
      packages/web/src/components/range/RangeSlider.js on lines 110..113
      packages/web/src/components/search/CategorySearch.js on lines 129..132
      packages/web/src/components/search/DataSearch.js on lines 116..119

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 50.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Similar blocks of code found in 3 locations. Consider refactoring.
      Open

                  options:
                      props.options && props.options[props.dataField]
                          ? props.options[props.dataField].buckets
                          : [],
      Severity: Minor
      Found in packages/web/src/components/basic/TagCloud.js and 2 other locations - About 40 mins to fix
      packages/vue/src/components/list/MultiList.jsx on lines 59..62
      packages/vue/src/components/list/SingleList.jsx on lines 57..60

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 48.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      There are no issues that match your filters.

      Category
      Status