Sign upLogin

appbaseio/reactivesearch

View on GitHub
Star
packages/web/src/components/list/SingleDataList.js

Summary

Maintainability
F
5 days
Test Coverage

File SingleDataList.js has 376 lines of code (exceeds 250 allowed). Consider refactoring.
Open

import React, { Component } from 'react';

import {
    addComponent,
    removeComponent,
Severity: Minor
Found in packages/web/src/components/list/SingleDataList.js - About 5 hrs to fix

    Function render has 93 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

        render() {
        const { selectAllLabel, showCount, renderListItem } = this.props;
        const { options } = this.state;

        if (options.length === 0) {
    Severity: Major
    Found in packages/web/src/components/list/SingleDataList.js - About 3 hrs to fix

      Function render has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
      Open

          render() {
        const { selectAllLabel, showCount, renderListItem } = this.props;
        const { options } = this.state;

        if (options.length === 0) {
      Severity: Minor
      Found in packages/web/src/components/list/SingleDataList.js - About 25 mins to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Similar blocks of code found in 2 locations. Consider refactoring.
      Open

                                      <label
                                    className={getClassName(this.props.innerClass, 'label') || null}
                                    htmlFor={`${this.props.componentId}-${item.label}`}
                                >
                                    {renderListItem ? (
      Severity: Major
      Found in packages/web/src/components/list/SingleDataList.js and 1 other location - About 6 hrs to fix
      packages/web/src/components/list/MultiDataList.js on lines 395..418

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 169.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Similar blocks of code found in 2 locations. Consider refactoring.
      Open

          updateStateOptions = (bucket) => {
        if (bucket) {
            const bucketDictionary = bucket.reduce(
                (obj, item) => ({
                    ...obj,
      Severity: Major
      Found in packages/web/src/components/list/SingleDataList.js and 1 other location - About 5 hrs to fix
      packages/web/src/components/list/MultiDataList.js on lines 274..300

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 150.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Similar blocks of code found in 4 locations. Consider refactoring.
      Open

          renderSearch = () => {
        if (this.props.showSearch) {
            return (
                <Input
                    className={getClassName(this.props.innerClass, 'input') || null}
      Severity: Major
      Found in packages/web/src/components/list/SingleDataList.js and 3 other locations - About 4 hrs to fix
      packages/web/src/components/list/MultiDataList.js on lines 309..325
      packages/web/src/components/list/MultiList.js on lines 340..356
      packages/web/src/components/list/SingleList.js on lines 247..263

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 130.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Similar blocks of code found in 2 locations. Consider refactoring.
      Open

      const mapDispatchtoProps = dispatch => ({
    addComponent: component => dispatch(addComponent(component)),
    removeComponent: component => dispatch(removeComponent(component)),
    updateQuery: updateQueryObject => dispatch(updateQuery(updateQueryObject)),
    watchComponent: (component, react) => dispatch(watchComponent(component, react)),
      Severity: Major
      Found in packages/web/src/components/list/SingleDataList.js and 1 other location - About 4 hrs to fix
      packages/web/src/components/list/MultiDataList.js on lines 488..496

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 122.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Identical blocks of code found in 2 locations. Consider refactoring.
      Open

                          {options
                        .filter((item) => {
                            if (this.props.showSearch && this.state.searchTerm) {
                                return item.label
                                    .toLowerCase()
      Severity: Major
      Found in packages/web/src/components/list/SingleDataList.js and 1 other location - About 2 hrs to fix
      packages/web/src/components/list/MultiDataList.js on lines 370..420

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 87.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Identical blocks of code found in 4 locations. Consider refactoring.
      Open

              if (this.props.defaultSelected !== nextProps.defaultSelected) {
            this.setValue(nextProps.defaultSelected);
        } else if (this.state.currentValue !== nextProps.selectedValue) {
            this.setValue(nextProps.selectedValue || '');
        }
      Severity: Major
      Found in packages/web/src/components/list/SingleDataList.js and 3 other locations - About 2 hrs to fix
      packages/native/src/components/list/SingleDropdownList.js on lines 71..75
      packages/web/src/components/list/SingleDropdownList.js on lines 100..104
      packages/web/src/components/list/SingleList.js on lines 96..100

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 81.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Similar blocks of code found in 23 locations. Consider refactoring.
      Open

                      {this.props.title && (
                    <Title className={getClassName(this.props.innerClass, 'title') || null}>
                        {this.props.title}
                    </Title>
                )}
      Severity: Major
      Found in packages/web/src/components/list/SingleDataList.js and 22 other locations - About 1 hr to fix
      packages/maps/src/components/basic/GeoDistanceDropdown.js on lines 447..451
      packages/maps/src/components/basic/GeoDistanceSlider.js on lines 455..459
      packages/web/src/components/basic/NumberBox.js on lines 170..174
      packages/web/src/components/basic/TagCloud.js on lines 247..251
      packages/web/src/components/basic/TextField.js on lines 175..179
      packages/web/src/components/basic/ToggleButton.js on lines 191..195
      packages/web/src/components/date/DatePicker.js on lines 173..177
      packages/web/src/components/date/DateRange.js on lines 305..309
      packages/web/src/components/list/MultiDataList.js on lines 341..345
      packages/web/src/components/list/MultiDropdownList.js on lines 346..350
      packages/web/src/components/list/MultiList.js on lines 384..388
      packages/web/src/components/list/SingleDropdownList.js on lines 252..256
      packages/web/src/components/list/SingleList.js on lines 291..295
      packages/web/src/components/range/DynamicRangeSlider.js on lines 404..408
      packages/web/src/components/range/MultiDropdownRange.js on lines 187..191
      packages/web/src/components/range/MultiRange.js on lines 194..198
      packages/web/src/components/range/RangeSlider.js on lines 289..293
      packages/web/src/components/range/RatingsFilter.js on lines 155..159
      packages/web/src/components/range/SingleDropdownRange.js on lines 148..152
      packages/web/src/components/range/SingleRange.js on lines 148..152
      packages/web/src/components/search/CategorySearch.js on lines 568..572
      packages/web/src/components/search/DataSearch.js on lines 482..486

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 62.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Identical blocks of code found in 2 locations. Consider refactoring.
      Open

          static generateQueryOptions(props, state) {
        const queryOptions = getQueryOptions(props);
        const includes = state.options.map(item => item.value);
        return getAggsQuery(queryOptions, props, includes);
    }
      Severity: Major
      Found in packages/web/src/components/list/SingleDataList.js and 1 other location - About 1 hr to fix
      packages/web/src/components/list/MultiDataList.js on lines 263..267

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 57.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Identical blocks of code found in 2 locations. Consider refactoring.
      Open

              checkPropChange(this.props.options, nextProps.options, () => {
            this.updateStateOptions(nextProps.options[nextProps.dataField].buckets);
        });
      Severity: Minor
      Found in packages/web/src/components/list/SingleDataList.js and 1 other location - About 55 mins to fix
      packages/web/src/components/list/MultiDataList.js on lines 79..81

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 53.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Identical blocks of code found in 16 locations. Consider refactoring.
      Open

          componentWillUnmount() {
        this.props.removeComponent(this.props.componentId);
        this.props.removeComponent(this.internalComponent);
    }
      Severity: Major
      Found in packages/web/src/components/list/SingleDataList.js and 15 other locations - About 45 mins to fix
      packages/maps-native/src/components/maps/ReactiveMap.js on lines 210..213
      packages/maps/src/components/result/ReactiveMap.js on lines 345..348
      packages/native/src/components/list/MultiDropdownList.js on lines 94..97
      packages/native/src/components/list/SingleDropdownList.js on lines 78..81
      packages/native/src/components/range/RangeSlider.js on lines 105..108
      packages/native/src/components/search/DataSearch.js on lines 103..106
      packages/web/src/components/basic/TagCloud.js on lines 92..95
      packages/web/src/components/list/MultiDataList.js on lines 100..103
      packages/web/src/components/list/MultiDropdownList.js on lines 118..121
      packages/web/src/components/list/MultiList.js on lines 112..115
      packages/web/src/components/list/SingleDropdownList.js on lines 107..110
      packages/web/src/components/list/SingleList.js on lines 103..106
      packages/web/src/components/range/RangeSlider.js on lines 110..113
      packages/web/src/components/search/CategorySearch.js on lines 129..132
      packages/web/src/components/search/DataSearch.js on lines 116..119

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 50.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Identical blocks of code found in 2 locations. Consider refactoring.
      Open

              checkPropChange(this.props.data, nextProps.data, () => {
            if (nextProps.showCount) {
                this.updateQueryOptions(nextProps);
            }
        });
      Severity: Minor
      Found in packages/web/src/components/list/SingleDataList.js and 1 other location - About 40 mins to fix
      packages/web/src/components/list/MultiDataList.js on lines 73..77

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 48.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Similar blocks of code found in 2 locations. Consider refactoring.
      Open

          updateQueryOptions = (props) => {
        const queryOptions = SingleDataList.generateQueryOptions(props, this.state);
        props.setQueryOptions(this.internalComponent, queryOptions);
    };
      Severity: Minor
      Found in packages/web/src/components/list/SingleDataList.js and 1 other location - About 35 mins to fix
      packages/web/src/components/list/MultiDataList.js on lines 269..272

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 47.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Similar blocks of code found in 3 locations. Consider refactoring.
      Open

                              <li
                            key={selectAllLabel}
                            className={`${
                                this.state.currentValue === selectAllLabel ? 'active' : ''
                            }`}
      Severity: Minor
      Found in packages/web/src/components/list/SingleDataList.js and 2 other locations - About 35 mins to fix
      packages/vue/src/components/list/SingleList.jsx on lines 141..167
      packages/web/src/components/list/SingleList.js on lines 299..321

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 46.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Identical blocks of code found in 5 locations. Consider refactoring.
      Open

          handleInputChange = (e) => {
        const { value } = e.target;
        this.setState({
            searchTerm: value,
        });
      Severity: Major
      Found in packages/web/src/components/list/SingleDataList.js and 4 other locations - About 30 mins to fix
      packages/web/src/components/shared/Dropdown.js on lines 67..72
      packages/web/src/components/list/MultiDataList.js on lines 302..307
      packages/web/src/components/list/MultiList.js on lines 328..333
      packages/web/src/components/list/SingleList.js on lines 235..240

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 45.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      There are no issues that match your filters.

      Category
      Status