Sign upLogin

appirio-tech/lc1-discussion-service

View on GitHub
Star

Showing 48 of 73 total issues

Function createEntity has 26 lines of code (exceeds 25 allowed). Consider refactoring.
Open

function createEntity(model, referenceModels, options, req, funcCallback) {
  async.waterfall([
    function(callback) {
      _checkExtraParameters(req, callback);
    },
Severity: Minor
Found in lib/controllerHelper.js - About 1 hr to fix

    Avoid deeply nested control flow statements.
    Open

                  if(!filterOne.id){
                reducedObject[key] = null;
                callback(null);
                return;
              }
    Severity: Major
    Found in lib/partialResponseHelper.js - About 45 mins to fix

      Function update has 6 arguments (exceeds 4 allowed). Consider refactoring.
      Open

      function update(model, referenceModels, options, req, res, next) {
      Severity: Minor
      Found in lib/controllerHelper.js - About 45 mins to fix

        Avoid deeply nested control flow statements.
        Open

              if (param[i]) {
        if (param[i] === ')') {
          routeHelper.addValidationError(req, 'Fields parameter must take entire pair of \'()\' .');
          return;
        } else if (!allowedCharacter(param[i])) {
        Severity: Major
        Found in lib/partialResponseHelper.js - About 45 mins to fix

          Function recursionReduce has 6 arguments (exceeds 4 allowed). Consider refactoring.
          Open

          function recursionReduce(req, Model, Entity, Property, Fields, callback){
          Severity: Minor
          Found in lib/partialResponseHelper.js - About 45 mins to fix

            Function get has 6 arguments (exceeds 4 allowed). Consider refactoring.
            Open

            function get(model, referenceModels, options, req, res, next) {
            Severity: Minor
            Found in lib/controllerHelper.js - About 45 mins to fix

              Function create has 6 arguments (exceeds 4 allowed). Consider refactoring.
              Open

              function create(model, referenceModels, options, req, res, next) {
              Severity: Minor
              Found in lib/controllerHelper.js - About 45 mins to fix

                Function all has 6 arguments (exceeds 4 allowed). Consider refactoring.
                Open

                function all(model, referenceModels, options, req, res, next) {
                Severity: Minor
                Found in lib/controllerHelper.js - About 45 mins to fix

                  Function deleteMethod has 6 arguments (exceeds 4 allowed). Consider refactoring.
                  Open

                  function deleteMethod(model, referenceModels, options, req, res, next) {
                  Severity: Minor
                  Found in lib/controllerHelper.js - About 45 mins to fix

                    Avoid deeply nested control flow statements.
                    Open

                                      if(!filterOne.id){
                    reducedObject[key] = null;
                    callback(null);
                    return;
                  }
                    Severity: Major
                    Found in lib/partialResponseHelper.js - About 45 mins to fix

                      Function recursionReduce has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
                      Open

                      function recursionReduce(req, Model, Entity, Property, Fields, callback){
  var subObject = Entity[Property];
  if(_.isArray(subObject)){

    var tasks = [];
                      Severity: Minor
                      Found in lib/partialResponseHelper.js - About 45 mins to fix

                      Cognitive Complexity

                      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                      A method's cognitive complexity is based on a few simple rules:

                      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                      • Code is considered more complex for each "break in the linear flow of the code"
                      • Code is considered more complex when "flow breaking structures are nested"

                      Further reading

                      Avoid deeply nested control flow statements.
                      Open

                            if (allowedCharacter(param[i])) {
        cache += param[i];
      } else {
        routeHelper.addValidationError(req, 'Fields parameter cannot contain character \'' + param[i] + '\' .');
        return;
                      Severity: Major
                      Found in lib/partialResponseHelper.js - About 45 mins to fix

                        Function deleteEntity has 5 arguments (exceeds 4 allowed). Consider refactoring.
                        Open

                        function deleteEntity(model, referenceModels, options, req, funcCallback) {
                        Severity: Minor
                        Found in lib/controllerHelper.js - About 35 mins to fix

                          Function _buildQueryFilter has 5 arguments (exceeds 4 allowed). Consider refactoring.
                          Open

                          function _buildQueryFilter(model, filtering, filters, req, callback) {
                          Severity: Minor
                          Found in lib/controllerHelper.js - About 35 mins to fix

                            Function updateEntity has 5 arguments (exceeds 4 allowed). Consider refactoring.
                            Open

                            function updateEntity(model, referenceModels, options, req, funcCallback) {
                            Severity: Minor
                            Found in lib/controllerHelper.js - About 35 mins to fix

                              Function _setFilter has 5 arguments (exceeds 4 allowed). Consider refactoring.
                              Open

                              function _setFilter(req, filters, operator, field, value) {
                              Severity: Minor
                              Found in lib/paramHelper.js - About 35 mins to fix

                                Function allEntities has 5 arguments (exceeds 4 allowed). Consider refactoring.
                                Open

                                function allEntities(model, referenceModels, options, req, funcCallback) {
                                Severity: Minor
                                Found in lib/controllerHelper.js - About 35 mins to fix

                                  Function createEntity has 5 arguments (exceeds 4 allowed). Consider refactoring.
                                  Open

                                  function createEntity(model, referenceModels, options, req, funcCallback) {
                                  Severity: Minor
                                  Found in lib/controllerHelper.js - About 35 mins to fix

                                    Function getEntity has 5 arguments (exceeds 4 allowed). Consider refactoring.
                                    Open

                                    function getEntity(model, referenceModels, options, req, funcCallback) {
                                    Severity: Minor
                                    Found in lib/controllerHelper.js - About 35 mins to fix

                                      Function addError has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
                                      Open

                                      exports.addError = function(req, err, errCode) {
  req.error = {};

  if (err instanceof Array) {   // Sequelize returns array
    req.error.message = err[0].message;
                                      Severity: Minor
                                      Found in lib/routeHelper.js - About 35 mins to fix

                                      Cognitive Complexity

                                      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                                      A method's cognitive complexity is based on a few simple rules:

                                      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                                      • Code is considered more complex for each "break in the linear flow of the code"
                                      • Code is considered more complex when "flow breaking structures are nested"

                                      Further reading

                                      Severity
                                      Category
                                      Status
                                      Source
                                      Language