Sign upLogin

appirio-tech/lc1-discussion-service

View on GitHub
Star
lib/paramHelper.js

Summary

Maintainability
C
1 day
Test Coverage

Function parseOrderBy has 37 lines of code (exceeds 25 allowed). Consider refactoring.
Open

exports.parseOrderBy = function(model, req, filters, orderParam) {
  if (!orderParam) {
    routeHelper.addValidationError(req, 'Value of orderBy parameter is empty');
    return;
  }
Severity: Minor
Found in lib/paramHelper.js - About 1 hr to fix

    Function parseOrderBy has a Cognitive Complexity of 12 (exceeds 5 allowed). Consider refactoring.
    Open

    exports.parseOrderBy = function(model, req, filters, orderParam) {
  if (!orderParam) {
    routeHelper.addValidationError(req, 'Value of orderBy parameter is empty');
    return;
  }
    Severity: Minor
    Found in lib/paramHelper.js - About 1 hr to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Function parseFilter has 32 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

    exports.parseFilter = function(model, req, filters, filterParam) {
  if (!filterParam) {
    routeHelper.addValidationError(req, 'Value of filter parameter is empty');
    return;
  }
    Severity: Minor
    Found in lib/paramHelper.js - About 1 hr to fix

      Function _setFilter has 31 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

      function _setFilter(req, filters, operator, field, value) {
  switch (operator) {
    case '=': 
      var matched = value.match(/^in\s*\((.*)\)/);
      if (matched && matched.length === 2) { // in operator
      Severity: Minor
      Found in lib/paramHelper.js - About 1 hr to fix

        Function _setFilter has a Cognitive Complexity of 10 (exceeds 5 allowed). Consider refactoring.
        Open

        function _setFilter(req, filters, operator, field, value) {
  switch (operator) {
    case '=': 
      var matched = value.match(/^in\s*\((.*)\)/);
      if (matched && matched.length === 2) { // in operator
        Severity: Minor
        Found in lib/paramHelper.js - About 1 hr to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        Function _setFilter has 5 arguments (exceeds 4 allowed). Consider refactoring.
        Open

        function _setFilter(req, filters, operator, field, value) {
        Severity: Minor
        Found in lib/paramHelper.js - About 35 mins to fix

          Avoid too many return statements within this function.
          Open

                return;
          Severity: Major
          Found in lib/paramHelper.js - About 30 mins to fix

            Avoid too many return statements within this function.
            Open

                  return;
            Severity: Major
            Found in lib/paramHelper.js - About 30 mins to fix

              Avoid too many return statements within this function.
              Open

                    return;
              Severity: Major
              Found in lib/paramHelper.js - About 30 mins to fix

                Similar blocks of code found in 2 locations. Consider refactoring.
                Open

                    if (orderParts[1].toLowerCase() !== 'desc' && orderParts[1].toLowerCase() !== 'asc') {
      routeHelper.addValidationError(req, orderParts[1] + ' is not supported in orderBy parameter');
      return;
    }
                Severity: Major
                Found in lib/paramHelper.js and 1 other location - About 1 hr to fix
                lib/paramHelper.js on lines 117..120

                Duplicated Code

                Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                Tuning

                This issue has a mass of 62.

                We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                Refactorings

                Further Reading

                Similar blocks of code found in 2 locations. Consider refactoring.
                Open

                    if (orderParts[3].toLowerCase() !== 'first' && orderParts[3].toLowerCase() !== 'last') {
      routeHelper.addValidationError(req, orderParts[3] + ' is not supported in orderBy parameter');
      return;
    }
                Severity: Major
                Found in lib/paramHelper.js and 1 other location - About 1 hr to fix
                lib/paramHelper.js on lines 105..108

                Duplicated Code

                Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                Tuning

                This issue has a mass of 62.

                We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                Refactorings

                Further Reading

                Identical blocks of code found in 2 locations. Consider refactoring.
                Open

                      if (!_.isNumber(intValue) || _.isNaN(intValue)) {
        routeHelper.addValidationError(req, value + ' is not a valid number');
        return;
      }
                Severity: Minor
                Found in lib/paramHelper.js and 1 other location - About 35 mins to fix
                lib/paramHelper.js on lines 34..37

                Duplicated Code

                Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                Tuning

                This issue has a mass of 46.

                We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                Refactorings

                Further Reading

                Identical blocks of code found in 2 locations. Consider refactoring.
                Open

                      if (!_.isNumber(intValue) || _.isNaN(intValue)) {
        routeHelper.addValidationError(req, value + ' is not a valid number');
        return;
      }
                Severity: Minor
                Found in lib/paramHelper.js and 1 other location - About 35 mins to fix
                lib/paramHelper.js on lines 42..45

                Duplicated Code

                Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                Tuning

                This issue has a mass of 46.

                We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                Refactorings

                Further Reading

                There are no issues that match your filters.

                Category
                Status