Sign upLogin

appirio-tech/lc1-discussion-service

View on GitHub
Star
lib/partialResponseHelper.js

Summary

Maintainability
F
1 wk
Test Coverage

Function recursionReduce has 134 lines of code (exceeds 25 allowed). Consider refactoring.
Open

function recursionReduce(req, Model, Entity, Property, Fields, callback){
  var subObject = Entity[Property];
  if(_.isArray(subObject)){

    var tasks = [];
Severity: Major
Found in lib/partialResponseHelper.js - About 5 hrs to fix

    Function iterationParse has a Cognitive Complexity of 30 (exceeds 5 allowed). Consider refactoring.
    Open

    function iterationParse(req, param, entity, property) {
  var subObject = null;
  if (!property) {
    subObject = entity;
  } else {
    Severity: Minor
    Found in lib/partialResponseHelper.js - About 4 hrs to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    File partialResponseHelper.js has 296 lines of code (exceeds 250 allowed). Consider refactoring.
    Open

    /**
 * Copyright (c) 2014 TopCoder, Inc. All rights reserved.
 */
/**
 * Helper methods for controller logic.
    Severity: Minor
    Found in lib/partialResponseHelper.js - About 3 hrs to fix

      Function iterationParse has 52 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

      function iterationParse(req, param, entity, property) {
  var subObject = null;
  if (!property) {
    subObject = entity;
  } else {
      Severity: Major
      Found in lib/partialResponseHelper.js - About 2 hrs to fix

        Function findRightBracket has a Cognitive Complexity of 12 (exceeds 5 allowed). Consider refactoring.
        Open

        function findRightBracket(req, string) {
  var count = 0;
  for (var i = 0; i < string.length; i += 1) {
    if (string[i] === ')') {
      if (i === 0) {
        Severity: Minor
        Found in lib/partialResponseHelper.js - About 1 hr to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        Avoid deeply nested control flow statements.
        Open

                      if(!filterOne.id){
                reducedObject[key] = null;
                callback(null);
                return;
              }
        Severity: Major
        Found in lib/partialResponseHelper.js - About 45 mins to fix

          Avoid deeply nested control flow statements.
          Open

                if (param[i]) {
        if (param[i] === ')') {
          routeHelper.addValidationError(req, 'Fields parameter must take entire pair of \'()\' .');
          return;
        } else if (!allowedCharacter(param[i])) {
          Severity: Major
          Found in lib/partialResponseHelper.js - About 45 mins to fix

            Function recursionReduce has 6 arguments (exceeds 4 allowed). Consider refactoring.
            Open

            function recursionReduce(req, Model, Entity, Property, Fields, callback){
            Severity: Minor
            Found in lib/partialResponseHelper.js - About 45 mins to fix

              Avoid deeply nested control flow statements.
              Open

                                if(!filterOne.id){
                    reducedObject[key] = null;
                    callback(null);
                    return;
                  }
              Severity: Major
              Found in lib/partialResponseHelper.js - About 45 mins to fix

                Function recursionReduce has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
                Open

                function recursionReduce(req, Model, Entity, Property, Fields, callback){
  var subObject = Entity[Property];
  if(_.isArray(subObject)){

    var tasks = [];
                Severity: Minor
                Found in lib/partialResponseHelper.js - About 45 mins to fix

                Cognitive Complexity

                Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                A method's cognitive complexity is based on a few simple rules:

                • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                • Code is considered more complex for each "break in the linear flow of the code"
                • Code is considered more complex when "flow breaking structures are nested"

                Further reading

                Avoid deeply nested control flow statements.
                Open

                      if (allowedCharacter(param[i])) {
        cache += param[i];
      } else {
        routeHelper.addValidationError(req, 'Fields parameter cannot contain character \'' + param[i] + '\' .');
        return;
                Severity: Major
                Found in lib/partialResponseHelper.js - About 45 mins to fix

                  Avoid too many return statements within this function.
                  Open

                          return;
                  Severity: Major
                  Found in lib/partialResponseHelper.js - About 30 mins to fix

                    Avoid too many return statements within this function.
                    Open

                              return;
                    Severity: Major
                    Found in lib/partialResponseHelper.js - About 30 mins to fix

                      Avoid too many return statements within this function.
                      Open

                                return;
                      Severity: Major
                      Found in lib/partialResponseHelper.js - About 30 mins to fix

                        Similar blocks of code found in 2 locations. Consider refactoring.
                        Open

                                if(!_.isObject(Fields)){
          if(!subObject){
            callback(null);
            return;
          }
                        Severity: Major
                        Found in lib/partialResponseHelper.js and 1 other location - About 3 days to fix
                        lib/partialResponseHelper.js on lines 286..339

                        Duplicated Code

                        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                        Tuning

                        This issue has a mass of 631.

                        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                        Refactorings

                        Further Reading

                        Similar blocks of code found in 2 locations. Consider refactoring.
                        Open

                            if(!_.isObject(Fields)){
      if(!subObject){
        callback(null);
        return;
      }
                        Severity: Major
                        Found in lib/partialResponseHelper.js and 1 other location - About 3 days to fix
                        lib/partialResponseHelper.js on lines 215..267

                        Duplicated Code

                        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                        Tuning

                        This issue has a mass of 631.

                        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                        Refactorings

                        Further Reading

                        There are no issues that match your filters.

                        Category
                        Status