Sign upLogin

appirits/comable

View on GitHub
Star

Showing 23 of 34 total issues

Similar blocks of code found in 9 locations. Consider refactoring.
Open

      def update
        if @payment_method.update_attributes(payment_method_params)
          redirect_to comable.admin_payment_method_path(@payment_method), notice: Comable.t('successful')
        else
          flash.now[:alert] = Comable.t('failure')
Severity: Major
Found in backend/app/controllers/comable/admin/payment_methods_controller.rb and 8 other locations - About 15 mins to fix
backend/app/controllers/comable/admin/orders_controller.rb on lines 28..34
backend/app/controllers/comable/admin/products_controller.rb on lines 36..42
backend/app/controllers/comable/admin/shipment_methods_controller.rb on lines 31..37
backend/app/controllers/comable/admin/stock_locations_controller.rb on lines 42..48
backend/app/controllers/comable/admin/stocks_controller.rb on lines 38..44
backend/app/controllers/comable/admin/themes_controller.rb on lines 35..41
backend/app/controllers/comable/admin/trackers_controller.rb on lines 31..37
backend/app/controllers/comable/admin/users_controller.rb on lines 26..32

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 25.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 2 locations. Consider refactoring.
Open

    def update
      if current_comable_user.reset_cart_item(@cart_item, cart_item_options)
        redirect_to comable.cart_path, notice: Comable.t('carts.updated')
      else
        flash.now[:alert] = Comable.t('carts.invalid')
Severity: Minor
Found in frontend/app/controllers/comable/carts_controller.rb and 1 other location - About 15 mins to fix
frontend/app/controllers/comable/carts_controller.rb on lines 7..13

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 25.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 9 locations. Consider refactoring.
Open

      def update
        if @tracker.update_attributes(tracker_params)
          redirect_to comable.admin_tracker_path(@tracker), notice: Comable.t('successful')
        else
          flash.now[:alert] = Comable.t('failure')
Severity: Major
Found in backend/app/controllers/comable/admin/trackers_controller.rb and 8 other locations - About 15 mins to fix
backend/app/controllers/comable/admin/orders_controller.rb on lines 28..34
backend/app/controllers/comable/admin/payment_methods_controller.rb on lines 31..37
backend/app/controllers/comable/admin/products_controller.rb on lines 36..42
backend/app/controllers/comable/admin/shipment_methods_controller.rb on lines 31..37
backend/app/controllers/comable/admin/stock_locations_controller.rb on lines 42..48
backend/app/controllers/comable/admin/stocks_controller.rb on lines 38..44
backend/app/controllers/comable/admin/themes_controller.rb on lines 35..41
backend/app/controllers/comable/admin/users_controller.rb on lines 26..32

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 25.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Severity
Category
Status
Source
Language