Sign upLogin

applicationsonline/librarian-chef

View on GitHub
Star

Showing 3 of 3 total issues

Class Line has 50 methods (exceeds 20 allowed). Consider refactoring.
Open

        class Line

          attr_accessor :source, :name
          private :source=, :name=
Severity: Minor
Found in lib/librarian/chef/source/site.rb - About 7 hrs to fix

    File site.rb has 376 lines of code (exceeds 250 allowed). Consider refactoring.
    Open

    require 'fileutils'
require 'pathname'
require 'uri'
require 'net/http'
require 'json'
    Severity: Minor
    Found in lib/librarian/chef/source/site.rb - About 5 hrs to fix

      Method install has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
      Open

            def install
        ensure!
        clean! if options["clean"]
        if options.include?("strip-dot-git")
          strip_dot_git_val = options["strip-dot-git"] ? "1" : nil
      Severity: Minor
      Found in lib/librarian/chef/cli.rb - About 25 mins to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Severity
      Category
      Status
      Source
      Language