appsflare/ludicrum-api

View on GitHub
api/policies/isTrustedClient.js

Summary

Maintainability
A
3 hrs
Test Coverage

Function exports has 30 lines of code (exceeds 25 allowed). Consider refactoring.
Open

module.exports = function (req, res, next) {

  var grantType = req.param('grant_type');
  if (!grantType) {
    return res.send(400, 'missing grant_type parameter');
Severity: Minor
Found in api/policies/isTrustedClient.js - About 1 hr to fix

    Function exports has a Cognitive Complexity of 10 (exceeds 5 allowed). Consider refactoring.
    Open

    module.exports = function (req, res, next) {
    
      var grantType = req.param('grant_type');
      if (!grantType) {
        return res.send(400, 'missing grant_type parameter');
    Severity: Minor
    Found in api/policies/isTrustedClient.js - About 1 hr to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Avoid deeply nested control flow statements.
    Open

                if (client.trusted) {
                  return next();
                } else {
                  return res.send(401, 'resource owner password flow is not allowed');
                }
    Severity: Major
    Found in api/policies/isTrustedClient.js - About 45 mins to fix

      Avoid deeply nested control flow statements.
      Open

                  if (!client) {
                    return res.send(404, "Client with client id " + clientId + " not found");
                  }
      Severity: Major
      Found in api/policies/isTrustedClient.js - About 45 mins to fix

        There are no issues that match your filters.

        Category
        Status