aquaform/project-lvl2-s96

View on GitHub

Showing 22 of 45 total issues

Function renderAstToPlain has a Cognitive Complexity of 27 (exceeds 5 allowed). Consider refactoring.
Open

const renderAstToPlain = (ast, host = '') => {
  const result = ast.map((node) => {
    switch (node.type) {
      case 'changed':
        if (host === '') {
Severity: Minor
Found in src/strategies/renderAstToPlain.js - About 3 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Function generateDiffs has a Cognitive Complexity of 18 (exceeds 5 allowed). Consider refactoring.
Open

const generateDiffs = (beforeConfig, afterConfig) => {
  const beforeConfigKeys = Object.keys(beforeConfig);
  const afterConfigKeys = Object.keys(afterConfig);
  const unionKeys = _.union(beforeConfigKeys, afterConfigKeys);
  const result = unionKeys.map((key) => {
Severity: Minor
Found in src/buildAstOfDiffs.js - About 2 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Function renderAstToTree has a Cognitive Complexity of 18 (exceeds 5 allowed). Consider refactoring.
Open

const renderAstToTree = (ast, indents = 1) => {
  const newIndentSize = indentSize.repeat(indents);
  const newIndents = indents + 2;

  const result = ast.map((node) => {
Severity: Minor
Found in src/strategies/renderAstToTree.js - About 2 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Function renderAstToPlain has 36 lines of code (exceeds 25 allowed). Consider refactoring.
Open

const renderAstToPlain = (ast, host = '') => {
  const result = ast.map((node) => {
    switch (node.type) {
      case 'changed':
        if (host === '') {
Severity: Minor
Found in src/strategies/renderAstToPlain.js - About 1 hr to fix

    Function result has 33 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

      const result = ast.map((node) => {
        switch (node.type) {
          case 'changed':
            if (host === '') {
              return `Property '${node.key}' was updated. From '${node.beforeValue}' to '${node.afterValue}'`;
    Severity: Minor
    Found in src/strategies/renderAstToPlain.js - About 1 hr to fix

      Function renderAstToTree has 29 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

      const renderAstToTree = (ast, indents = 1) => {
        const newIndentSize = indentSize.repeat(indents);
        const newIndents = indents + 2;
      
        const result = ast.map((node) => {
      Severity: Minor
      Found in src/strategies/renderAstToTree.js - About 1 hr to fix

        Avoid too many return statements within this function.
        Open

                  return `${newIndentSize}- ${node.key}: ${node.beforeValue}`;
        Severity: Major
        Found in src/strategies/renderAstToTree.js - About 30 mins to fix

          Avoid too many return statements within this function.
          Open

                    return renderAstToPlain(`${host}.${node.key}`, node.children);
          Severity: Major
          Found in src/strategies/renderAstToPlain.js - About 30 mins to fix

            Avoid too many return statements within this function.
            Open

                      return `${newIndentSize}+ ${node.key}: ${node.afterValue}`;
            Severity: Major
            Found in src/strategies/renderAstToTree.js - About 30 mins to fix

              Avoid too many return statements within this function.
              Open

                      return `${newIndentSize}- ${node.key}: ${renderAstToTree(node.children, newIndents)}`;
              Severity: Major
              Found in src/strategies/renderAstToTree.js - About 30 mins to fix

                Avoid too many return statements within this function.
                Open

                          return `Property '${node.key}' was added with value: '${node.afterValue}'`;
                Severity: Major
                Found in src/strategies/renderAstToPlain.js - About 30 mins to fix

                  Avoid too many return statements within this function.
                  Open

                            return `Property '${node.key}' was removed`;
                  Severity: Major
                  Found in src/strategies/renderAstToPlain.js - About 30 mins to fix

                    Avoid too many return statements within this function.
                    Open

                            return buildNode({ key, type: 'unchanged', beforeValue: beforeConfig[key], afterValue: afterConfig[key] });
                    Severity: Major
                    Found in src/buildAstOfDiffs.js - About 30 mins to fix

                      Avoid too many return statements within this function.
                      Open

                              return `${newIndentSize}+ ${node.key}: ${renderAstToTree(node.children, newIndents)}`;
                      Severity: Major
                      Found in src/strategies/renderAstToTree.js - About 30 mins to fix

                        Avoid too many return statements within this function.
                        Open

                                    return renderAstToPlain(node.children, node.key);
                        Severity: Major
                        Found in src/strategies/renderAstToPlain.js - About 30 mins to fix

                          Avoid too many return statements within this function.
                          Open

                              return null;
                          Severity: Major
                          Found in src/strategies/renderAstToTree.js - About 30 mins to fix

                            Avoid too many return statements within this function.
                            Open

                                return buildNode({ key, type: 'unchanged', children: generateDiffs(beforeConfig[key], afterConfig[key]) });
                            Severity: Major
                            Found in src/buildAstOfDiffs.js - About 30 mins to fix

                              Avoid too many return statements within this function.
                              Open

                                      return `Property '${host}.${node.key}' was added with value: '${node.afterValue}'`;
                              Severity: Major
                              Found in src/strategies/renderAstToPlain.js - About 30 mins to fix

                                Avoid too many return statements within this function.
                                Open

                                        return `Property '${host}.${node.key}' was removed`;
                                Severity: Major
                                Found in src/strategies/renderAstToPlain.js - About 30 mins to fix

                                  Avoid too many return statements within this function.
                                  Open

                                          return null;
                                  Severity: Major
                                  Found in src/strategies/renderAstToPlain.js - About 30 mins to fix
                                    Severity
                                    Category
                                    Status
                                    Source
                                    Language