Avoid deeply nested control flow statements.

Open

                    completion_proc.call(build_number, false) if completion_proc

Avoid deeply nested control flow statements.

Open

                  completion_proc.call(nil, true) if completion_proc

Avoid deeply nested control flow statements.

Open

                rescue JenkinsApi::Exceptions::ApiException => e
                  completion_proc.call(nil, false) if completion_proc
                  @logger.warn "Error while attempting to cancel pending job for '#{job_name}'. #{e.class} #{e}"
                  raise

Consider simplifying this complex logical expression.

Open

        if version_a_d[0] > version_b_d[0] ||
          (version_a_d[0] == version_b_d[0] && version_a_d[1] > version_b_d[1]) ||
          (version_a_d[0] == version_b_d[0] && version_a_d[1] == version_b_d[1] && version_a_d[2] > version_b_d[2])
          return 1
        else

Method wait_for_ready has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.

Open

      def wait_for_ready
        Timeout::timeout(@timeout) do
          while true do
            response = @client.get_root
            @logger.info "Waiting for jenkins to restart..."

• Read up
  Read up

Method create_list_view has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.

Open

      def create_list_view(params)
        # Name is a required parameter. Raise an error if not specified
        raise ArgumentError, "Name is required for creating view" \
          unless params.is_a?(Hash) && params[:name]
        create(params[:name], "listview")

• Read up
  Read up

Method list_available has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.

Open

      def list_available(filters = {})
        supported_filters = [:category, :dependency]
        filter_plural_map = {
          :dependency => "dependencies",
          :category => "categories"

• Read up
  Read up

Method list has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.

Open

      def list(filter = nil, ignorecase = true, slaveonly = false)
        @logger.info "Obtaining nodes from jenkins matching filter '#{filter}'"
        node_names = []
        response_json = @client.api_get_request("/computer")
        response_json["computer"].each do |computer|

• Read up
  Read up

Method exec_cli has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.

Open

    def exec_cli(command, args = [])
      base_dir = File.dirname(__FILE__)
      server_url = "http://#{@server_ip}:#{@server_port}/#{@jenkins_path}"
      cmd = "java -jar #{base_dir}/../../java_deps/jenkins-cli.jar -s #{server_url}"
      cmd << " -i #{@identity_file}" if @identity_file && !@identity_file.empty?

• Read up
  Read up

Method setup has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.

Open

      def self.setup(options)
        if options[:username] && options[:server_ip] && \
          (options[:password] || options[:password_base64])
          creds = options
        elsif options[:creds_file]

• Read up
  Read up

Method get_artifacts has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.

Open

    def get_artifacts(job_name, dldir, build_number = nil)
      @artifacts = job.find_artifacts(job_name,build_number)
      results = []
      @artifacts.each do |artifact|
        uri = URI.parse(artifact)

• Read up
  Read up

Method scm_cvs has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.

Open

      def scm_cvs(params, xml)
        xml.scm(:class => "hudson.scm.CVSSCM",
                :plugin => "cvs@1.6") {
          xml.cvsroot "#{params[:scm_url]}"
          xml.module "#{params[:scm_module]}"

• Read up
  Read up

Method online_offline_lists has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.

Open

      def online_offline_lists(filter = nil, ignorecase = true)
        @logger.info "Obtaining nodes from jenkins matching filter '#{filter}'"
        offline_node_names = []
        online_node_names = []
        response_json = @client.api_get_request("/computer")

• Read up
  Read up

Method list_installed has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.

Open

      def list_installed(filters = {})
        supported_filters = [
          :active, :bundled, :deleted, :downgradable, :enabled, :hasUpdate,
          :pinned
        ]

• Read up
  Read up

Method list has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.

Open

      def list(filter = "", ignorecase = true)
        @logger.info "Obtaining views based on filter '#{filter}'"
        view_names = []
        response_json = @client.api_get_request("", "tree=views[name]")
        response_json["views"].each { |view|

• Read up
  Read up

Method list has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.

Open

      def list(filter, ignorecase = true)
        @logger.info "Obtaining jobs matching filter '#{filter}'"
        response_json = @client.api_get_request("")
        jobs = []
        response_json["jobs"].each do |job|

• Read up
  Read up